All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE
Date: Sun, 24 Aug 2008 19:09:24 +0300	[thread overview]
Message-ID: <48B187B4.4000302@nic.fi> (raw)
In-Reply-To: <20080824142944.GA9470@pina.cat>

Carles Pina i Estany wrote:
> I was just thinking... is there any reason that we have the same macros
> in 4 different files?
> 
> Why not having just a grub/console_scancodes.h: 
> 
> #ifndef GRUB_CONSOLE_SCAN_CODES
> 
> #define GRUB_CONSOLE_KEY_LEFT           0x4B00
> #define GRUB_CONSOLE_KEY_RIGHT          0x4D00
> #define GRUB_CONSOLE_KEY_UP             0x4800
> #define GRUB_CONSOLE_KEY_DOWN           0x5000
> #define GRUB_CONSOLE_KEY_IC             0x5200
> #define GRUB_CONSOLE_KEY_DC             0x5300
> #define GRUB_CONSOLE_KEY_BACKSPACE      0x0008
> #define GRUB_CONSOLE_KEY_HOME           0x4700
> #define GRUB_CONSOLE_KEY_END            0x4F00
> #define GRUB_CONSOLE_KEY_NPAGE          0x5100
> #define GRUB_CONSOLE_KEY_PPAGE          0x4900
> 
> #endif
> 
> and include this file from the other 4 files?

Sounds fine. Why do we have same thing with TERM and CONSOLE?

Thanks,
Vesa Jääskeläinen



  reply	other threads:[~2008-08-24 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-24 13:02 [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE Carles Pina i Estany
2008-08-24 14:29 ` Carles Pina i Estany
2008-08-24 16:09   ` Vesa Jääskeläinen [this message]
2008-08-24 18:11     ` Carles Pina i Estany
2008-09-24 10:23     ` Robert Millan
2008-08-30 11:50   ` Robert Millan
2008-09-05 17:00     ` Carles Pina i Estany
2008-08-24 18:34 ` [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE (summary) Carles Pina i Estany
2008-09-24 10:25   ` Robert Millan
2008-09-24 10:22 ` [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B187B4.4000302@nic.fi \
    --to=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.