From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE
Date: Sat, 30 Aug 2008 13:50:05 +0200 [thread overview]
Message-ID: <20080830115005.GE16775@thorin> (raw)
In-Reply-To: <20080824142944.GA9470@pina.cat>
On Sun, Aug 24, 2008 at 04:29:44PM +0200, Carles Pina i Estany wrote:
>
> Hi,
>
> I was just thinking now...
>
> On Aug/24/2008, Carles Pina i Estany wrote:
>
> > * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE):
> > Changed to 0x5100.
> > (GRUB_TERM_PPAGE): Changed to 0x4900.
> >
> > * include/grub/sparc64/ieee1275/console.h: Likewise.
> >
> > * include/grub/i386/pc/console.h: Likewise.
> >
> > * include/grub/efi/console.h: Likewise.
>
> I was just thinking... is there any reason that we have the same macros
> in 4 different files?
This would need to be checked carefully, but a quick peek at
GRUB_CONSOLE_KEY_LEFT:
./kern/i386/pc/startup.S: .word GRUB_CONSOLE_KEY_LEFT, GRUB_TERM_LEFT
./include/grub/i386/pc/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00
./include/grub/efi/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00
./include/grub/powerpc/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00
./include/grub/sparc64/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00
seems to indicate these macros are part of the BIOS console interface,
and therefore only used on i386-pc.
If you can confirm this, I'd recommend just removing them from the other
console.h files.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-08-30 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 13:02 [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE Carles Pina i Estany
2008-08-24 14:29 ` Carles Pina i Estany
2008-08-24 16:09 ` Vesa Jääskeläinen
2008-08-24 18:11 ` Carles Pina i Estany
2008-09-24 10:23 ` Robert Millan
2008-08-30 11:50 ` Robert Millan [this message]
2008-09-05 17:00 ` Carles Pina i Estany
2008-08-24 18:34 ` [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE (summary) Carles Pina i Estany
2008-09-24 10:25 ` Robert Millan
2008-09-24 10:22 ` [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080830115005.GE16775@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.