[patch 2.6.27-rc6] spi_s3c24xx: fix section warning

[patch 2.6.27-rc6] spi_s3c24xx: fix section warning

[David Brownell]

From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>

Fix the section mismatch warning generated by the iconrrect
naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:

WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
  Section mismatch in reference from the variable s3c24xx_spidrv
  to the (unknown reference) .exit.text:(unknown)

Signed-off-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
---
 drivers/spi/spi_s3c24xx.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/spi/spi_s3c24xx.c
+++ b/drivers/spi/spi_s3c24xx.c
@@ -436,7 +436,7 @@ static int s3c24xx_spi_resume(struct pla
 #endif
 
 MODULE_ALIAS("platform:s3c2410-spi");
-static struct platform_driver s3c24xx_spidrv = {
+static struct platform_driver s3c24xx_spi_driver = {
 	.remove		= __exit_p(s3c24xx_spi_remove),
 	.suspend	= s3c24xx_spi_suspend,
 	.resume		= s3c24xx_spi_resume,
@@ -448,12 +448,12 @@ static struct platform_driver s3c24xx_sp
 
 static int __init s3c24xx_spi_init(void)
 {
-        return platform_driver_probe(&s3c24xx_spidrv, s3c24xx_spi_probe);
+        return platform_driver_probe(&s3c24xx_spi_driver, s3c24xx_spi_probe);
 }
 
 static void __exit s3c24xx_spi_exit(void)
 {
-        platform_driver_unregister(&s3c24xx_spidrv);
+        platform_driver_unregister(&s3c24xx_spi_driver);
 }
 
 module_init(s3c24xx_spi_init);

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [patch 2.6.27-rc6] spi_s3c24xx: fix section warning

[Andrew Morton]

On Fri, 12 Sep 2008 09:44:13 -0700
David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:

> From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
> 
> Fix the section mismatch warning generated by the iconrrect
> naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:
> 
> WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
>   Section mismatch in reference from the variable s3c24xx_spidrv
>   to the (unknown reference) .exit.text:(unknown)
> 
> Signed-off-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
> Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> ---
>  drivers/spi/spi_s3c24xx.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- a/drivers/spi/spi_s3c24xx.c
> +++ b/drivers/spi/spi_s3c24xx.c
> @@ -436,7 +436,7 @@ static int s3c24xx_spi_resume(struct pla
>  #endif
>  
>  MODULE_ALIAS("platform:s3c2410-spi");
> -static struct platform_driver s3c24xx_spidrv = {
> +static struct platform_driver s3c24xx_spi_driver = {
>  	.remove		= __exit_p(s3c24xx_spi_remove),
>  	.suspend	= s3c24xx_spi_suspend,
>  	.resume		= s3c24xx_spi_resume,
> @@ -448,12 +448,12 @@ static struct platform_driver s3c24xx_sp
>  
>  static int __init s3c24xx_spi_init(void)
>  {
> -        return platform_driver_probe(&s3c24xx_spidrv, s3c24xx_spi_probe);
> +        return platform_driver_probe(&s3c24xx_spi_driver, s3c24xx_spi_probe);
>  }
>  
>  static void __exit s3c24xx_spi_exit(void)
>  {
> -        platform_driver_unregister(&s3c24xx_spidrv);
> +        platform_driver_unregister(&s3c24xx_spi_driver);
>  }
>  
>  module_init(s3c24xx_spi_init);

whoa.  We have kbuild magic which relies unpn a name ending in "_driver"?

Why did I just learn that.  Do you know if this magic is described
anywhere?

Thanks.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [patch 2.6.27-rc6] spi_s3c24xx: fix section warning

[David Brownell]

On Friday 12 September 2008, Andrew Morton wrote:
> On Fri, 12 Sep 2008 09:44:13 -0700
> David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> 
> > From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
> > 
> > Fix the section mismatch warning generated by the iconrrect
> > naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:
> > 
> > WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
> >   Section mismatch in reference from the variable s3c24xx_spidrv
> >   to the (unknown reference) .exit.text:(unknown)
> > 
> > ...
> 
> whoa.  We have kbuild magic which relies unpn a name ending in "_driver"?
> 
> Why did I just learn that.  Do you know if this magic is described
> anywhere?

You probably just learned that because you have better things
to do than run with the appended patch, and then fixing the
resulting warnings (sample shown above) according to the magic
handwaving at secref_whitelist() in scripts/mod/modpost.c ...

---
 lib/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/lib/Kconfig.debug	2008-07-22 15:27:52.000000000 -0700
+++ b/lib/Kconfig.debug	2008-07-22 15:31:34.000000000 -0700
@@ -95,7 +95,7 @@ config HEADERS_CHECK
 
 config DEBUG_SECTION_MISMATCH
 	bool "Enable full Section mismatch analysis"
-	depends on UNDEFINED
+	# depends on UNDEFINED
 	# This option is on purpose disabled for now.
 	# It will be enabled when we are down to a resonable number
 	# of section mismatch warnings (< 10 for an allyesconfig build)

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [patch 2.6.27-rc6] spi_s3c24xx: fix section warning

[Ben Dooks]

On Fri, Sep 12, 2008 at 04:54:08PM -0700, David Brownell wrote:
> On Friday 12 September 2008, Andrew Morton wrote:
> > On Fri, 12 Sep 2008 09:44:13 -0700
> > David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> > 
> > > From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
> > > 
> > > Fix the section mismatch warning generated by the iconrrect
> > > naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:
> > > 
> > > WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
> > >   Section mismatch in reference from the variable s3c24xx_spidrv
> > >   to the (unknown reference) .exit.text:(unknown)
> > > 
> > > ...
> > 
> > whoa.  We have kbuild magic which relies unpn a name ending in "_driver"?
> > 
> > Why did I just learn that.  Do you know if this magic is described
> > anywhere?
> 
> You probably just learned that because you have better things
> to do than run with the appended patch, and then fixing the
> resulting warnings (sample shown above) according to the magic
> handwaving at secref_whitelist() in scripts/mod/modpost.c ...
> 
> ---
>  lib/Kconfig.debug |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/lib/Kconfig.debug	2008-07-22 15:27:52.000000000 -0700
> +++ b/lib/Kconfig.debug	2008-07-22 15:31:34.000000000 -0700
> @@ -95,7 +95,7 @@ config HEADERS_CHECK
>  
>  config DEBUG_SECTION_MISMATCH
>  	bool "Enable full Section mismatch analysis"
> -	depends on UNDEFINED
> +	# depends on UNDEFINED
>  	# This option is on purpose disabled for now.
>  	# It will be enabled when we are down to a resonable number
>  	# of section mismatch warnings (< 10 for an allyesconfig build)

I have something similar in my tree. It would be nice to sort this out
so it wasn't disabled by default.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/