All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit
@ 2008-10-13  6:06 ` Grant Grundler
  0 siblings, 0 replies; 16+ messages in thread
From: Grant Grundler @ 2008-10-13  6:06 UTC (permalink / raw)
  To: linux-driver; +Cc: netdev, ron.mercer, linux-ia64

QLGE driver only supports 4k, 8k, and 64k pages.
Default page size on ia64 is 16k. Compile fails with:
drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function)

Patch below makes the cause of the compile failure obvious.
(Better would be to support 16k pages but I don't have the HW or interest.)

Signed-off-by: Grant Grundler <grundler@parisc-linux.org>


diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index c37ea43..cf68503 100644
--- a/drivers/net/qlge/qlge.h
+++ b/drivers/net/qlge/qlge.h
@@ -60,6 +60,8 @@
 #define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2)
 #elif (PAGE_SHIFT = 16)	/* 64k pages */
 #define TX_DESC_PER_OAL 0
+#else
+#error QLGE Driver only supports 4k, 8k, or 64k CPU page size.
 #endif
 
 #define DB_PAGE_SIZE 4096

^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2008-10-14  5:56 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-13  6:06 [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit Grant Grundler
2008-10-13  6:06 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Grant Grundler
2008-10-13  6:09 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-13  6:09   ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14  1:54   ` Ron Mercer
2008-10-14  1:54     ` Ron Mercer
2008-10-14  2:03     ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14  2:03       ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14  2:19       ` Matthew Wilcox
2008-10-14  2:19         ` Matthew Wilcox
2008-10-14  2:31         ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14  2:31           ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14  2:53           ` Ron Mercer
2008-10-14  2:53             ` Ron Mercer
2008-10-14  5:56             ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14  5:56               ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.