* [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver.
@ 2008-10-14 6:07 Jagadeesh Bhaskar Pakaravoor
2008-10-16 21:23 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Jagadeesh Bhaskar Pakaravoor @ 2008-10-14 6:07 UTC (permalink / raw)
To: linux-omap; +Cc: tony, Jagadeesh Bhaskar Pakaravoor
The i2c_driver in twl4030-core.c and platform_driver of twl4030-usb.c
both has the name twl4030_driver. This leads to unnecessary confusion.
So rename the usb platform_driver appropriately to:
twl4030_usb_driver.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
Index: linux-omap-git/drivers/i2c/chips/twl4030-usb.c
===================================================================
--- linux-omap-git.orig/drivers/i2c/chips/twl4030-usb.c 2008-10-10 20:35:15.000000000 +0530
+++ linux-omap-git/drivers/i2c/chips/twl4030-usb.c 2008-10-14 11:01:09.785700607 +0530
@@ -758,7 +758,7 @@ static int __exit twl4030_usb_remove(str
return 0;
}
-static struct platform_driver twl4030_driver = {
+static struct platform_driver twl4030_usb_driver = {
.probe = twl4030_usb_probe,
.remove = __exit_p(twl4030_remove),
.driver = {
@@ -769,13 +769,13 @@ static struct platform_driver twl4030_dr
static int __init twl4030_usb_init(void)
{
- return platform_driver_register(&twl4030_driver);
+ return platform_driver_register(&twl4030_usb_driver);
}
subsys_initcall(twl4030_usb_init);
static void __exit twl4030_usb_exit(void)
{
- platform_driver_unregister(&twl4030_driver);
+ platform_driver_unregister(&twl4030_usb_driver);
}
module_exit(twl4030_usb_exit);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver.
2008-10-14 6:07 [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver Jagadeesh Bhaskar Pakaravoor
@ 2008-10-16 21:23 ` Tony Lindgren
2008-10-16 22:05 ` David Brownell
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2008-10-16 21:23 UTC (permalink / raw)
To: David Brownell; +Cc: linux-omap, Jagadeesh Bhaskar Pakaravoor
* Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com> [081014 11:08]:
> The i2c_driver in twl4030-core.c and platform_driver of twl4030-usb.c
> both has the name twl4030_driver. This leads to unnecessary confusion.
>
> So rename the usb platform_driver appropriately to:
> twl4030_usb_driver.
Dave, is this OK with you? I don't want this to get out of sync with
mainline..
Tony
>
> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> Index: linux-omap-git/drivers/i2c/chips/twl4030-usb.c
> ===================================================================
> --- linux-omap-git.orig/drivers/i2c/chips/twl4030-usb.c 2008-10-10 20:35:15.000000000 +0530
> +++ linux-omap-git/drivers/i2c/chips/twl4030-usb.c 2008-10-14 11:01:09.785700607 +0530
> @@ -758,7 +758,7 @@ static int __exit twl4030_usb_remove(str
> return 0;
> }
>
> -static struct platform_driver twl4030_driver = {
> +static struct platform_driver twl4030_usb_driver = {
> .probe = twl4030_usb_probe,
> .remove = __exit_p(twl4030_remove),
> .driver = {
> @@ -769,13 +769,13 @@ static struct platform_driver twl4030_dr
>
> static int __init twl4030_usb_init(void)
> {
> - return platform_driver_register(&twl4030_driver);
> + return platform_driver_register(&twl4030_usb_driver);
> }
> subsys_initcall(twl4030_usb_init);
>
> static void __exit twl4030_usb_exit(void)
> {
> - platform_driver_unregister(&twl4030_driver);
> + platform_driver_unregister(&twl4030_usb_driver);
> }
> module_exit(twl4030_usb_exit);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver.
2008-10-16 21:23 ` Tony Lindgren
@ 2008-10-16 22:05 ` David Brownell
2008-10-16 22:08 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: David Brownell @ 2008-10-16 22:05 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, Jagadeesh Bhaskar Pakaravoor
On Thursday 16 October 2008, Tony Lindgren wrote:
> * Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com> [081014 11:08]:
> > The i2c_driver in twl4030-core.c and platform_driver of twl4030-usb.c
> > both has the name twl4030_driver. This leads to unnecessary confusion.
> >
> > So rename the usb platform_driver appropriately to:
> > twl4030_usb_driver.
>
> Dave, is this OK with you? I don't want this to get out of sync with
> mainline..
Sure, no problem. This driver isn't yet in the mainline queue.
> Tony
>
> >
> > Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> > Index: linux-omap-git/drivers/i2c/chips/twl4030-usb.c
> > ===================================================================
> > --- linux-omap-git.orig/drivers/i2c/chips/twl4030-usb.c 2008-10-10 20:35:15.000000000 +0530
> > +++ linux-omap-git/drivers/i2c/chips/twl4030-usb.c 2008-10-14 11:01:09.785700607 +0530
> > @@ -758,7 +758,7 @@ static int __exit twl4030_usb_remove(str
> > return 0;
> > }
> >
> > -static struct platform_driver twl4030_driver = {
> > +static struct platform_driver twl4030_usb_driver = {
> > .probe = twl4030_usb_probe,
> > .remove = __exit_p(twl4030_remove),
> > .driver = {
> > @@ -769,13 +769,13 @@ static struct platform_driver twl4030_dr
> >
> > static int __init twl4030_usb_init(void)
> > {
> > - return platform_driver_register(&twl4030_driver);
> > + return platform_driver_register(&twl4030_usb_driver);
> > }
> > subsys_initcall(twl4030_usb_init);
> >
> > static void __exit twl4030_usb_exit(void)
> > {
> > - platform_driver_unregister(&twl4030_driver);
> > + platform_driver_unregister(&twl4030_usb_driver);
> > }
> > module_exit(twl4030_usb_exit);
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver.
2008-10-16 22:05 ` David Brownell
@ 2008-10-16 22:08 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2008-10-16 22:08 UTC (permalink / raw)
To: David Brownell; +Cc: linux-omap, Jagadeesh Bhaskar Pakaravoor
* David Brownell <david-b@pacbell.net> [081016 15:05]:
> On Thursday 16 October 2008, Tony Lindgren wrote:
> > * Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com> [081014 11:08]:
> > > The i2c_driver in twl4030-core.c and platform_driver of twl4030-usb.c
> > > both has the name twl4030_driver. This leads to unnecessary confusion.
> > >
> > > So rename the usb platform_driver appropriately to:
> > > twl4030_usb_driver.
> >
> > Dave, is this OK with you? I don't want this to get out of sync with
> > mainline..
>
> Sure, no problem. This driver isn't yet in the mainline queue.
OK, pushed.
Tony
>
>
> > Tony
> >
> > >
> > > Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> > > Index: linux-omap-git/drivers/i2c/chips/twl4030-usb.c
> > > ===================================================================
> > > --- linux-omap-git.orig/drivers/i2c/chips/twl4030-usb.c 2008-10-10 20:35:15.000000000 +0530
> > > +++ linux-omap-git/drivers/i2c/chips/twl4030-usb.c 2008-10-14 11:01:09.785700607 +0530
> > > @@ -758,7 +758,7 @@ static int __exit twl4030_usb_remove(str
> > > return 0;
> > > }
> > >
> > > -static struct platform_driver twl4030_driver = {
> > > +static struct platform_driver twl4030_usb_driver = {
> > > .probe = twl4030_usb_probe,
> > > .remove = __exit_p(twl4030_remove),
> > > .driver = {
> > > @@ -769,13 +769,13 @@ static struct platform_driver twl4030_dr
> > >
> > > static int __init twl4030_usb_init(void)
> > > {
> > > - return platform_driver_register(&twl4030_driver);
> > > + return platform_driver_register(&twl4030_usb_driver);
> > > }
> > > subsys_initcall(twl4030_usb_init);
> > >
> > > static void __exit twl4030_usb_exit(void)
> > > {
> > > - platform_driver_unregister(&twl4030_driver);
> > > + platform_driver_unregister(&twl4030_usb_driver);
> > > }
> > > module_exit(twl4030_usb_exit);
> > >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-16 22:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-14 6:07 [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver Jagadeesh Bhaskar Pakaravoor
2008-10-16 21:23 ` Tony Lindgren
2008-10-16 22:05 ` David Brownell
2008-10-16 22:08 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.