From: Yu Zhao <yu.zhao@intel.com>
To: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: "achiang@hp.com" <achiang@hp.com>,
"grundler@parisc-linux.org" <grundler@parisc-linux.org>,
"greg@kroah.com" <greg@kroah.com>,
"mingo@elte.hu" <mingo@elte.hu>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"matthew@wil.cx" <matthew@wil.cx>,
"randy.dunlap@oracle.com" <randy.dunlap@oracle.com>,
"rdreier@cisco.com" <rdreier@cisco.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: [PATCH 9/16 v6] PCI: add boot option to align MMIO resources
Date: Wed, 22 Oct 2008 16:43:24 +0800 [thread overview]
Message-ID: <20081022084324.GI3773@yzhao12-linux.sh.intel.com> (raw)
In-Reply-To: <20081022083809.GA3757@yzhao12-linux.sh.intel.com>
This patch adds boot option to align MMIO resource for a device.
The alignment is a bigger value between the PAGE_SIZE and the
resource size.
The boot option can be used as:
pci=align-mmio=0000:01:02.3
'[0000:]01:02.3' is the domain, bus, device and function number
of the device.
Cc: Alex Chiang <achiang@hp.com>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Greg KH <greg@kroah.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Roland Dreier <rdreier@cisco.com>
Signed-off-by: Yu Zhao <yu.zhao@intel.com>
---
arch/x86/pci/common.c | 37 +++++++++++++++++++++++++++++++++++++
drivers/pci/pci.c | 20 ++++++++++++++++++--
include/linux/pci.h | 1 +
3 files changed, 56 insertions(+), 2 deletions(-)
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index 06e1ce0..3c5d230 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -139,6 +139,7 @@ static void __devinit pcibios_fixup_device_resources(struct pci_dev *dev)
static char *pci_assign_pio;
static char *pci_assign_mmio;
+static char *pci_align_mmio;
static int pcibios_bus_resource_needs_fixup(struct pci_bus *bus)
{
@@ -192,6 +193,36 @@ static void __devinit pcibios_fixup_bus_resources(struct pci_bus *bus)
}
}
+int pcibios_resource_alignment(struct pci_dev *dev, int resno)
+{
+ int domain, busnr, slot, func;
+ char *str = pci_align_mmio;
+
+ if (dev->resource[resno].flags & IORESOURCE_IO)
+ return 0;
+
+ while (str && *str) {
+ if (sscanf(str, "%04x:%02x:%02x.%d",
+ &domain, &busnr, &slot, &func) != 4) {
+ if (sscanf(str, "%02x:%02x.%d",
+ &busnr, &slot, &func) != 3)
+ break;
+ domain = 0;
+ }
+
+ if (pci_domain_nr(dev->bus) == domain &&
+ dev->bus->number == busnr &&
+ dev->devfn == PCI_DEVFN(slot, func))
+ return PAGE_SIZE;
+
+ str = strchr(str, ';');
+ if (str)
+ str++;
+ }
+
+ return 0;
+}
+
int pcibios_resource_needs_fixup(struct pci_dev *dev, int resno)
{
struct pci_bus *bus;
@@ -200,6 +231,9 @@ int pcibios_resource_needs_fixup(struct pci_dev *dev, int resno)
if (pcibios_bus_resource_needs_fixup(bus))
return 1;
+ if (pcibios_resource_alignment(dev, resno))
+ return 1;
+
return 0;
}
@@ -592,6 +626,9 @@ char * __devinit pcibios_setup(char *str)
} else if (!strncmp(str, "assign-mmio=", 12)) {
pci_assign_mmio = str + 12;
return NULL;
+ } else if (!strncmp(str, "align-mmio=", 11)) {
+ pci_align_mmio = str + 11;
+ return NULL;
}
return str;
}
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index b02167a..11ecd6f 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1015,6 +1015,20 @@ int __attribute__ ((weak)) pcibios_set_pcie_reset_state(struct pci_dev *dev,
}
/**
+ * pcibios_resource_alignment - get resource alignment requirement
+ * @dev: the PCI device
+ * @resno: resource number
+ *
+ * Queries the resource alignment from PCI low level code. Returns positive
+ * if there is alignment requirement of the resource, or 0 otherwise.
+ */
+int __attribute__ ((weak)) pcibios_resource_alignment(struct pci_dev *dev,
+ int resno)
+{
+ return 0;
+}
+
+/**
* pci_set_pcie_reset_state - set reset state for device dev
* @dev: the PCI-E device reset
* @state: Reset state to enter into
@@ -1913,12 +1927,14 @@ int pci_select_bars(struct pci_dev *dev, unsigned long flags)
*/
int pci_resource_alignment(struct pci_dev *dev, int resno)
{
- resource_size_t align;
+ resource_size_t align, bios_align;
struct resource *res = dev->resource + resno;
+ bios_align = pcibios_resource_alignment(dev, resno);
+
align = resource_alignment(res);
if (align)
- return align;
+ return align > bios_align ? align : bios_align;
dev_err(&dev->dev, "alignment: invalid resource #%d\n", resno);
return 0;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 2ada2b6..6ac69af 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1121,6 +1121,7 @@ int pcibios_add_platform_entries(struct pci_dev *dev);
void pcibios_disable_device(struct pci_dev *dev);
int pcibios_set_pcie_reset_state(struct pci_dev *dev,
enum pcie_reset_state state);
+int pcibios_resource_alignment(struct pci_dev *dev, int resno);
#ifdef CONFIG_PCI_MMCONFIG
extern void __init pci_mmcfg_early_init(void);
--
1.5.6.4
next prev parent reply other threads:[~2008-10-22 9:40 UTC|newest]
Thread overview: 237+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 8:38 [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support Yu Zhao
2008-10-22 8:40 ` [PATCH 1/16 v6] PCI: remove unnecessary arg of pci_update_resource() Yu Zhao
2008-10-22 8:40 ` Yu Zhao
2008-10-22 8:40 ` [PATCH 2/16 v6] PCI: define PCI resource names in an 'enum' Yu Zhao
2008-10-22 8:40 ` Yu Zhao
2008-10-22 14:24 ` Bjorn Helgaas
2008-10-22 14:44 ` Yu Zhao
2008-10-22 14:44 ` Yu Zhao
2008-10-22 14:51 ` Bjorn Helgaas
2008-10-22 14:51 ` Bjorn Helgaas
2008-10-22 14:53 ` Yu Zhao
2008-10-22 14:53 ` Yu Zhao
2008-10-22 14:24 ` Bjorn Helgaas
2008-11-14 0:43 ` Simon Horman
2008-10-22 8:41 ` [PATCH 3/16 v6] PCI: export __pci_read_base Yu Zhao
2008-10-22 8:41 ` Yu Zhao
2008-10-22 8:41 ` [PATCH 4/16 v6] PCI: make pci_alloc_child_bus() be able to handle NULL bridge Yu Zhao
2008-10-22 8:41 ` Yu Zhao
2008-10-22 8:41 ` [PATCH 5/16 v6] PCI: add a wrapper for resource_alignment() Yu Zhao
2008-10-22 8:41 ` Yu Zhao
2008-10-22 8:42 ` [PATCH 6/16 v6] PCI: add a new function to map BAR offset Yu Zhao
2008-10-22 8:42 ` Yu Zhao
2008-10-22 8:42 ` [PATCH 7/16 v6] PCI: cleanup pcibios_allocate_resources() Yu Zhao
2008-10-22 8:42 ` Yu Zhao
2008-10-23 7:10 ` Yinghai Lu
2008-10-23 7:10 ` Yinghai Lu
2008-10-23 6:50 ` Yu Zhao
2008-10-23 6:50 ` Yu Zhao
2008-10-22 8:43 ` [PATCH 8/16 v6] PCI: add boot options to reassign resources Yu Zhao
2008-10-22 14:35 ` Bjorn Helgaas
2008-10-22 14:35 ` Bjorn Helgaas
2008-10-22 14:49 ` Yu Zhao
2008-10-22 14:49 ` Yu Zhao
2008-10-22 8:43 ` Yu Zhao
2008-10-22 8:43 ` [PATCH 9/16 v6] PCI: add boot option to align MMIO resources Yu Zhao
2008-10-22 8:43 ` Yu Zhao [this message]
2008-10-22 14:34 ` Bjorn Helgaas
2008-10-22 14:52 ` Yu Zhao
2008-10-22 14:52 ` Yu Zhao
2008-10-22 14:34 ` Bjorn Helgaas
2008-10-22 8:43 ` [PATCH 10/16 v6] PCI: cleanup pci_bus_add_devices() Yu Zhao
2008-10-22 8:43 ` Yu Zhao
2008-10-22 8:44 ` [PATCH 11/16 v6] PCI: split a new function from pci_bus_add_devices() Yu Zhao
2008-10-22 8:44 ` Yu Zhao
2008-10-22 8:44 ` [PATCH 12/16 v6] PCI: support the SR-IOV capability Yu Zhao
2008-10-22 8:44 ` Yu Zhao
2008-10-22 8:44 ` [PATCH 13/16 v6] PCI: reserve bus range for SR-IOV device Yu Zhao
2008-10-22 8:44 ` Yu Zhao
2008-10-22 8:45 ` [PATCH 14/16 v6] PCI: document for SR-IOV user and developer Yu Zhao
2008-10-22 8:45 ` Yu Zhao
2008-10-22 8:45 ` [PATCH 15/16 v6] PCI: document the SR-IOV sysfs entries Yu Zhao
2008-11-06 4:33 ` Greg KH
2008-11-06 4:33 ` Greg KH
2008-11-06 4:46 ` Greg KH
2008-11-07 3:01 ` Zhao, Yu
2008-11-07 3:18 ` Greg KH
2008-11-13 6:50 ` Yu Zhao
2008-11-14 0:55 ` Greg KH
2008-11-17 8:09 ` Yu Zhao
2008-11-18 15:05 ` Greg KH
2008-11-18 15:05 ` Greg KH
2008-11-18 16:49 ` Kay Sievers
2008-11-18 16:49 ` Kay Sievers
2008-11-17 8:09 ` Yu Zhao
2008-11-13 6:50 ` Yu Zhao
2008-11-07 3:18 ` Greg KH
2008-11-07 3:01 ` Zhao, Yu
2008-11-06 4:46 ` Greg KH
2008-10-22 8:45 ` Yu Zhao
2008-10-22 8:45 ` [PATCH 16/16 v6] PCI: document the new PCI boot parameters Yu Zhao
2008-10-22 14:27 ` Bjorn Helgaas
2008-10-22 17:01 ` Randy Dunlap
2008-10-22 17:01 ` Randy Dunlap
2008-10-22 14:27 ` Bjorn Helgaas
2008-11-06 4:32 ` Greg KH
2008-11-06 4:32 ` Greg KH
2008-11-07 2:37 ` Zhao, Yu
2008-11-07 2:50 ` Greg KH
2008-11-07 2:50 ` Greg KH
2008-11-07 3:40 ` Zhao, Yu
2008-11-07 4:17 ` Matthew Wilcox
2008-11-07 4:17 ` Matthew Wilcox
2008-12-11 1:43 ` Yu Zhao
2008-12-11 4:33 ` Grant Grundler
2008-12-11 15:39 ` H L
2008-12-11 15:39 ` H L
2008-12-11 4:33 ` Grant Grundler
2008-12-11 1:43 ` Yu Zhao
2008-11-07 6:16 ` Greg KH
2008-11-07 6:16 ` Greg KH
2008-11-07 7:50 ` Zhao, Yu
2008-11-07 7:50 ` Zhao, Yu
2008-11-07 8:02 ` Greg KH
2008-11-07 8:17 ` Zhao, Yu
2008-11-07 8:17 ` Zhao, Yu
2008-11-07 8:24 ` Greg KH
2008-11-07 8:35 ` Zhao, Yu
2008-11-07 18:53 ` Greg KH
2008-11-07 18:53 ` Greg KH
2008-11-08 5:00 ` Yu Zhao
2008-11-08 5:25 ` Greg KH
2008-11-08 6:05 ` Yu Zhao
2008-11-08 6:05 ` Yu Zhao
2008-11-08 5:25 ` Greg KH
2008-11-08 5:50 ` freevanx
2008-11-08 5:54 ` Greg KH
2008-11-08 5:54 ` Greg KH
2008-11-08 5:00 ` Yu Zhao
2008-11-07 8:35 ` Zhao, Yu
2008-11-07 8:24 ` Greg KH
2008-11-07 8:02 ` Greg KH
2008-11-09 14:19 ` Pavel Machek
2008-11-09 14:34 ` Alexander Graf
2008-11-09 14:34 ` Alexander Graf
2008-11-09 14:19 ` Pavel Machek
2008-11-07 3:40 ` Zhao, Yu
2008-11-07 2:37 ` Zhao, Yu
2008-10-22 8:45 ` Yu Zhao
2008-11-06 4:48 ` [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support Greg KH
2008-11-06 4:48 ` Greg KH
2008-11-06 15:40 ` H L
2008-11-06 15:40 ` H L
2008-11-06 15:43 ` Greg KH
2008-11-06 15:43 ` Greg KH
2008-11-06 16:41 ` H L
2008-11-06 16:49 ` Greg KH
2008-11-06 17:38 ` Fischer, Anna
2008-11-06 18:03 ` Greg KH
2008-11-06 18:03 ` Greg KH
2008-11-06 20:04 ` Fischer, Anna
2008-11-06 20:04 ` Fischer, Anna
2008-11-09 12:44 ` Avi Kivity
2008-11-09 12:44 ` Avi Kivity
2008-11-09 19:25 ` Greg KH
2008-11-09 19:25 ` Greg KH
2008-11-09 19:37 ` Avi Kivity
2008-11-09 19:37 ` Avi Kivity
2008-11-11 6:08 ` Greg KH
2008-11-11 6:08 ` Greg KH
2008-11-11 9:00 ` Avi Kivity
2008-11-11 9:00 ` Avi Kivity
2008-11-06 18:36 ` Matthew Wilcox
2008-11-06 18:36 ` Matthew Wilcox
2008-11-06 22:38 ` Anthony Liguori
2008-11-06 22:38 ` Anthony Liguori
2008-11-06 22:58 ` Matthew Wilcox
2008-11-06 22:58 ` Matthew Wilcox
2008-11-07 6:19 ` Greg KH
2008-11-07 15:17 ` Yu Zhao
2008-11-07 18:48 ` Greg KH
2008-11-07 18:48 ` Greg KH
2008-11-08 11:09 ` Fischer, Anna
2008-11-08 11:09 ` Fischer, Anna
2008-11-08 15:37 ` Leonid Grossman
2008-11-08 15:37 ` Leonid Grossman
2008-11-08 11:09 ` Fischer, Anna
2008-11-13 7:49 ` Yu Zhao
2008-11-13 7:49 ` Yu Zhao
2008-11-13 7:49 ` Yu Zhao
2008-11-07 15:17 ` Yu Zhao
2008-11-07 6:19 ` Greg KH
2008-11-09 12:47 ` Avi Kivity
2008-11-09 12:47 ` Avi Kivity
2008-11-07 1:52 ` Dong, Eddie
2008-11-07 1:52 ` Dong, Eddie
2008-11-07 2:08 ` Nakajima, Jun
2008-11-07 2:08 ` Nakajima, Jun
2008-11-07 15:21 ` Andi Kleen
2008-11-09 12:53 ` Avi Kivity
2008-11-09 12:53 ` Avi Kivity
2008-11-07 15:21 ` Andi Kleen
2008-11-12 22:41 ` Anthony Liguori
2008-11-12 22:41 ` Anthony Liguori
2008-11-16 16:04 ` Avi Kivity
2008-11-17 1:46 ` Zhao, Yu
2008-11-17 1:46 ` Zhao, Yu
2008-11-16 16:04 ` Avi Kivity
2008-11-07 16:01 ` Yu Zhao
2008-11-07 16:01 ` Yu Zhao
2008-11-06 17:38 ` Fischer, Anna
2008-11-06 17:47 ` Matthew Wilcox
2008-11-06 17:47 ` Matthew Wilcox
2008-11-06 17:53 ` Greg KH
2008-11-06 22:24 ` Simon Horman
2008-11-06 22:24 ` Simon Horman
2008-11-06 22:40 ` Anthony Liguori
2008-11-06 22:40 ` Anthony Liguori
2008-11-07 6:17 ` Greg KH
2008-11-07 7:47 ` Zhao, Yu
2008-11-07 7:47 ` Zhao, Yu
2008-11-11 0:18 ` Rusty Russell
2008-11-17 12:01 ` Yu Zhao
2008-11-17 12:01 ` Yu Zhao
2008-11-09 12:58 ` Avi Kivity
2008-11-09 12:58 ` Avi Kivity
2008-11-07 6:17 ` Greg KH
2008-11-09 6:41 ` Muli Ben-Yehuda
2008-11-09 13:03 ` Avi Kivity
2008-11-09 13:03 ` Avi Kivity
2008-11-09 6:41 ` Muli Ben-Yehuda
2008-11-06 23:54 ` Chris Wright
2008-11-06 23:54 ` Chris Wright
2008-11-07 6:10 ` Greg KH
2008-11-07 6:10 ` Greg KH
2008-11-07 7:06 ` Zhao, Yu
2008-11-07 7:29 ` Leonid Grossman
2008-11-07 7:29 ` Leonid Grossman
2008-11-07 7:06 ` Zhao, Yu
2008-11-06 17:53 ` Greg KH
2008-11-06 18:05 ` H L
2008-11-06 18:05 ` H L
2008-11-06 18:24 ` Greg KH
2008-11-06 18:24 ` Greg KH
2008-11-06 21:35 ` Fischer, Anna
2008-11-07 6:18 ` Greg KH
2008-11-07 6:03 ` Zhao, Yu
2008-11-07 6:03 ` Zhao, Yu
2008-11-06 16:49 ` Greg KH
2008-11-06 16:41 ` H L
2008-11-06 16:51 ` git repository for SR-IOV development? H L
2008-11-06 16:51 ` H L
2008-11-06 16:59 ` Greg KH
2008-11-06 16:59 ` Greg KH
2008-11-06 19:58 ` H L
2008-11-06 22:56 ` Simon Horman
2008-11-06 22:56 ` Simon Horman
2008-11-06 22:56 ` Simon Horman
2008-11-07 1:58 ` Greg KH
2008-11-07 13:09 ` Yu Zhao
2008-11-07 13:09 ` Yu Zhao
2008-11-07 1:58 ` Greg KH
2008-11-06 19:58 ` H L
2008-11-06 16:51 ` H L
2008-11-07 5:18 ` [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support Zhao, Yu
2008-11-07 5:18 ` Zhao, Yu
2008-11-07 6:07 ` Greg KH
2008-11-07 6:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022084324.GI3773@yzhao12-linux.sh.intel.com \
--to=yu.zhao@intel.com \
--cc=achiang@hp.com \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.