All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: djwong@us.ibm.com, khali@linux-fr.org,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/5] adt7462: New hwmon driver
Date: Fri, 07 Nov 2008 19:27:31 +0000	[thread overview]
Message-ID: <20081107112731.cec03a04.akpm@linux-foundation.org> (raw)
In-Reply-To: <1226084691.11596.42.camel@brick>

On Fri, 07 Nov 2008 11:04:51 -0800
Harvey Harrison <harvey.harrison@gmail.com> wrote:

> On Fri, 2008-11-07 at 10:56 -0800, Darrick J. Wong wrote:
> > New driver to play with.  As Jean mentioned a couple of years ago,
> > this
> > chip is a beast with odd combinations of 8 fans, 4 temperatures, and 
> > 13 voltage sensors.  This driver has been tested on an IntelliStation
> > Z30.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> > ---
> > +#define MASK_AND_SHIFT(value, prefix)	\
> > +	(((value) & prefix##_MASK) >> prefix##_SHIFT)
> > +
> 
> I'm not sure, but doesn't this exist somewhere in the common kernel
> headers.

No, core kernel doesn't have a macro which requires that the caller
previously defined foo_MASK and foo_SHIFT.  Only drivers are allowed to
get away with such fugliness ;)

> > +#define ROUND_DIV(x, divisor)  (((x) + ((divisor) / 2)) / (divisor))
> 
> DIV_ROUND_UP ?

That's different.  This one should be called ROUND_CLOSEST or something
like that.


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: djwong@us.ibm.com, khali@linux-fr.org,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 1/5] adt7462: New hwmon driver
Date: Fri, 7 Nov 2008 11:27:31 -0800	[thread overview]
Message-ID: <20081107112731.cec03a04.akpm@linux-foundation.org> (raw)
In-Reply-To: <1226084691.11596.42.camel@brick>

On Fri, 07 Nov 2008 11:04:51 -0800
Harvey Harrison <harvey.harrison@gmail.com> wrote:

> On Fri, 2008-11-07 at 10:56 -0800, Darrick J. Wong wrote:
> > New driver to play with.  As Jean mentioned a couple of years ago,
> > this
> > chip is a beast with odd combinations of 8 fans, 4 temperatures, and 
> > 13 voltage sensors.  This driver has been tested on an IntelliStation
> > Z30.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> > ---
> > +#define MASK_AND_SHIFT(value, prefix)	\
> > +	(((value) & prefix##_MASK) >> prefix##_SHIFT)
> > +
> 
> I'm not sure, but doesn't this exist somewhere in the common kernel
> headers.

No, core kernel doesn't have a macro which requires that the caller
previously defined foo_MASK and foo_SHIFT.  Only drivers are allowed to
get away with such fugliness ;)

> > +#define ROUND_DIV(x, divisor)  (((x) + ((divisor) / 2)) / (divisor))
> 
> DIV_ROUND_UP ?

That's different.  This one should be called ROUND_CLOSEST or something
like that.


  reply	other threads:[~2008-11-07 19:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 18:56 [lm-sensors] [PATCH 0/5] Various hwmon patches Darrick J. Wong
2008-11-07 18:56 ` Darrick J. Wong
2008-11-07 18:56 ` [lm-sensors] [PATCH 1/5] adt7462: New hwmon driver Darrick J. Wong
2008-11-07 18:56   ` Darrick J. Wong
2008-11-07 19:04   ` [lm-sensors] " Harvey Harrison
2008-11-07 19:04     ` Harvey Harrison
2008-11-07 19:27     ` Andrew Morton [this message]
2008-11-07 19:27       ` Andrew Morton
2008-11-07 19:34       ` [lm-sensors] " Darrick J. Wong
2008-11-07 19:34         ` Darrick J. Wong
2008-11-07 19:38     ` [lm-sensors] " Darrick J. Wong
2008-11-07 19:38       ` Darrick J. Wong
2008-11-07 19:18   ` [lm-sensors] " Andrew Morton
2008-11-07 19:18     ` Andrew Morton
2008-11-07 18:56 ` [lm-sensors] [PATCH 2/5] i5k_amb: Load automatically on all Darrick J. Wong
2008-11-07 18:56   ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Darrick J. Wong
2008-11-08 11:09   ` [lm-sensors] [PATCH 2/5] i5k_amb: Load automatically on all Jean Delvare
2008-11-08 11:09     ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Jean Delvare
2008-11-11  6:26     ` [lm-sensors] [PATCH 2/5] i5k_amb: Load automatically on all Greg KH
2008-11-11  6:26       ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Greg KH
2008-11-07 18:56 ` [lm-sensors] [PATCH 3/5] adt7470: Check input range when sysfs Darrick J. Wong
2008-11-07 18:56   ` [PATCH 3/5] adt7470: Check input range when sysfs files are written Darrick J. Wong
2008-11-11  0:22   ` [lm-sensors] [PATCH 3/5] adt7470: Check input range when sysfs Andrew Morton
2008-11-11  0:22     ` [PATCH 3/5] adt7470: Check input range when sysfs files are written Andrew Morton
2008-11-11  0:49     ` [lm-sensors] [PATCH 3/5] adt7470: Check input range when sysfs Darrick J. Wong
2008-11-11  0:49       ` [PATCH 3/5] adt7470: Check input range when sysfs files are written Darrick J. Wong
2008-11-07 18:56 ` [lm-sensors] [PATCH 4/5] adt7473: Check inputs from sysfs writes Darrick J. Wong
2008-11-07 18:56   ` Darrick J. Wong
2008-11-07 19:20   ` [lm-sensors] " Andrew Morton
2008-11-07 19:20     ` Andrew Morton
2008-11-07 20:35     ` [lm-sensors] " Jean Delvare
2008-11-07 20:35       ` Jean Delvare
2008-11-07 20:49     ` [lm-sensors] " Joe Perches
2008-11-07 20:49       ` Joe Perches
2008-11-07 21:00       ` [lm-sensors] " Jean Delvare
2008-11-07 21:00         ` Jean Delvare
2008-11-07 21:02         ` [lm-sensors] " Randy Dunlap
2008-11-07 21:02           ` Randy Dunlap
2008-11-07 18:56 ` [lm-sensors] [PATCH 5/5] lm85: Support adt7468 chips Darrick J. Wong
2008-11-07 18:56   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081107112731.cec03a04.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=djwong@us.ibm.com \
    --cc=harvey.harrison@gmail.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.