All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: khali@linux-fr.org, linux-kernel@vger.kernel.org,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 3/5] adt7470: Check input range when sysfs
Date: Tue, 11 Nov 2008 00:49:28 +0000	[thread overview]
Message-ID: <20081111004927.GO8668@plum> (raw)
In-Reply-To: <20081110162214.b8202b60.akpm@linux-foundation.org>

On Mon, Nov 10, 2008 at 04:22:14PM -0800, Andrew Morton wrote:

> When writing changelogs, please explain _why_ a change was made, as
> well as what the change does.

Sorry about that.  Here's a revision:

Implement correct range checking for adt7470 to prevent userland from
writing impossible values into the chip, and cap out-of-range values per
standard hwmon conventions.

Implement correct rounding of input values per standard hwmon
conventions.

Is that better?

(Same goes for the adt7473 patch.)

> Looking at it, I guess it does change the userspace interface in minor
> ways, so we should merge it into 2.6.28.  Ditto
> adt7473-check-inputs-from-sysfs-writes.patch.  Agree?

Yes.

--D

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: khali@linux-fr.org, linux-kernel@vger.kernel.org,
	lm-sensors@lm-sensors.org
Subject: Re: [PATCH 3/5] adt7470: Check input range when sysfs files are written
Date: Mon, 10 Nov 2008 16:49:28 -0800	[thread overview]
Message-ID: <20081111004927.GO8668@plum> (raw)
In-Reply-To: <20081110162214.b8202b60.akpm@linux-foundation.org>

On Mon, Nov 10, 2008 at 04:22:14PM -0800, Andrew Morton wrote:

> When writing changelogs, please explain _why_ a change was made, as
> well as what the change does.

Sorry about that.  Here's a revision:

Implement correct range checking for adt7470 to prevent userland from
writing impossible values into the chip, and cap out-of-range values per
standard hwmon conventions.

Implement correct rounding of input values per standard hwmon
conventions.

Is that better?

(Same goes for the adt7473 patch.)

> Looking at it, I guess it does change the userspace interface in minor
> ways, so we should merge it into 2.6.28.  Ditto
> adt7473-check-inputs-from-sysfs-writes.patch.  Agree?

Yes.

--D

  reply	other threads:[~2008-11-11  0:49 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 18:56 [lm-sensors] [PATCH 0/5] Various hwmon patches Darrick J. Wong
2008-11-07 18:56 ` Darrick J. Wong
2008-11-07 18:56 ` [lm-sensors] [PATCH 1/5] adt7462: New hwmon driver Darrick J. Wong
2008-11-07 18:56   ` Darrick J. Wong
2008-11-07 19:04   ` [lm-sensors] " Harvey Harrison
2008-11-07 19:04     ` Harvey Harrison
2008-11-07 19:27     ` [lm-sensors] " Andrew Morton
2008-11-07 19:27       ` Andrew Morton
2008-11-07 19:34       ` [lm-sensors] " Darrick J. Wong
2008-11-07 19:34         ` Darrick J. Wong
2008-11-07 19:38     ` [lm-sensors] " Darrick J. Wong
2008-11-07 19:38       ` Darrick J. Wong
2008-11-07 19:18   ` [lm-sensors] " Andrew Morton
2008-11-07 19:18     ` Andrew Morton
2008-11-07 18:56 ` [lm-sensors] [PATCH 2/5] i5k_amb: Load automatically on all Darrick J. Wong
2008-11-07 18:56   ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Darrick J. Wong
2008-11-08 11:09   ` [lm-sensors] [PATCH 2/5] i5k_amb: Load automatically on all Jean Delvare
2008-11-08 11:09     ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Jean Delvare
2008-11-11  6:26     ` [lm-sensors] [PATCH 2/5] i5k_amb: Load automatically on all Greg KH
2008-11-11  6:26       ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Greg KH
2008-11-07 18:56 ` [lm-sensors] [PATCH 3/5] adt7470: Check input range when sysfs Darrick J. Wong
2008-11-07 18:56   ` [PATCH 3/5] adt7470: Check input range when sysfs files are written Darrick J. Wong
2008-11-11  0:22   ` [lm-sensors] [PATCH 3/5] adt7470: Check input range when sysfs Andrew Morton
2008-11-11  0:22     ` [PATCH 3/5] adt7470: Check input range when sysfs files are written Andrew Morton
2008-11-11  0:49     ` Darrick J. Wong [this message]
2008-11-11  0:49       ` Darrick J. Wong
2008-11-07 18:56 ` [lm-sensors] [PATCH 4/5] adt7473: Check inputs from sysfs writes Darrick J. Wong
2008-11-07 18:56   ` Darrick J. Wong
2008-11-07 19:20   ` [lm-sensors] " Andrew Morton
2008-11-07 19:20     ` Andrew Morton
2008-11-07 20:35     ` [lm-sensors] " Jean Delvare
2008-11-07 20:35       ` Jean Delvare
2008-11-07 20:49     ` [lm-sensors] " Joe Perches
2008-11-07 20:49       ` Joe Perches
2008-11-07 21:00       ` [lm-sensors] " Jean Delvare
2008-11-07 21:00         ` Jean Delvare
2008-11-07 21:02         ` [lm-sensors] " Randy Dunlap
2008-11-07 21:02           ` Randy Dunlap
2008-11-07 18:56 ` [lm-sensors] [PATCH 5/5] lm85: Support adt7468 chips Darrick J. Wong
2008-11-07 18:56   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081111004927.GO8668@plum \
    --to=djwong@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.