All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>,
	ath5k-devel@venema.h4ckr.net, linux-kernel@vger.kernel.org
Subject: Re: [ath5k-devel] Bugs on aspire one A150
Date: Thu, 13 Nov 2008 22:47:30 -0500	[thread overview]
Message-ID: <20081114034730.GA9482@hash.localnet> (raw)
In-Reply-To: <491B17B3.204@gmail.com>

On Wed, Nov 12, 2008 at 07:51:47PM +0200, Maxim Levitsky wrote:
> >>Why it doesn't accept new mac?, can this be fixed?
> 
> Any update on mac changer status?

As a first stab, can you try this patch?  This sets the address on
add_interface and clears it on remove_interface, instead of only doing
it at probe time.  I only compile-tested it.

diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index 5ef8cc4..6c56893 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -2765,6 +2765,7 @@ static int ath5k_add_interface(struct ieee80211_hw *hw,
 	/* Set to a reasonable value. Note that this will
 	 * be set to mac80211's value at ath5k_config(). */
 	sc->bintval = 1000;
+	ath5k_hw_set_lladdr(sc->ah, conf->mac_addr);
 
 	ret = 0;
 end:
@@ -2777,11 +2778,13 @@ ath5k_remove_interface(struct ieee80211_hw *hw,
 			struct ieee80211_if_init_conf *conf)
 {
 	struct ath5k_softc *sc = hw->priv;
+	u8 mac[ETH_ALEN] = {};
 
 	mutex_lock(&sc->lock);
 	if (sc->vif != conf->vif)
 		goto end;
 
+	ath5k_hw_set_lladdr(sc->ah, mac);
 	sc->vif = NULL;
 end:
 	mutex_unlock(&sc->lock);

-- 
Bob Copeland %% www.bobcopeland.com


  parent reply	other threads:[~2008-11-14  3:48 UTC|newest]

Thread overview: 184+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-08  3:26 Bugs on aspire one A150 Maxim Levitsky
2008-11-08  3:26 ` Maxim Levitsky
     [not found] ` <491506DB.1070000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-08 11:57   ` Alan Jenkins
2008-11-08 11:57     ` Alan Jenkins
2008-11-09  0:52     ` Maxim Levitsky
2008-11-09  0:52     ` Maxim Levitsky
2008-11-09  0:52       ` Maxim Levitsky
     [not found]       ` <49163435.20301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-09  8:54         ` [alsa-devel] " Takashi Iwai
2008-11-09  8:54           ` Takashi Iwai
2008-11-09 13:31           ` Andreas Mohr
2008-11-09 13:31             ` [alsa-devel] " Andreas Mohr
2008-11-09 15:13           ` Andreas Mohr
2008-11-09 15:13             ` [alsa-devel] " Andreas Mohr
     [not found]             ` <20081109151323.GA18705-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2008-11-09 18:58               ` Takashi Iwai
2008-11-09 18:58                 ` Takashi Iwai
2008-11-09 20:09                 ` Andreas Mohr
2008-11-09 20:09                   ` [alsa-devel] " Andreas Mohr
     [not found]                   ` <20081109200929.GA29333-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2008-11-12 11:08                     ` Takashi Iwai
2008-11-12 11:08                       ` Takashi Iwai
2008-11-12 17:07                       ` Maxim Levitsky
2008-11-12 17:07                         ` [alsa-devel] " Maxim Levitsky
     [not found]                         ` <491B0D38.1050207-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-12 18:05                           ` Andreas Mohr
2008-11-12 18:05                             ` Andreas Mohr
     [not found]                             ` <20081112180519.GA21919-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2008-11-14 18:05                               ` Maxim Levitsky
2008-11-14 18:05                                 ` Maxim Levitsky
     [not found]                                 ` <491DBDEA.9010104-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-22 19:00                                   ` Maxim Levitsky
2008-11-22 19:00                                     ` Maxim Levitsky
2008-11-22 19:43                                     ` Andreas Mohr
2008-11-22 19:43                                       ` [alsa-devel] " Andreas Mohr
     [not found]                                     ` <492856C2.8000707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-24 14:35                                       ` Takashi Iwai
2008-11-24 14:35                                         ` Takashi Iwai
2009-03-15  9:21                                         ` Andreas Mohr
2009-03-15  9:21                                           ` [alsa-devel] " Andreas Mohr
2009-03-16 12:03                                           ` Andreas Mohr
2009-03-16 12:03                                             ` [alsa-devel] " Andreas Mohr
     [not found]                                             ` <20090316120312.GA19299-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 12:09                                               ` Takashi Iwai
2009-03-16 12:09                                                 ` Takashi Iwai
2009-03-16 13:30                                                 ` Andreas Mohr
2009-03-16 13:30                                                   ` [alsa-devel] " Andreas Mohr
     [not found]                                                   ` <20090316133001.GA8437-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 14:18                                                     ` Takashi Iwai
2009-03-16 14:18                                                       ` Takashi Iwai
2009-03-16 14:31                                                       ` Andreas Mohr
2009-03-16 14:31                                                         ` [alsa-devel] " Andreas Mohr
2009-03-16 14:42                                                         ` Takashi Iwai
2009-03-16 14:42                                                           ` [alsa-devel] " Takashi Iwai
2009-03-16 14:50                                                           ` Andreas Mohr
2009-03-16 14:50                                                             ` [alsa-devel] " Andreas Mohr
     [not found]                                                             ` <20090316145036.GA26358-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 15:34                                                               ` Takashi Iwai
2009-03-16 15:34                                                                 ` Takashi Iwai
2009-03-16 16:02                                                                 ` Andreas Mohr
2009-03-16 16:02                                                                   ` [alsa-devel] " Andreas Mohr
2009-03-16 16:06                                                                   ` Takashi Iwai
2009-03-16 16:06                                                                     ` [alsa-devel] " Takashi Iwai
     [not found]                                                                     ` <s5hwsappi44.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-16 16:19                                                                       ` Takashi Iwai
2009-03-16 16:19                                                                         ` Takashi Iwai
2009-03-16 17:00                                                                         ` Andreas Mohr
2009-03-16 17:00                                                                           ` [alsa-devel] " Andreas Mohr
2009-03-16 17:15                                                                           ` Takashi Iwai
2009-03-16 17:15                                                                             ` [alsa-devel] " Takashi Iwai
     [not found]                                                                             ` <s5hljr5pex0.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-16 17:30                                                                               ` Andreas Mohr
2009-03-16 17:30                                                                                 ` Andreas Mohr
     [not found]                                                                                 ` <20090316173000.GA25647-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 17:34                                                                                   ` Takashi Iwai
2009-03-16 17:34                                                                                     ` Takashi Iwai
2009-03-16 18:06                                                                                     ` Andreas Mohr
2009-03-16 18:06                                                                                       ` [alsa-devel] " Andreas Mohr
2009-03-16 20:28                                                                                       ` Takashi Iwai
2009-03-16 20:28                                                                                         ` [alsa-devel] " Takashi Iwai
2009-03-16 21:22                                                                                         ` Andreas Mohr
2009-03-16 21:22                                                                                           ` [alsa-devel] " Andreas Mohr
     [not found]                                                                                           ` <20090316212227.GA29471-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-17  0:52                                                                                             ` Maxim Levitsky
2009-03-17  0:52                                                                                               ` Maxim Levitsky
2009-03-17  7:57                                                                                               ` Takashi Iwai
2009-03-17  7:57                                                                                                 ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                                 ` <s5heiwwzim7.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-17 11:30                                                                                                   ` Maxim Levitsky
2009-03-17 11:30                                                                                                     ` Maxim Levitsky
2009-03-17 12:52                                                                                                     ` Takashi Iwai
2009-03-17 12:52                                                                                                       ` [alsa-devel] " Takashi Iwai
2009-03-17  7:57                                                                                           ` Takashi Iwai
2009-03-17  7:57                                                                                             ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                             ` <s5hfxhczinh.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-17 10:05                                                                                               ` Andreas Mohr
2009-03-17 10:05                                                                                                 ` Andreas Mohr
2009-03-17 10:38                                                                                                 ` Andreas Mohr
2009-03-17 10:38                                                                                                   ` [alsa-devel] " Andreas Mohr
     [not found]                                                                                                   ` <20090317103845.GA26007-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-17 10:47                                                                                                     ` Andreas Mohr
2009-03-17 10:47                                                                                                       ` Andreas Mohr
2009-03-17 11:25                                                                                                       ` Takashi Iwai
2009-03-17 11:25                                                                                                         ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                                         ` <s5h3adcpf1i.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-17 16:18                                                                                                           ` Andreas Mohr
2009-03-17 16:18                                                                                                             ` Andreas Mohr
2009-03-17 20:32                                                                                                             ` Takashi Iwai
2009-03-17 20:32                                                                                                               ` [alsa-devel] " Takashi Iwai
2009-03-18  9:05                                                                                                               ` Andreas Mohr
2009-03-18  9:05                                                                                                                 ` [alsa-devel] " Andreas Mohr
2009-03-18  9:19                                                                                                                 ` Takashi Iwai
2009-03-18  9:19                                                                                                                   ` [alsa-devel] " Takashi Iwai
2009-03-20 18:56                                                                                                                   ` Andreas Mohr
2009-03-20 18:56                                                                                                                     ` [alsa-devel] " Andreas Mohr
2009-03-20 20:33                                                                                                                     ` Takashi Iwai
2009-03-20 20:33                                                                                                                       ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                                                       ` <s5hmybgnddc.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-22 12:55                                                                                                                         ` Andreas Mohr
2009-03-22 12:55                                                                                                                           ` Andreas Mohr
     [not found]                                                                                                                           ` <20090322125517.GA26498-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-23  6:51                                                                                                                             ` Takashi Iwai
2009-03-23  6:51                                                                                                                               ` Takashi Iwai
2008-11-12 17:20                       ` Maxim Levitsky
2008-11-12 17:20                         ` [alsa-devel] " Maxim Levitsky
     [not found]                       ` <s5hiqqtkxqr.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2008-11-12 18:53                         ` HDA-emu 0.0.1 (Re: [alsa-devel] Bugs on aspire one A150) Takashi Iwai
2008-11-12 18:53                           ` Takashi Iwai
2008-11-09 10:43         ` Bugs on aspire one A150 Alan Jenkins
2008-11-09 10:43           ` Alan Jenkins
2008-11-12 17:48           ` Maxim Levitsky
2008-11-12 17:48           ` Maxim Levitsky
2008-11-09 10:43       ` Alan Jenkins
     [not found]     ` <49157E97.60503-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2008-11-14 19:06       ` Maxim Levitsky
2008-11-14 19:06         ` Maxim Levitsky
     [not found]         ` <491DCC21.6060705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-14 19:59           ` Alan Jenkins
2008-11-14 19:59             ` Alan Jenkins
     [not found]             ` <61b223ba0811141159k179558d0i60cebf373baa9fb8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-15 12:52               ` Maxim Levitsky
2008-11-15 12:52                 ` Maxim Levitsky
2008-11-15 12:55                 ` Matthew Garrett
2008-11-14 19:06     ` Maxim Levitsky
2008-11-08 11:57 ` Alan Jenkins
2008-11-10 16:51 ` Bob Copeland
2008-11-10 16:51 ` Bob Copeland
2008-11-10 16:51   ` Bob Copeland
2008-11-10 21:33   ` Maxim Levitsky
2008-11-10 21:33   ` Maxim Levitsky
2008-11-10 21:33     ` Maxim Levitsky
     [not found]     ` <4918A8C5.3050607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-10 22:12       ` Nick Kossifidis
2008-11-10 22:12         ` [ath5k-devel] " Nick Kossifidis
2008-11-12 17:51         ` Maxim Levitsky
2008-11-13 14:58           ` Bob Copeland
2008-11-14  3:47           ` Bob Copeland [this message]
2008-11-14 18:57             ` Maxim Levitsky
2008-11-17 17:28               ` Bob Copeland
2008-11-17 18:55                 ` Maxim Levitsky
2008-12-01 15:33         ` Maxim Levitsky
2008-12-01 15:33           ` Maxim Levitsky
2008-12-01 15:33         ` Maxim Levitsky
2008-12-13 13:28         ` Maxim Levitsky
2008-12-13 13:28         ` Maxim Levitsky
2008-12-13 13:28           ` Maxim Levitsky
2008-12-13 14:08           ` Nick Kossifidis
2008-12-13 14:08           ` Nick Kossifidis
2008-12-13 14:08             ` Nick Kossifidis
2008-12-13 14:36             ` Maxim Levitsky
2008-12-13 14:36             ` Maxim Levitsky
2008-12-13 14:36               ` Maxim Levitsky
2008-12-13 14:38               ` Maxim Levitsky
2008-12-13 14:38               ` Maxim Levitsky
2008-12-13 14:38                 ` Maxim Levitsky
2008-12-13 14:24           ` Bob Copeland
2008-12-13 14:31             ` Maxim Levitsky
2008-12-30  4:26             ` Bob Copeland
2008-12-30 12:43               ` Maxim Levitsky
2008-12-31  9:18                 ` Andreas Mohr
2008-12-31 13:59                   ` Andreas Mohr
2008-12-31 14:06                     ` Bob Copeland
2008-12-31 14:03                   ` Bob Copeland
2008-12-31 16:51                     ` Maxim Levitsky
2009-01-01 13:41                       ` Andreas Mohr
2009-01-01 14:15                         ` Maxim Levitsky
2009-01-01 20:27                           ` Andreas Mohr
2009-01-01 15:09                         ` Bob Copeland
2008-11-10 22:12     ` Nick Kossifidis
2008-12-13 13:15 ` Maxim Levitsky
2008-12-13 13:15 ` Maxim Levitsky
2008-12-13 13:15   ` Maxim Levitsky
2008-12-13 13:35   ` Rafael J. Wysocki
2008-12-13 13:35   ` Rafael J. Wysocki
2008-12-13 13:35     ` Rafael J. Wysocki
2008-12-13 14:21     ` Maxim Levitsky
2008-12-13 14:21     ` Maxim Levitsky
2008-12-13 14:21       ` Maxim Levitsky
2008-12-13 17:42       ` Rafael J. Wysocki
2008-12-13 17:42         ` Rafael J. Wysocki
2008-12-13 18:04         ` Maxim Levitsky
2008-12-13 18:04           ` Maxim Levitsky
2008-12-13 18:04         ` Maxim Levitsky
2008-12-13 17:42       ` Rafael J. Wysocki
2008-12-14 22:29   ` J.A. Magallón
2008-12-14 22:57   ` J.A. Magallón
2008-12-14 23:18     ` Maxim Levitsky
2008-12-14 23:24       ` J.A. Magallón
2008-12-14 23:35   ` J.A. Magallón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081114034730.GA9482@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=ath5k-devel@venema.h4ckr.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=mickflemm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.