All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: ath5k-devel@venema.h4ckr.net, linux-kernel@vger.kernel.org
Subject: Re: [ath5k-devel] Bugs on aspire one A150
Date: Mon, 29 Dec 2008 23:26:30 -0500	[thread overview]
Message-ID: <20081230042630.GA13664@hash.localnet> (raw)
In-Reply-To: <20081213142444.GA19852@hash.localnet>

On Sat, Dec 13, 2008 at 09:24:45AM -0500, Bob Copeland wrote:
> > Indeed gpio #3 controls the led.
> > I patched ath5k to use it, and led works now fine.

Sorry for the delay, can you test this patch?

From: Bob Copeland <me@bobcopeland.com>
Date: Mon, 29 Dec 2008 23:14:24 -0500
Subject: [PATCH] ath5k: support LEDs on aspire one laptop

Add vendor ID for Foxconn and use it to set the ath5k LED gpio and
polarity for Acer branded laptops.

base.c:
Changes-licensed-under: 3-Clause-BSD

Reported-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
 drivers/net/wireless/ath5k/base.c |    7 +++++++
 include/linux/pci_ids.h           |    2 ++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index 40c0155..eb0675f 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -2595,6 +2595,13 @@ ath5k_init_leds(struct ath5k_softc *sc)
 		sc->led_pin = 1;
 		sc->led_on = 1;  /* active high */
 	}
+	/* Pin 3 on Foxconn chips used in Aspire One A150 (0x105b:e008) */
+	if (pdev->subsystem_vendor == PCI_VENDOR_ID_FOXCONN) {
+		__set_bit(ATH_STAT_LEDSOFT, sc->status);
+		sc->led_pin = 3;
+		sc->led_on = 1;  /* active high */
+	}
+
 	if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
 		goto out;
 
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 1800f1d..c1fb01c 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -834,6 +834,8 @@
 #define PCI_DEVICE_ID_PROMISE_20276	0x5275
 #define PCI_DEVICE_ID_PROMISE_20277	0x7275
 
+#define PCI_VENDOR_ID_FOXCONN		0x105b
+
 #define PCI_VENDOR_ID_UMC		0x1060
 #define PCI_DEVICE_ID_UMC_UM8673F	0x0101
 #define PCI_DEVICE_ID_UMC_UM8886BF	0x673a
-- 
1.6.0.4


-- 
Bob Copeland %% www.bobcopeland.com


  parent reply	other threads:[~2008-12-30  4:27 UTC|newest]

Thread overview: 184+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-08  3:26 Bugs on aspire one A150 Maxim Levitsky
2008-11-08  3:26 ` Maxim Levitsky
2008-11-08 11:57 ` Alan Jenkins
     [not found] ` <491506DB.1070000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-08 11:57   ` Alan Jenkins
2008-11-08 11:57     ` Alan Jenkins
2008-11-09  0:52     ` Maxim Levitsky
2008-11-09  0:52     ` Maxim Levitsky
2008-11-09  0:52       ` Maxim Levitsky
     [not found]       ` <49163435.20301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-09  8:54         ` [alsa-devel] " Takashi Iwai
2008-11-09  8:54           ` Takashi Iwai
2008-11-09 13:31           ` Andreas Mohr
2008-11-09 13:31             ` [alsa-devel] " Andreas Mohr
2008-11-09 15:13           ` Andreas Mohr
2008-11-09 15:13             ` [alsa-devel] " Andreas Mohr
     [not found]             ` <20081109151323.GA18705-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2008-11-09 18:58               ` Takashi Iwai
2008-11-09 18:58                 ` Takashi Iwai
2008-11-09 20:09                 ` Andreas Mohr
2008-11-09 20:09                   ` [alsa-devel] " Andreas Mohr
     [not found]                   ` <20081109200929.GA29333-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2008-11-12 11:08                     ` Takashi Iwai
2008-11-12 11:08                       ` Takashi Iwai
2008-11-12 17:07                       ` Maxim Levitsky
2008-11-12 17:07                         ` [alsa-devel] " Maxim Levitsky
     [not found]                         ` <491B0D38.1050207-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-12 18:05                           ` Andreas Mohr
2008-11-12 18:05                             ` Andreas Mohr
     [not found]                             ` <20081112180519.GA21919-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2008-11-14 18:05                               ` Maxim Levitsky
2008-11-14 18:05                                 ` Maxim Levitsky
     [not found]                                 ` <491DBDEA.9010104-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-22 19:00                                   ` Maxim Levitsky
2008-11-22 19:00                                     ` Maxim Levitsky
2008-11-22 19:43                                     ` Andreas Mohr
2008-11-22 19:43                                       ` [alsa-devel] " Andreas Mohr
     [not found]                                     ` <492856C2.8000707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-24 14:35                                       ` Takashi Iwai
2008-11-24 14:35                                         ` Takashi Iwai
2009-03-15  9:21                                         ` Andreas Mohr
2009-03-15  9:21                                           ` [alsa-devel] " Andreas Mohr
2009-03-16 12:03                                           ` Andreas Mohr
2009-03-16 12:03                                             ` [alsa-devel] " Andreas Mohr
     [not found]                                             ` <20090316120312.GA19299-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 12:09                                               ` Takashi Iwai
2009-03-16 12:09                                                 ` Takashi Iwai
2009-03-16 13:30                                                 ` Andreas Mohr
2009-03-16 13:30                                                   ` [alsa-devel] " Andreas Mohr
     [not found]                                                   ` <20090316133001.GA8437-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 14:18                                                     ` Takashi Iwai
2009-03-16 14:18                                                       ` Takashi Iwai
2009-03-16 14:31                                                       ` Andreas Mohr
2009-03-16 14:31                                                         ` [alsa-devel] " Andreas Mohr
2009-03-16 14:42                                                         ` Takashi Iwai
2009-03-16 14:42                                                           ` [alsa-devel] " Takashi Iwai
2009-03-16 14:50                                                           ` Andreas Mohr
2009-03-16 14:50                                                             ` [alsa-devel] " Andreas Mohr
     [not found]                                                             ` <20090316145036.GA26358-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 15:34                                                               ` Takashi Iwai
2009-03-16 15:34                                                                 ` Takashi Iwai
2009-03-16 16:02                                                                 ` Andreas Mohr
2009-03-16 16:02                                                                   ` [alsa-devel] " Andreas Mohr
2009-03-16 16:06                                                                   ` Takashi Iwai
2009-03-16 16:06                                                                     ` [alsa-devel] " Takashi Iwai
     [not found]                                                                     ` <s5hwsappi44.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-16 16:19                                                                       ` Takashi Iwai
2009-03-16 16:19                                                                         ` Takashi Iwai
2009-03-16 17:00                                                                         ` Andreas Mohr
2009-03-16 17:00                                                                           ` [alsa-devel] " Andreas Mohr
2009-03-16 17:15                                                                           ` Takashi Iwai
2009-03-16 17:15                                                                             ` [alsa-devel] " Takashi Iwai
     [not found]                                                                             ` <s5hljr5pex0.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-16 17:30                                                                               ` Andreas Mohr
2009-03-16 17:30                                                                                 ` Andreas Mohr
     [not found]                                                                                 ` <20090316173000.GA25647-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-16 17:34                                                                                   ` Takashi Iwai
2009-03-16 17:34                                                                                     ` Takashi Iwai
2009-03-16 18:06                                                                                     ` Andreas Mohr
2009-03-16 18:06                                                                                       ` [alsa-devel] " Andreas Mohr
2009-03-16 20:28                                                                                       ` Takashi Iwai
2009-03-16 20:28                                                                                         ` [alsa-devel] " Takashi Iwai
2009-03-16 21:22                                                                                         ` Andreas Mohr
2009-03-16 21:22                                                                                           ` [alsa-devel] " Andreas Mohr
     [not found]                                                                                           ` <20090316212227.GA29471-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-17  0:52                                                                                             ` Maxim Levitsky
2009-03-17  0:52                                                                                               ` Maxim Levitsky
2009-03-17  7:57                                                                                               ` Takashi Iwai
2009-03-17  7:57                                                                                                 ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                                 ` <s5heiwwzim7.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-17 11:30                                                                                                   ` Maxim Levitsky
2009-03-17 11:30                                                                                                     ` Maxim Levitsky
2009-03-17 12:52                                                                                                     ` Takashi Iwai
2009-03-17 12:52                                                                                                       ` [alsa-devel] " Takashi Iwai
2009-03-17  7:57                                                                                           ` Takashi Iwai
2009-03-17  7:57                                                                                             ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                             ` <s5hfxhczinh.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-17 10:05                                                                                               ` Andreas Mohr
2009-03-17 10:05                                                                                                 ` Andreas Mohr
2009-03-17 10:38                                                                                                 ` Andreas Mohr
2009-03-17 10:38                                                                                                   ` [alsa-devel] " Andreas Mohr
     [not found]                                                                                                   ` <20090317103845.GA26007-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-17 10:47                                                                                                     ` Andreas Mohr
2009-03-17 10:47                                                                                                       ` Andreas Mohr
2009-03-17 11:25                                                                                                       ` Takashi Iwai
2009-03-17 11:25                                                                                                         ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                                         ` <s5h3adcpf1i.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-17 16:18                                                                                                           ` Andreas Mohr
2009-03-17 16:18                                                                                                             ` Andreas Mohr
2009-03-17 20:32                                                                                                             ` Takashi Iwai
2009-03-17 20:32                                                                                                               ` [alsa-devel] " Takashi Iwai
2009-03-18  9:05                                                                                                               ` Andreas Mohr
2009-03-18  9:05                                                                                                                 ` [alsa-devel] " Andreas Mohr
2009-03-18  9:19                                                                                                                 ` Takashi Iwai
2009-03-18  9:19                                                                                                                   ` [alsa-devel] " Takashi Iwai
2009-03-20 18:56                                                                                                                   ` Andreas Mohr
2009-03-20 18:56                                                                                                                     ` [alsa-devel] " Andreas Mohr
2009-03-20 20:33                                                                                                                     ` Takashi Iwai
2009-03-20 20:33                                                                                                                       ` [alsa-devel] " Takashi Iwai
     [not found]                                                                                                                       ` <s5hmybgnddc.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2009-03-22 12:55                                                                                                                         ` Andreas Mohr
2009-03-22 12:55                                                                                                                           ` Andreas Mohr
     [not found]                                                                                                                           ` <20090322125517.GA26498-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2009-03-23  6:51                                                                                                                             ` Takashi Iwai
2009-03-23  6:51                                                                                                                               ` Takashi Iwai
2008-11-12 17:20                       ` Maxim Levitsky
2008-11-12 17:20                         ` [alsa-devel] " Maxim Levitsky
     [not found]                       ` <s5hiqqtkxqr.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2008-11-12 18:53                         ` HDA-emu 0.0.1 (Re: [alsa-devel] Bugs on aspire one A150) Takashi Iwai
2008-11-12 18:53                           ` Takashi Iwai
2008-11-09 10:43         ` Bugs on aspire one A150 Alan Jenkins
2008-11-09 10:43           ` Alan Jenkins
2008-11-12 17:48           ` Maxim Levitsky
2008-11-12 17:48           ` Maxim Levitsky
2008-11-09 10:43       ` Alan Jenkins
2008-11-14 19:06     ` Maxim Levitsky
     [not found]     ` <49157E97.60503-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2008-11-14 19:06       ` Maxim Levitsky
2008-11-14 19:06         ` Maxim Levitsky
     [not found]         ` <491DCC21.6060705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-14 19:59           ` Alan Jenkins
2008-11-14 19:59             ` Alan Jenkins
     [not found]             ` <61b223ba0811141159k179558d0i60cebf373baa9fb8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-15 12:52               ` Maxim Levitsky
2008-11-15 12:52                 ` Maxim Levitsky
2008-11-15 12:55                 ` Matthew Garrett
2008-11-10 16:51 ` Bob Copeland
2008-11-10 16:51 ` Bob Copeland
2008-11-10 16:51   ` Bob Copeland
2008-11-10 21:33   ` Maxim Levitsky
2008-11-10 21:33   ` Maxim Levitsky
2008-11-10 21:33     ` Maxim Levitsky
     [not found]     ` <4918A8C5.3050607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-10 22:12       ` Nick Kossifidis
2008-11-10 22:12         ` [ath5k-devel] " Nick Kossifidis
2008-11-12 17:51         ` Maxim Levitsky
2008-11-13 14:58           ` Bob Copeland
2008-11-14  3:47           ` Bob Copeland
2008-11-14 18:57             ` Maxim Levitsky
2008-11-17 17:28               ` Bob Copeland
2008-11-17 18:55                 ` Maxim Levitsky
2008-12-01 15:33         ` Maxim Levitsky
2008-12-01 15:33         ` Maxim Levitsky
2008-12-01 15:33           ` Maxim Levitsky
2008-12-13 13:28         ` Maxim Levitsky
2008-12-13 13:28         ` Maxim Levitsky
2008-12-13 13:28           ` Maxim Levitsky
2008-12-13 14:08           ` Nick Kossifidis
2008-12-13 14:08             ` Nick Kossifidis
2008-12-13 14:36             ` Maxim Levitsky
2008-12-13 14:36             ` Maxim Levitsky
2008-12-13 14:36               ` Maxim Levitsky
2008-12-13 14:38               ` Maxim Levitsky
2008-12-13 14:38               ` Maxim Levitsky
2008-12-13 14:38                 ` Maxim Levitsky
2008-12-13 14:08           ` Nick Kossifidis
2008-12-13 14:24           ` Bob Copeland
2008-12-13 14:31             ` Maxim Levitsky
2008-12-30  4:26             ` Bob Copeland [this message]
2008-12-30 12:43               ` Maxim Levitsky
2008-12-31  9:18                 ` Andreas Mohr
2008-12-31 13:59                   ` Andreas Mohr
2008-12-31 14:06                     ` Bob Copeland
2008-12-31 14:03                   ` Bob Copeland
2008-12-31 16:51                     ` Maxim Levitsky
2009-01-01 13:41                       ` Andreas Mohr
2009-01-01 14:15                         ` Maxim Levitsky
2009-01-01 20:27                           ` Andreas Mohr
2009-01-01 15:09                         ` Bob Copeland
2008-11-10 22:12     ` Nick Kossifidis
2008-12-13 13:15 ` Maxim Levitsky
2008-12-13 13:15 ` Maxim Levitsky
2008-12-13 13:15   ` Maxim Levitsky
2008-12-13 13:35   ` Rafael J. Wysocki
2008-12-13 13:35     ` Rafael J. Wysocki
2008-12-13 14:21     ` Maxim Levitsky
2008-12-13 14:21       ` Maxim Levitsky
2008-12-13 17:42       ` Rafael J. Wysocki
2008-12-13 17:42         ` Rafael J. Wysocki
2008-12-13 18:04         ` Maxim Levitsky
2008-12-13 18:04         ` Maxim Levitsky
2008-12-13 18:04           ` Maxim Levitsky
2008-12-13 17:42       ` Rafael J. Wysocki
2008-12-13 14:21     ` Maxim Levitsky
2008-12-13 13:35   ` Rafael J. Wysocki
2008-12-14 22:29   ` J.A. Magallón
2008-12-14 22:57   ` J.A. Magallón
2008-12-14 23:18     ` Maxim Levitsky
2008-12-14 23:24       ` J.A. Magallón
2008-12-14 23:35   ` J.A. Magallón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081230042630.GA13664@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=ath5k-devel@venema.h4ckr.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.