From: Magnus Damm <magnus.damm@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Magnus Damm <magnus.damm@gmail.com>,
lethal@linux-sh.org, adaplas@gmail.com, linux-sh@vger.kernel.org
Subject: [PATCH 01/05] video: fix deferred io fsync()
Date: Fri, 19 Dec 2008 15:34:09 +0900 [thread overview]
Message-ID: <20081219063409.2703.3880.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20081219063359.2703.85817.sendpatchset@rx1.opensource.se>
From: Magnus Damm <damm@igel.co.jp>
If CONFIG_FB_DEFERRED_IO is set, but there are framebuffers
registered that does not make use of deferred io, then fsync()
on those framebuffers will result in a crash. Fix that.
This is needed for sh_mobile_lcdcfb since we always enable
deferred io at compile time but we may disable deferred io
for some types of hardware configurations.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/video/fb_defio.c | 4 ++++
1 file changed, 4 insertions(+)
--- 0001/drivers/video/fb_defio.c
+++ work/drivers/video/fb_defio.c 2008-12-17 15:27:44.000000000 +0900
@@ -60,6 +60,10 @@ int fb_deferred_io_fsync(struct file *fi
{
struct fb_info *info = file->private_data;
+ /* Skip if deferred io is complied-in but disabled on this fbdev */
+ if (!info->fbdefio)
+ return 0;
+
/* Kill off the delayed work */
cancel_rearming_delayed_work(&info->deferred_work);
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Magnus Damm <magnus.damm@gmail.com>,
lethal@linux-sh.org, adaplas@gmail.com, linux-sh@vger.kernel.org
Subject: [PATCH 01/05] video: fix deferred io fsync()
Date: Fri, 19 Dec 2008 06:34:09 +0000 [thread overview]
Message-ID: <20081219063409.2703.3880.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20081219063359.2703.85817.sendpatchset@rx1.opensource.se>
From: Magnus Damm <damm@igel.co.jp>
If CONFIG_FB_DEFERRED_IO is set, but there are framebuffers
registered that does not make use of deferred io, then fsync()
on those framebuffers will result in a crash. Fix that.
This is needed for sh_mobile_lcdcfb since we always enable
deferred io at compile time but we may disable deferred io
for some types of hardware configurations.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/video/fb_defio.c | 4 ++++
1 file changed, 4 insertions(+)
--- 0001/drivers/video/fb_defio.c
+++ work/drivers/video/fb_defio.c 2008-12-17 15:27:44.000000000 +0900
@@ -60,6 +60,10 @@ int fb_deferred_io_fsync(struct file *fi
{
struct fb_info *info = file->private_data;
+ /* Skip if deferred io is complied-in but disabled on this fbdev */
+ if (!info->fbdefio)
+ return 0;
+
/* Kill off the delayed work */
cancel_rearming_delayed_work(&info->deferred_work);
next prev parent reply other threads:[~2008-12-19 6:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 6:33 [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support Magnus Damm
2008-12-19 6:33 ` Magnus Damm
2008-12-19 6:34 ` Magnus Damm [this message]
2008-12-19 6:34 ` [PATCH 01/05] video: fix deferred io fsync() Magnus Damm
2008-12-24 5:05 ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24 5:05 ` Jaya Kumar
2008-12-19 6:34 ` [PATCH 02/05] video: deferred io cleanup Magnus Damm
2008-12-19 6:34 ` Magnus Damm
2008-12-24 5:05 ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24 5:05 ` Jaya Kumar
2008-12-19 6:34 ` [PATCH 03/05] video: deferred io with physically contiguous memory Magnus Damm
2008-12-19 6:34 ` Magnus Damm
2008-12-24 5:13 ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24 5:13 ` Jaya Kumar
2008-12-25 19:04 ` Jaya Kumar
2008-12-25 19:04 ` Jaya Kumar
2008-12-19 6:34 ` [PATCH 04/05] video: sh_mobile_lcdcfb deferred io support Magnus Damm
2008-12-19 6:34 ` Magnus Damm
2008-12-19 6:34 ` [PATCH 05/05] sh: enable deferred io LCDC on Migo-R Magnus Damm
2008-12-19 6:34 ` Magnus Damm
2008-12-21 6:53 ` [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support Paul Mundt
2008-12-21 6:53 ` Paul Mundt
2008-12-21 7:11 ` Jaya Kumar
2008-12-21 7:11 ` Jaya Kumar
2008-12-21 16:14 ` Paul Mundt
2008-12-21 16:14 ` Paul Mundt
2008-12-24 5:01 ` Jaya Kumar
2008-12-24 5:01 ` Jaya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219063409.2703.3880.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=adaplas@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.