All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Magnus Damm <magnus.damm@gmail.com>,
	lethal@linux-sh.org, adaplas@gmail.com, linux-sh@vger.kernel.org
Subject: [PATCH 03/05] video: deferred io with physically contiguous memory
Date: Fri, 19 Dec 2008 15:34:32 +0900	[thread overview]
Message-ID: <20081219063432.2703.91443.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20081219063359.2703.85817.sendpatchset@rx1.opensource.se>

From: Magnus Damm <damm@igel.co.jp>

Extend the deferred io code from only supporting vmalloc()ed frame
buffer memory to support both vmalloc()ed and physically contiguous
frame buffer memory.

The sh_mobile_lcdcfb hardware does not support scatter gather so
we need physically contiguous memory to back our frame buffer.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
---

 drivers/video/fb_defio.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

--- 0003/drivers/video/fb_defio.c
+++ work/drivers/video/fb_defio.c	2008-12-19 14:29:45.000000000 +0900
@@ -24,6 +24,19 @@
 #include <linux/rmap.h>
 #include <linux/pagemap.h>
 
+struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
+{
+	void *screen_base = (void __force *) info->screen_base;
+	struct page *page;
+
+	if (is_vmalloc_addr(screen_base + offs))
+		page = vmalloc_to_page(screen_base + offs);
+	else
+		page = pfn_to_page((info->fix.smem_start + offs) >> PAGE_SHIFT);
+
+	return page;
+}
+
 /* this is to find and return the vmalloc-ed fb pages */
 static int fb_deferred_io_fault(struct vm_area_struct *vma,
 				struct vm_fault *vmf)
@@ -31,14 +44,12 @@ static int fb_deferred_io_fault(struct v
 	unsigned long offset;
 	struct page *page;
 	struct fb_info *info = vma->vm_private_data;
-	/* info->screen_base is virtual memory */
-	void *screen_base = (void __force *) info->screen_base;
 
 	offset = vmf->pgoff << PAGE_SHIFT;
 	if (offset >= info->fix.smem_len)
 		return VM_FAULT_SIGBUS;
 
-	page = vmalloc_to_page(screen_base + offset);
+	page = fb_deferred_io_page(info, offset);
 	if (!page)
 		return VM_FAULT_SIGBUS;
 
@@ -188,7 +199,6 @@ EXPORT_SYMBOL_GPL(fb_deferred_io_open);
 
 void fb_deferred_io_cleanup(struct fb_info *info)
 {
-	void *screen_base = (void __force *) info->screen_base;
 	struct fb_deferred_io *fbdefio = info->fbdefio;
 	struct page *page;
 	int i;
@@ -199,7 +209,7 @@ void fb_deferred_io_cleanup(struct fb_in
 
 	/* clear out the mapping that we setup */
 	for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) {
-		page = vmalloc_to_page(screen_base + i);
+		page = fb_deferred_io_page(info, i);
 		page->mapping = NULL;
 	}
 

WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Magnus Damm <magnus.damm@gmail.com>,
	lethal@linux-sh.org, adaplas@gmail.com, linux-sh@vger.kernel.org
Subject: [PATCH 03/05] video: deferred io with physically contiguous memory
Date: Fri, 19 Dec 2008 06:34:32 +0000	[thread overview]
Message-ID: <20081219063432.2703.91443.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20081219063359.2703.85817.sendpatchset@rx1.opensource.se>

From: Magnus Damm <damm@igel.co.jp>

Extend the deferred io code from only supporting vmalloc()ed frame
buffer memory to support both vmalloc()ed and physically contiguous
frame buffer memory.

The sh_mobile_lcdcfb hardware does not support scatter gather so
we need physically contiguous memory to back our frame buffer.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
---

 drivers/video/fb_defio.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

--- 0003/drivers/video/fb_defio.c
+++ work/drivers/video/fb_defio.c	2008-12-19 14:29:45.000000000 +0900
@@ -24,6 +24,19 @@
 #include <linux/rmap.h>
 #include <linux/pagemap.h>
 
+struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
+{
+	void *screen_base = (void __force *) info->screen_base;
+	struct page *page;
+
+	if (is_vmalloc_addr(screen_base + offs))
+		page = vmalloc_to_page(screen_base + offs);
+	else
+		page = pfn_to_page((info->fix.smem_start + offs) >> PAGE_SHIFT);
+
+	return page;
+}
+
 /* this is to find and return the vmalloc-ed fb pages */
 static int fb_deferred_io_fault(struct vm_area_struct *vma,
 				struct vm_fault *vmf)
@@ -31,14 +44,12 @@ static int fb_deferred_io_fault(struct v
 	unsigned long offset;
 	struct page *page;
 	struct fb_info *info = vma->vm_private_data;
-	/* info->screen_base is virtual memory */
-	void *screen_base = (void __force *) info->screen_base;
 
 	offset = vmf->pgoff << PAGE_SHIFT;
 	if (offset >= info->fix.smem_len)
 		return VM_FAULT_SIGBUS;
 
-	page = vmalloc_to_page(screen_base + offset);
+	page = fb_deferred_io_page(info, offset);
 	if (!page)
 		return VM_FAULT_SIGBUS;
 
@@ -188,7 +199,6 @@ EXPORT_SYMBOL_GPL(fb_deferred_io_open);
 
 void fb_deferred_io_cleanup(struct fb_info *info)
 {
-	void *screen_base = (void __force *) info->screen_base;
 	struct fb_deferred_io *fbdefio = info->fbdefio;
 	struct page *page;
 	int i;
@@ -199,7 +209,7 @@ void fb_deferred_io_cleanup(struct fb_in
 
 	/* clear out the mapping that we setup */
 	for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) {
-		page = vmalloc_to_page(screen_base + i);
+		page = fb_deferred_io_page(info, i);
 		page->mapping = NULL;
 	}
 

  parent reply	other threads:[~2008-12-19  6:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-19  6:33 [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support Magnus Damm
2008-12-19  6:33 ` Magnus Damm
2008-12-19  6:34 ` [PATCH 01/05] video: fix deferred io fsync() Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-24  5:05   ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24  5:05     ` Jaya Kumar
2008-12-19  6:34 ` [PATCH 02/05] video: deferred io cleanup Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-24  5:05   ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24  5:05     ` Jaya Kumar
2008-12-19  6:34 ` Magnus Damm [this message]
2008-12-19  6:34   ` [PATCH 03/05] video: deferred io with physically contiguous memory Magnus Damm
2008-12-24  5:13   ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24  5:13     ` Jaya Kumar
2008-12-25 19:04     ` Jaya Kumar
2008-12-25 19:04       ` Jaya Kumar
2008-12-19  6:34 ` [PATCH 04/05] video: sh_mobile_lcdcfb deferred io support Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-19  6:34 ` [PATCH 05/05] sh: enable deferred io LCDC on Migo-R Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-21  6:53 ` [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support Paul Mundt
2008-12-21  6:53   ` Paul Mundt
2008-12-21  7:11   ` Jaya Kumar
2008-12-21  7:11     ` Jaya Kumar
2008-12-21 16:14     ` Paul Mundt
2008-12-21 16:14       ` Paul Mundt
2008-12-24  5:01       ` Jaya Kumar
2008-12-24  5:01         ` Jaya Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081219063432.2703.91443.sendpatchset@rx1.opensource.se \
    --to=magnus.damm@gmail.com \
    --cc=adaplas@gmail.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.