All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>,
	Jaya Kumar <jayakumar.lkml@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support
Date: Sun, 21 Dec 2008 15:53:58 +0900	[thread overview]
Message-ID: <20081221065358.GA12631@linux-sh.org> (raw)
In-Reply-To: <20081219063359.2703.85817.sendpatchset@rx1.opensource.se>

On Fri, Dec 19, 2008 at 03:33:59PM +0900, Magnus Damm wrote:
> video: deferred io fixes and sh_mobile_lcdcfb support
> 
> [PATCH 01/05] video: fix deferred io fsync()
> [PATCH 02/05] video: deferred io cleanup
> [PATCH 03/05] video: deferred io with physically contiguous memory
> [PATCH 04/05] video: sh_mobile_lcdcfb deferred io support 
> [PATCH 05/05] sh: enable deferred io LCDC on Migo-R
> 
> This patchset adds deferred io support to sh_mobile_lcdcfb.
> 
> The LCDC hardware block managed by the sh_mobile_lcdcfb driver supports
> RGB or SYS panel configurations. SYS panels come with an external display
> controller that is resposible for refreshing the actual LCD panel. RGB
> panels are controlled directly by the LCDC and they need to be refreshed
> by the LCDC hardware.
> 
> In the case of SYS panels we can save some power by configuring the LCDC
> hardware block in one-shot mode. In this one-shot mode panel refresh is
> managed by software. This works well together with deferred io since it
> allows us to stop clocks for most of the time and only enable clocks when
> we actually want to trigger an update. When there is no fbdev activity
> the clocks are kept stopped which allows us to deep sleep.
> 
> May I suggest merging the first 3 patches with other framebuffer changes,
> but handling patch 4 and 5 with other SuperH changes? That strategy
> should be fine since there are no compile time dependencies. To keep
> things running please apply patch number 5 when all other changes are in.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>

I have no particular issues with this series anyways. If Jaya is fine
with the first three, I will take the last two. Or I can just take the entire
series, as it's fairly insular and no one else is likely to care about it
presently. Jaya?

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>,
	Jaya Kumar <jayakumar.lkml@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support
Date: Sun, 21 Dec 2008 06:53:58 +0000	[thread overview]
Message-ID: <20081221065358.GA12631@linux-sh.org> (raw)
In-Reply-To: <20081219063359.2703.85817.sendpatchset@rx1.opensource.se>

On Fri, Dec 19, 2008 at 03:33:59PM +0900, Magnus Damm wrote:
> video: deferred io fixes and sh_mobile_lcdcfb support
> 
> [PATCH 01/05] video: fix deferred io fsync()
> [PATCH 02/05] video: deferred io cleanup
> [PATCH 03/05] video: deferred io with physically contiguous memory
> [PATCH 04/05] video: sh_mobile_lcdcfb deferred io support 
> [PATCH 05/05] sh: enable deferred io LCDC on Migo-R
> 
> This patchset adds deferred io support to sh_mobile_lcdcfb.
> 
> The LCDC hardware block managed by the sh_mobile_lcdcfb driver supports
> RGB or SYS panel configurations. SYS panels come with an external display
> controller that is resposible for refreshing the actual LCD panel. RGB
> panels are controlled directly by the LCDC and they need to be refreshed
> by the LCDC hardware.
> 
> In the case of SYS panels we can save some power by configuring the LCDC
> hardware block in one-shot mode. In this one-shot mode panel refresh is
> managed by software. This works well together with deferred io since it
> allows us to stop clocks for most of the time and only enable clocks when
> we actually want to trigger an update. When there is no fbdev activity
> the clocks are kept stopped which allows us to deep sleep.
> 
> May I suggest merging the first 3 patches with other framebuffer changes,
> but handling patch 4 and 5 with other SuperH changes? That strategy
> should be fine since there are no compile time dependencies. To keep
> things running please apply patch number 5 when all other changes are in.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>

I have no particular issues with this series anyways. If Jaya is fine
with the first three, I will take the last two. Or I can just take the entire
series, as it's fairly insular and no one else is likely to care about it
presently. Jaya?

  parent reply	other threads:[~2008-12-21  6:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-19  6:33 [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support Magnus Damm
2008-12-19  6:33 ` Magnus Damm
2008-12-19  6:34 ` [PATCH 01/05] video: fix deferred io fsync() Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-24  5:05   ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24  5:05     ` Jaya Kumar
2008-12-19  6:34 ` [PATCH 02/05] video: deferred io cleanup Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-24  5:05   ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24  5:05     ` Jaya Kumar
2008-12-19  6:34 ` [PATCH 03/05] video: deferred io with physically contiguous memory Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-24  5:13   ` [Linux-fbdev-devel] " Jaya Kumar
2008-12-24  5:13     ` Jaya Kumar
2008-12-25 19:04     ` Jaya Kumar
2008-12-25 19:04       ` Jaya Kumar
2008-12-19  6:34 ` [PATCH 04/05] video: sh_mobile_lcdcfb deferred io support Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-19  6:34 ` [PATCH 05/05] sh: enable deferred io LCDC on Migo-R Magnus Damm
2008-12-19  6:34   ` Magnus Damm
2008-12-21  6:53 ` Paul Mundt [this message]
2008-12-21  6:53   ` [PATCH 00/05] video: deferred io fixes and sh_mobile_lcdcfb support Paul Mundt
2008-12-21  7:11   ` Jaya Kumar
2008-12-21  7:11     ` Jaya Kumar
2008-12-21 16:14     ` Paul Mundt
2008-12-21 16:14       ` Paul Mundt
2008-12-24  5:01       ` Jaya Kumar
2008-12-24  5:01         ` Jaya Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081221065358.GA12631@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=adaplas@gmail.com \
    --cc=jayakumar.lkml@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.