From: Nick Piggin <npiggin@suse.de>
To: Peter Klotz <peter.klotz@aon.at>
Cc: linux-kernel@vger.kernel.org,
Roman Kononov <kernel@kononov.ftml.net>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable@kernel.org
Subject: Re: [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?)
Date: Tue, 6 Jan 2009 09:43:12 +0100 [thread overview]
Message-ID: <20090106084312.GC16738@wotan.suse.de> (raw)
In-Reply-To: <49631877.3090803@aon.at>
On Tue, Jan 06, 2009 at 09:38:15AM +0100, Peter Klotz wrote:
> >Index: linux-2.6/include/linux/radix-tree.h
> >===================================================================
> >--- linux-2.6.orig/include/linux/radix-tree.h
> >+++ linux-2.6/include/linux/radix-tree.h
> >@@ -136,7 +136,7 @@ do { \
> > */
> > static inline void *radix_tree_deref_slot(void **pslot)
> > {
> >- void *ret = *pslot;
> >+ void *ret = rcu_dereference(*pslot);
> > if (unlikely(radix_tree_is_indirect_ptr(ret)))
> > ret = RADIX_TREE_RETRY;
> > return ret;
> >
> >
>
> The patch above fixes my problem. I did two complete test runs that
> normally fail rather quickly.
OK, thanks for reporting and testing.
I think this patch is a candidate for -stable too.
Thanks,
Nick
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: Peter Klotz <peter.klotz@aon.at>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable@kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
Christoph Hellwig <hch@infradead.org>,
Roman Kononov <kernel@kononov.ftml.net>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?)
Date: Tue, 6 Jan 2009 09:43:12 +0100 [thread overview]
Message-ID: <20090106084312.GC16738@wotan.suse.de> (raw)
In-Reply-To: <49631877.3090803@aon.at>
On Tue, Jan 06, 2009 at 09:38:15AM +0100, Peter Klotz wrote:
> >Index: linux-2.6/include/linux/radix-tree.h
> >===================================================================
> >--- linux-2.6.orig/include/linux/radix-tree.h
> >+++ linux-2.6/include/linux/radix-tree.h
> >@@ -136,7 +136,7 @@ do { \
> > */
> > static inline void *radix_tree_deref_slot(void **pslot)
> > {
> >- void *ret = *pslot;
> >+ void *ret = rcu_dereference(*pslot);
> > if (unlikely(radix_tree_is_indirect_ptr(ret)))
> > ret = RADIX_TREE_RETRY;
> > return ret;
> >
> >
>
> The patch above fixes my problem. I did two complete test runs that
> normally fail rather quickly.
OK, thanks for reporting and testing.
I think this patch is a candidate for -stable too.
Thanks,
Nick
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: Peter Klotz <peter.klotz@aon.at>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable@kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
Christoph Hellwig <hch@infradead.org>,
Roman Kononov <kernel@kononov.ftml.net>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?)
Date: Tue, 6 Jan 2009 09:43:12 +0100 [thread overview]
Message-ID: <20090106084312.GC16738@wotan.suse.de> (raw)
In-Reply-To: <49631877.3090803@aon.at>
On Tue, Jan 06, 2009 at 09:38:15AM +0100, Peter Klotz wrote:
> >Index: linux-2.6/include/linux/radix-tree.h
> >===================================================================
> >--- linux-2.6.orig/include/linux/radix-tree.h
> >+++ linux-2.6/include/linux/radix-tree.h
> >@@ -136,7 +136,7 @@ do { \
> > */
> > static inline void *radix_tree_deref_slot(void **pslot)
> > {
> >- void *ret = *pslot;
> >+ void *ret = rcu_dereference(*pslot);
> > if (unlikely(radix_tree_is_indirect_ptr(ret)))
> > ret = RADIX_TREE_RETRY;
> > return ret;
> >
> >
>
> The patch above fixes my problem. I did two complete test runs that
> normally fail rather quickly.
OK, thanks for reporting and testing.
I think this patch is a candidate for -stable too.
Thanks,
Nick
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-06 8:43 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 6:59 BUG: soft lockup - is this XFS problem? Roman Kononov
2008-12-23 17:12 ` Christoph Hellwig
2008-12-23 17:12 ` Christoph Hellwig
2008-12-30 4:23 ` Nick Piggin
2008-12-30 4:23 ` Nick Piggin
2009-01-03 21:44 ` Christoph Hellwig
2009-01-03 21:44 ` Christoph Hellwig
2009-01-05 1:48 ` Nick Piggin
2009-01-05 1:48 ` Nick Piggin
2009-01-05 4:19 ` Nick Piggin
2009-01-05 4:19 ` Nick Piggin
2009-01-05 6:48 ` Nick Piggin
2009-01-05 6:48 ` Nick Piggin
2009-01-05 14:25 ` Roman Kononov
2009-01-05 14:25 ` Roman Kononov
2009-01-05 16:21 ` Peter Klotz
2009-01-05 16:21 ` Peter Klotz
2009-01-05 16:41 ` [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?) Nick Piggin
2009-01-05 16:41 ` Nick Piggin
2009-01-05 16:41 ` Nick Piggin
2009-01-05 17:30 ` Linus Torvalds
2009-01-05 17:30 ` Linus Torvalds
2009-01-05 17:30 ` Linus Torvalds
2009-01-05 18:00 ` Nick Piggin
2009-01-05 18:00 ` Nick Piggin
2009-01-05 18:00 ` Nick Piggin
2009-01-05 18:44 ` Linus Torvalds
2009-01-05 18:44 ` Linus Torvalds
2009-01-05 18:44 ` Linus Torvalds
2009-01-05 19:39 ` Linus Torvalds
2009-01-05 19:39 ` Linus Torvalds
2009-01-05 19:39 ` Linus Torvalds
2009-01-06 17:17 ` Paul E. McKenney
2009-01-06 17:17 ` Paul E. McKenney
2009-01-06 17:17 ` Paul E. McKenney
2009-01-05 20:12 ` Paul E. McKenney
2009-01-05 20:12 ` Paul E. McKenney
2009-01-05 20:12 ` Paul E. McKenney
2009-01-05 20:39 ` Linus Torvalds
2009-01-05 20:39 ` Linus Torvalds
2009-01-05 20:39 ` Linus Torvalds
2009-01-05 21:57 ` Paul E. McKenney
2009-01-05 21:57 ` Paul E. McKenney
2009-01-05 21:57 ` Paul E. McKenney
2009-01-06 2:05 ` Nick Piggin
2009-01-06 2:05 ` Nick Piggin
2009-01-06 2:05 ` Nick Piggin
2009-01-06 2:23 ` Paul E. McKenney
2009-01-06 2:23 ` Paul E. McKenney
2009-01-06 2:23 ` Paul E. McKenney
2009-01-06 2:29 ` Linus Torvalds
2009-01-06 2:29 ` Linus Torvalds
2009-01-06 2:29 ` Linus Torvalds
2009-01-06 8:38 ` Peter Klotz
2009-01-06 8:38 ` Peter Klotz
2009-01-06 8:38 ` Peter Klotz
2009-01-06 8:43 ` Nick Piggin [this message]
2009-01-06 8:43 ` Nick Piggin
2009-01-06 8:43 ` Nick Piggin
2009-01-06 16:16 ` Roman Kononov
2009-01-06 16:16 ` Roman Kononov
2009-01-06 16:16 ` Roman Kononov
2009-01-05 21:04 ` [patch] mm: fix lockless pagecache reordering bug (was Peter Zijlstra
2009-01-05 21:04 ` Peter Zijlstra
2009-01-05 21:04 ` Peter Zijlstra
2009-01-05 21:58 ` Paul E. McKenney
2009-01-05 21:58 ` Paul E. McKenney
2009-01-05 21:58 ` Paul E. McKenney
2011-07-14 11:23 ` BUG: soft lockup - is this XFS problem? Guus Sliepen
2011-07-14 11:23 ` Guus Sliepen
2011-07-14 18:03 ` Peter Klotz
2011-07-14 18:03 ` Peter Klotz
2011-07-14 19:29 ` Guus Sliepen
2011-07-14 19:29 ` Guus Sliepen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106084312.GC16738@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=kernel@kononov.ftml.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peter.klotz@aon.at \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.