From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
Liu Dave <DaveLiu@freescale.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
sdhci-devel@list.drzeus.cx
Subject: [PATCH 11/13] sdhci: Add quirk for controllers that need IRQ re-init after reset
Date: Fri, 13 Feb 2009 17:47:38 +0300 [thread overview]
Message-ID: <20090213144738.GK23889@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090213144630.GA13436@oksana.dev.rtsoft.ru>
FSL eSDHC controllers losing signal/interrupt enable states after
reset, so we should re-enable them.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/mmc/host/sdhci.c | 7 +++++++
drivers/mmc/host/sdhci.h | 2 ++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index eff615d..b308dbf 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -189,6 +189,7 @@ static void sdhci_disable_card_detection(struct sdhci_host *host)
static void sdhci_reset(struct sdhci_host *host, u8 mask)
{
unsigned long timeout;
+ u32 ier = 0; /* shut up gcc */
if (host->quirks & SDHCI_QUIRK_NO_CARD_NO_RESET) {
if (!(sdhci_readl(host, SDHCI_PRESENT_STATE) &
@@ -196,6 +197,9 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask)
return;
}
+ if (host->quirks & SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET)
+ ier = sdhci_readl(host, SDHCI_INT_ENABLE);
+
sdhci_writeb(host, mask, SDHCI_SOFTWARE_RESET);
if (mask & SDHCI_RESET_ALL)
@@ -215,6 +219,9 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask)
timeout--;
mdelay(1);
}
+
+ if (host->quirks & SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET)
+ sdhci_clear_set_irqs(host, SDHCI_INT_ALL_MASK, ier);
}
static void sdhci_init(struct sdhci_host *host)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 44c820a..5c5a950 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -229,6 +229,8 @@ struct sdhci_host {
#define SDHCI_QUIRK_NONSTANDARD_CLOCK (1<<19)
/* Controller does not like fast PIO transfers */
#define SDHCI_QUIRK_PIO_NEEDS_DELAY (1<<20)
+/* Controller losing signal/interrupt enable states after reset */
+#define SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET (1<<21)
int irq; /* Device IRQ */
void __iomem * ioaddr; /* Mapped address */
--
1.5.6.5
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
Kumar Gala <galak@kernel.crashing.org>,
Liu Dave <DaveLiu@freescale.com>,
sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: [PATCH 11/13] sdhci: Add quirk for controllers that need IRQ re-init after reset
Date: Fri, 13 Feb 2009 17:47:38 +0300 [thread overview]
Message-ID: <20090213144738.GK23889@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090213144630.GA13436@oksana.dev.rtsoft.ru>
FSL eSDHC controllers losing signal/interrupt enable states after
reset, so we should re-enable them.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/mmc/host/sdhci.c | 7 +++++++
drivers/mmc/host/sdhci.h | 2 ++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index eff615d..b308dbf 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -189,6 +189,7 @@ static void sdhci_disable_card_detection(struct sdhci_host *host)
static void sdhci_reset(struct sdhci_host *host, u8 mask)
{
unsigned long timeout;
+ u32 ier = 0; /* shut up gcc */
if (host->quirks & SDHCI_QUIRK_NO_CARD_NO_RESET) {
if (!(sdhci_readl(host, SDHCI_PRESENT_STATE) &
@@ -196,6 +197,9 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask)
return;
}
+ if (host->quirks & SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET)
+ ier = sdhci_readl(host, SDHCI_INT_ENABLE);
+
sdhci_writeb(host, mask, SDHCI_SOFTWARE_RESET);
if (mask & SDHCI_RESET_ALL)
@@ -215,6 +219,9 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask)
timeout--;
mdelay(1);
}
+
+ if (host->quirks & SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET)
+ sdhci_clear_set_irqs(host, SDHCI_INT_ALL_MASK, ier);
}
static void sdhci_init(struct sdhci_host *host)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 44c820a..5c5a950 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -229,6 +229,8 @@ struct sdhci_host {
#define SDHCI_QUIRK_NONSTANDARD_CLOCK (1<<19)
/* Controller does not like fast PIO transfers */
#define SDHCI_QUIRK_PIO_NEEDS_DELAY (1<<20)
+/* Controller losing signal/interrupt enable states after reset */
+#define SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET (1<<21)
int irq; /* Device IRQ */
void __iomem * ioaddr; /* Mapped address */
--
1.5.6.5
next prev parent reply other threads:[~2009-02-13 14:47 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 14:46 [PATCH RFC 0/13] FSL eSDHC support Anton Vorontsov
2009-02-13 14:46 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 02/13] sdhci: Add support for bus-specific IO memory accessors Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 03/13] sdhci: Split card-detection IRQs management from sdhci_init() Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-21 15:58 ` Pierre Ossman
2009-02-21 15:58 ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 04/13] sdhci: Enable only relevant (DMA/PIO) interrupts during transfers Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 05/13] sdhci: Add support for card-detection polling Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-21 15:58 ` Pierre Ossman
2009-02-21 15:58 ` Pierre Ossman
2009-03-04 17:49 ` Anton Vorontsov
2009-03-04 17:49 ` Anton Vorontsov
2009-03-08 14:11 ` Pierre Ossman
2009-03-08 14:11 ` Pierre Ossman
2009-03-16 21:05 ` Anton Vorontsov
2009-03-16 21:05 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 06/13] sdhci: Add support for hosts reporting inverted write-protect state Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-21 15:58 ` Pierre Ossman
2009-02-21 15:58 ` Pierre Ossman
2009-03-04 17:48 ` Anton Vorontsov
2009-03-04 17:48 ` Anton Vorontsov
2009-03-08 14:17 ` Pierre Ossman
2009-03-08 14:17 ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 08/13] sdhci: Add get_{max,timeout}_clock callbacks Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 09/13] sdhci: Add set_clock callback and a quirk for nonstandard clocks Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 10/13] sdhci: Add quirk for controllers that need small delays for PIO Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov [this message]
2009-02-13 14:47 ` [PATCH 11/13] sdhci: Add quirk for controllers that need IRQ re-init after reset Anton Vorontsov
2009-02-13 15:47 ` Laurent Pinchart
2009-02-13 15:47 ` Laurent Pinchart
2009-02-13 17:30 ` Anton Vorontsov
2009-02-13 17:30 ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 12/13] sdhci: Add quirk for controllers with max. block size up to 4096 bytes Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-21 15:58 ` Pierre Ossman
2009-02-21 15:58 ` Pierre Ossman
2009-03-04 17:47 ` Anton Vorontsov
2009-03-04 17:47 ` Anton Vorontsov
2009-03-08 14:21 ` Pierre Ossman
2009-03-08 14:21 ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 13/13] mmc: Add OpenFirmware bindings for SDHCI driver Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov
2009-02-17 16:31 ` [PATCH RFC 0/13] FSL eSDHC support Ben Dooks
2009-02-17 16:31 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2009-02-20 17:32 [PATCH " Anton Vorontsov
2009-02-20 17:33 ` [PATCH 11/13] sdhci: Add quirk for controllers that need IRQ re-init after reset Anton Vorontsov
2009-02-20 17:33 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090213144738.GK23889@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=DaveLiu@freescale.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=drzeus-sdhci@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sdhci-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.