From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2/2] x86-64: seccomp: fix 32/64 syscall hole
Date: Sat, 28 Feb 2009 05:46:14 +0100 [thread overview]
Message-ID: <20090228044614.GA17082@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.00.0902271948570.3111@localhost.localdomain>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Fri, 27 Feb 2009, Linus Torvalds wrote:
> >
> > Ok, please explain this madness.
> >
> > The whole crazy IS_COMPAT_TASK dance seems to be too messy
> > for words. Why? What's going on?
>
> Ok, I can see what's going on. And it's disgusting.
>
> Just make everybody do that "is_compat_task()" thing. parisc
> already did, and you just made x86-64 do so too. The only
> remaining TIF_32BIT users are powerpc and sparc. So instead of
> having this insane crud, please just add the trivial
> definitions to the two remaining places, and we don't have to
> have this insane mess. Ok?
>
> It is clear that TIF_32BIT is _not_ a generic flag for
> 32/64-bit system calls, so let's stop pretending it is, and
> then having ugly special cases for when it's not.
Seconded.
Ingo
next prev parent reply other threads:[~2009-02-28 4:46 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 3:02 [PATCH 0/2] x86-64: 32/64 syscall arch holes Roland McGrath
2009-02-28 3:03 ` [PATCH 1/2] x86-64: syscall-audit: fix 32/64 syscall hole Roland McGrath
2009-02-28 3:04 ` [PATCH 2/2] x86-64: seccomp: " Roland McGrath
2009-02-28 3:36 ` Linus Torvalds
2009-02-28 3:52 ` Linus Torvalds
2009-02-28 4:46 ` Ingo Molnar [this message]
2009-02-28 7:25 ` Roland McGrath
2009-02-28 7:25 ` Roland McGrath
2009-02-28 7:25 ` Roland McGrath
2009-02-28 7:31 ` Ingo Molnar
2009-02-28 7:31 ` Ingo Molnar
2009-02-28 7:31 ` Ingo Molnar
2009-02-28 7:36 ` Roland McGrath
2009-02-28 7:36 ` Roland McGrath
2009-02-28 7:36 ` Roland McGrath
2009-02-28 17:23 ` Linus Torvalds
2009-02-28 17:23 ` Linus Torvalds
2009-02-28 17:23 ` Linus Torvalds
2009-02-28 17:46 ` [stable] " Greg KH
2009-02-28 17:46 ` Greg KH
2009-02-28 17:46 ` Greg KH
2009-02-28 17:54 ` Arjan van de Ven
2009-02-28 17:54 ` Arjan van de Ven
2009-02-28 17:54 ` Arjan van de Ven
2009-02-28 18:23 ` Greg KH
2009-02-28 18:23 ` Greg KH
2009-02-28 18:23 ` Greg KH
2009-02-28 20:27 ` Greg KH
2009-02-28 20:27 ` Greg KH
2009-02-28 21:09 ` Benjamin Herrenschmidt
2009-02-28 21:09 ` Benjamin Herrenschmidt
2009-02-28 21:09 ` Benjamin Herrenschmidt
2009-03-02 1:44 ` Roland McGrath
2009-03-02 1:44 ` Roland McGrath
2009-03-02 1:44 ` Roland McGrath
2009-05-06 18:42 ` Markus Gutschke
2009-05-06 18:42 ` Markus Gutschke
2009-05-06 18:46 ` Markus Gutschke (顧孟勤)
2009-05-06 18:46 `
2009-05-06 18:46 ` Markus Gutschke (顧孟勤)
2009-05-06 21:29 ` Ingo Molnar
2009-05-06 21:29 ` Ingo Molnar
2009-05-06 21:29 ` Ingo Molnar
2009-05-06 21:46 ` Markus Gutschke (顧孟勤)
2009-05-06 21:46 `
2009-05-06 21:46 ` Markus Gutschke (顧孟勤)
2009-05-06 21:54 ` Ingo Molnar
2009-05-06 21:54 ` Ingo Molnar
2009-05-06 21:54 ` Ingo Molnar
2009-05-06 22:08 ` Markus Gutschke (顧孟勤)
2009-05-06 22:08 `
2009-05-06 22:08 ` Markus Gutschke (顧孟勤)
2009-05-06 22:13 ` Ingo Molnar
2009-05-06 22:13 ` Ingo Molnar
2009-05-06 22:13 ` Ingo Molnar
2009-05-06 22:21 ` Markus Gutschke (顧孟勤)
2009-05-06 22:21 `
2009-05-06 22:21 ` Markus Gutschke (顧孟勤)
2009-05-07 4:23 ` Nicholas Miell
2009-05-07 4:23 ` Nicholas Miell
2009-05-07 4:23 ` Nicholas Miell
2009-05-07 10:11 ` Ingo Molnar
2009-05-07 10:11 ` Ingo Molnar
2009-05-07 10:11 ` Ingo Molnar
2009-05-10 5:37 ` Pavel Machek
2009-05-10 5:37 ` Pavel Machek
2009-05-10 5:37 ` Pavel Machek
2009-05-08 19:18 ` Andi Kleen
2009-05-08 19:18 ` Andi Kleen
2009-05-08 19:18 ` Andi Kleen
2009-05-07 7:03 ` Roland McGrath
2009-05-07 7:03 ` Roland McGrath
2009-05-07 8:01 ` Markus Gutschke (顧孟勤)
2009-05-07 8:01 `
2009-05-07 8:01 ` Markus Gutschke (顧孟勤)
2009-05-07 7:30 ` Roland McGrath
2009-05-07 7:30 ` Roland McGrath
2009-05-07 7:30 ` Roland McGrath
2009-05-07 7:31 ` Roland McGrath
2009-05-07 7:31 ` Roland McGrath
2009-05-07 7:31 ` Roland McGrath
2009-05-07 7:31 ` Roland McGrath
2009-05-08 1:59 ` David Wagner
2009-05-10 5:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090228044614.GA17082@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.