All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: fengguang.wu@intel.com, fweisbec@gmail.com, rostedt@goodmis.org,
	a.p.zijlstra@chello.nl, lizf@cn.fujitsu.com,
	linux-kernel@vger.kernel.org, kosaki.motohiro@jp.fujitsu.com,
	andi@firstfloor.org, mpm@selenic.com, adobriyan@gmail.com,
	linux-mm@kvack.org
Subject: Re: [PATCH 4/8] proc: export more page flags in /proc/kpageflags
Date: Sat, 9 May 2009 20:58:57 -0700	[thread overview]
Message-ID: <20090509205857.acadb20a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090509104409.GB16138@elte.hu>

On Sat, 9 May 2009 12:44:09 +0200 Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > On Fri, 8 May 2009 13:47:42 +0200
> > Ingo Molnar <mingo@elte.hu> wrote:
> > 
> > > 
> > > * Wu Fengguang <fengguang.wu@intel.com> wrote:
> > > 
> > > > Export all page flags faithfully in /proc/kpageflags.
> > > 
> > > Ongoing objection and NAK against extended haphazard exporting of 
> > > kernel internals via an ad-hoc ABI via ad-hoc, privatized 
> > > instrumentation that only helps the MM code and nothing else.
> > 
> > You're a year too late.  The pagemap interface is useful.
> 
> My NAK is against the extension of this mistake.
> 
> So is your answer to my NAK in essence:
> 
>  " We merged crappy MM instrumentation a short year ago, too bad.
>    And because it was so crappy to be in /proc we are now also
>    treating it as a hard ABI, not as a debugfs interface - for that 
>    single app that is using it. Furthermore, we are now going to 
>    make the API and ABI even more crappy via patches queued up in 
>    -mm, and we are ignoring NAKs. We are also going to make it even 
>    harder to have sane, generic instrumentation in the upstream 
>    kernel. Deal with it, this is our code and we can mess it up the 
>    way we wish to, it's none of your business."
> 
> right?
> 

If that was my answer, that is what I would have typed.

But I in fact typed something quite different.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: fengguang.wu@intel.com, fweisbec@gmail.com, rostedt@goodmis.org,
	a.p.zijlstra@chello.nl, lizf@cn.fujitsu.com,
	linux-kernel@vger.kernel.org, kosaki.motohiro@jp.fujitsu.com,
	andi@firstfloor.org, mpm@selenic.com, adobriyan@gmail.com,
	linux-mm@kvack.org
Subject: Re: [PATCH 4/8] proc: export more page flags in /proc/kpageflags
Date: Sat, 9 May 2009 20:58:57 -0700	[thread overview]
Message-ID: <20090509205857.acadb20a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090509104409.GB16138@elte.hu>

On Sat, 9 May 2009 12:44:09 +0200 Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > On Fri, 8 May 2009 13:47:42 +0200
> > Ingo Molnar <mingo@elte.hu> wrote:
> > 
> > > 
> > > * Wu Fengguang <fengguang.wu@intel.com> wrote:
> > > 
> > > > Export all page flags faithfully in /proc/kpageflags.
> > > 
> > > Ongoing objection and NAK against extended haphazard exporting of 
> > > kernel internals via an ad-hoc ABI via ad-hoc, privatized 
> > > instrumentation that only helps the MM code and nothing else.
> > 
> > You're a year too late.  The pagemap interface is useful.
> 
> My NAK is against the extension of this mistake.
> 
> So is your answer to my NAK in essence:
> 
>  " We merged crappy MM instrumentation a short year ago, too bad.
>    And because it was so crappy to be in /proc we are now also
>    treating it as a hard ABI, not as a debugfs interface - for that 
>    single app that is using it. Furthermore, we are now going to 
>    make the API and ABI even more crappy via patches queued up in 
>    -mm, and we are ignoring NAKs. We are also going to make it even 
>    harder to have sane, generic instrumentation in the upstream 
>    kernel. Deal with it, this is our code and we can mess it up the 
>    way we wish to, it's none of your business."
> 
> right?
> 

If that was my answer, that is what I would have typed.

But I in fact typed something quite different.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-05-10  4:07 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08 10:53 [PATCH 0/8] export more page flags in /proc/kpageflags (take 6) Wu Fengguang
2009-05-08 10:53 ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 1/8] mm: introduce PageHuge() for testing huge/gigantic pages Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 11:40   ` Ingo Molnar
2009-05-08 11:40     ` Ingo Molnar
2009-05-08 12:21     ` Wu Fengguang
2009-05-08 12:21       ` Wu Fengguang
2009-05-13 17:05   ` Mel Gorman
2009-05-13 17:05     ` Mel Gorman
2009-05-17 13:09     ` Wu Fengguang
2009-05-17 13:09       ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 2/8] slob: use PG_slab for identifying SLOB pages Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 3/8] proc: kpagecount/kpageflags code cleanup Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 4/8] proc: export more page flags in /proc/kpageflags Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 11:47   ` Ingo Molnar
2009-05-08 11:47     ` Ingo Molnar
2009-05-08 12:44     ` Wu Fengguang
2009-05-08 12:44       ` Wu Fengguang
2009-05-09  5:59       ` Ingo Molnar
2009-05-09  5:59         ` Ingo Molnar
2009-05-09  7:56         ` Wu Fengguang
2009-05-09  7:56           ` Wu Fengguang
2009-05-09  6:27       ` [patch] tracing/mm: add page frame snapshot trace Ingo Molnar
2009-05-09  6:27         ` Ingo Molnar
2009-05-09  9:13         ` Wu Fengguang
2009-05-09  9:13           ` Wu Fengguang
2009-05-09  9:24           ` Ingo Molnar
2009-05-09  9:24             ` Ingo Molnar
2009-05-09  9:43             ` Wu Fengguang
2009-05-09  9:43               ` Wu Fengguang
2009-05-09 10:22               ` Ingo Molnar
2009-05-09 10:22                 ` Ingo Molnar
2009-05-09 10:45                 ` Wu Fengguang
2009-05-09 10:45                   ` Wu Fengguang
2009-05-09 10:01           ` Ingo Molnar
2009-05-09 10:01             ` Ingo Molnar
2009-05-09 10:27             ` Ingo Molnar
2009-05-09 10:27               ` Ingo Molnar
2009-05-09 10:57             ` Wu Fengguang
2009-05-09 10:57               ` Wu Fengguang
2009-05-09 11:05               ` Ingo Molnar
2009-05-09 11:05                 ` Ingo Molnar
2009-05-09 12:23                 ` Wu Fengguang
2009-05-09 12:23                   ` Wu Fengguang
2009-05-09 14:05                   ` Ingo Molnar
2009-05-09 14:05                     ` Ingo Molnar
2009-05-10  8:35                     ` Wu Fengguang
2009-05-10  8:35                       ` Wu Fengguang
2009-05-11 12:01                       ` Ingo Molnar
2009-05-11 12:01                         ` Ingo Molnar
2009-05-09 10:36           ` Ingo Molnar
2009-05-09 10:36             ` Ingo Molnar
2009-05-08 12:58     ` ftrace: concurrent accesses possible? Wu Fengguang
2009-05-08 12:58       ` Wu Fengguang
2009-05-08 13:17       ` Steven Rostedt
2009-05-08 13:17         ` Steven Rostedt
2009-05-08 13:43         ` Wu Fengguang
2009-05-08 13:43           ` Wu Fengguang
2009-05-08 20:24     ` [PATCH 4/8] proc: export more page flags in /proc/kpageflags Andrew Morton
2009-05-08 20:24       ` Andrew Morton
2009-05-09 10:44       ` Ingo Molnar
2009-05-09 10:44         ` Ingo Molnar
2009-05-10  3:58         ` Andrew Morton [this message]
2009-05-10  3:58           ` Andrew Morton
2009-05-10  5:26         ` Andrew Morton
2009-05-10  5:26           ` Andrew Morton
2009-05-11 11:45           ` Ingo Molnar
2009-05-11 11:45             ` Ingo Molnar
2009-05-11 18:31             ` Andrew Morton
2009-05-11 18:31               ` Andrew Morton
2009-05-11 22:08               ` Ingo Molnar
2009-05-11 22:08                 ` Ingo Molnar
2009-05-11 19:03             ` Andy Isaacson
2009-05-11 19:03               ` Andy Isaacson
2009-05-08 10:53 ` [PATCH 5/8] pagemap: document clarifications Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 6/8] pagemap: document 9 more exported page flags Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-09  8:13   ` KOSAKI Motohiro
2009-05-09  8:13     ` KOSAKI Motohiro
2009-05-09  8:18     ` Wu Fengguang
2009-05-09  8:18       ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 7/8] pagemap: add page-types tool Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 8/8] pagemap: export PG_hwpoison Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 11:49   ` Ingo Molnar
2009-05-08 11:49     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090509205857.acadb20a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adobriyan@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.