All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: fengguang.wu@intel.com, fweisbec@gmail.com, rostedt@goodmis.org,
	a.p.zijlstra@chello.nl, lizf@cn.fujitsu.com,
	linux-kernel@vger.kernel.org, kosaki.motohiro@jp.fujitsu.com,
	andi@firstfloor.org, mpm@selenic.com, adobriyan@gmail.com,
	linux-mm@kvack.org
Subject: Re: [PATCH 4/8] proc: export more page flags in /proc/kpageflags
Date: Tue, 12 May 2009 00:08:34 +0200	[thread overview]
Message-ID: <20090511220834.GA26614@elte.hu> (raw)
In-Reply-To: <20090511113157.b2c56e70.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 11 May 2009 13:45:54 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
> 
> > > Yes, we could place pagemap's two auxiliary files into debugfs but 
> > > it would be rather stupid to split the feature's control files 
> > > across two pseudo filesystems, one of which may not even exist.  
> > > Plus pagemap is not a kernel debugging feature.
> > 
> > That's not what i'm suggesting though.
> > 
> > What i'm suggesting is that there's a zillion ways to enumerate 
> > and index various kernel objects, doing that in /proc is 
> > fundamentally wrong. And there's no need to create a per PID/TID 
> > directory structure in /debug either, to be able to list and 
> > access objects by their PID.
> 
> The problem with procfs was that it was growing a lot of random 
> non-process-related stuff.  We never deprecated procfs - we 
> decided that it should be retained for its original purpose and 
> that non-process-realted things shouldn't go in there.
> 
> The /proc/<pid>/pagemap file clearly _is_ process-related, and 
> /proc/<pid> is the natural and correct place for it to live.
> 
> Yes, sure, there are any number of ways in which that data could 
> be presented to userspace in other locations and via other means.  
> But there would need to be an extraordinarily good reason for 
> violating the existing paradigm/expectation/etc.

It has also been clearly demonstrated in this thread that people 
want more enumeration than just the the process dimension. 

_Especially_ for an object like pages. Often most of the memory in a 
Linux system is _not mapped to any process_. It is in the page 
cache. Still, /proc enumeration does not capture it. Why? Because 
IMO it has been done at the wrong layer, at the wrong abstraction 
level.

Yes, /proc is for process enumeration (as the name tells us 
already), but it is not really suitable as a general object 
enumerator for kernel debugging or kernel instrumentation purposes. 

By putting kernel instrumentation into /proc, we limit all _future_ 
enumeration greatly. Instead of adding just another iterator 
(walker), we now have to move the whole thing across into another 
domain (which is being resisted, and /proc is an ABI anyway).

It's all doable, but a lot harder if it's not being relized why it's 
important to do it.

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: fengguang.wu@intel.com, fweisbec@gmail.com, rostedt@goodmis.org,
	a.p.zijlstra@chello.nl, lizf@cn.fujitsu.com,
	linux-kernel@vger.kernel.org, kosaki.motohiro@jp.fujitsu.com,
	andi@firstfloor.org, mpm@selenic.com, adobriyan@gmail.com,
	linux-mm@kvack.org
Subject: Re: [PATCH 4/8] proc: export more page flags in /proc/kpageflags
Date: Tue, 12 May 2009 00:08:34 +0200	[thread overview]
Message-ID: <20090511220834.GA26614@elte.hu> (raw)
In-Reply-To: <20090511113157.b2c56e70.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 11 May 2009 13:45:54 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
> 
> > > Yes, we could place pagemap's two auxiliary files into debugfs but 
> > > it would be rather stupid to split the feature's control files 
> > > across two pseudo filesystems, one of which may not even exist.  
> > > Plus pagemap is not a kernel debugging feature.
> > 
> > That's not what i'm suggesting though.
> > 
> > What i'm suggesting is that there's a zillion ways to enumerate 
> > and index various kernel objects, doing that in /proc is 
> > fundamentally wrong. And there's no need to create a per PID/TID 
> > directory structure in /debug either, to be able to list and 
> > access objects by their PID.
> 
> The problem with procfs was that it was growing a lot of random 
> non-process-related stuff.  We never deprecated procfs - we 
> decided that it should be retained for its original purpose and 
> that non-process-realted things shouldn't go in there.
> 
> The /proc/<pid>/pagemap file clearly _is_ process-related, and 
> /proc/<pid> is the natural and correct place for it to live.
> 
> Yes, sure, there are any number of ways in which that data could 
> be presented to userspace in other locations and via other means.  
> But there would need to be an extraordinarily good reason for 
> violating the existing paradigm/expectation/etc.

It has also been clearly demonstrated in this thread that people 
want more enumeration than just the the process dimension. 

_Especially_ for an object like pages. Often most of the memory in a 
Linux system is _not mapped to any process_. It is in the page 
cache. Still, /proc enumeration does not capture it. Why? Because 
IMO it has been done at the wrong layer, at the wrong abstraction 
level.

Yes, /proc is for process enumeration (as the name tells us 
already), but it is not really suitable as a general object 
enumerator for kernel debugging or kernel instrumentation purposes. 

By putting kernel instrumentation into /proc, we limit all _future_ 
enumeration greatly. Instead of adding just another iterator 
(walker), we now have to move the whole thing across into another 
domain (which is being resisted, and /proc is an ABI anyway).

It's all doable, but a lot harder if it's not being relized why it's 
important to do it.

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-05-11 22:09 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08 10:53 [PATCH 0/8] export more page flags in /proc/kpageflags (take 6) Wu Fengguang
2009-05-08 10:53 ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 1/8] mm: introduce PageHuge() for testing huge/gigantic pages Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 11:40   ` Ingo Molnar
2009-05-08 11:40     ` Ingo Molnar
2009-05-08 12:21     ` Wu Fengguang
2009-05-08 12:21       ` Wu Fengguang
2009-05-13 17:05   ` Mel Gorman
2009-05-13 17:05     ` Mel Gorman
2009-05-17 13:09     ` Wu Fengguang
2009-05-17 13:09       ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 2/8] slob: use PG_slab for identifying SLOB pages Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 3/8] proc: kpagecount/kpageflags code cleanup Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 4/8] proc: export more page flags in /proc/kpageflags Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 11:47   ` Ingo Molnar
2009-05-08 11:47     ` Ingo Molnar
2009-05-08 12:44     ` Wu Fengguang
2009-05-08 12:44       ` Wu Fengguang
2009-05-09  5:59       ` Ingo Molnar
2009-05-09  5:59         ` Ingo Molnar
2009-05-09  7:56         ` Wu Fengguang
2009-05-09  7:56           ` Wu Fengguang
2009-05-09  6:27       ` [patch] tracing/mm: add page frame snapshot trace Ingo Molnar
2009-05-09  6:27         ` Ingo Molnar
2009-05-09  9:13         ` Wu Fengguang
2009-05-09  9:13           ` Wu Fengguang
2009-05-09  9:24           ` Ingo Molnar
2009-05-09  9:24             ` Ingo Molnar
2009-05-09  9:43             ` Wu Fengguang
2009-05-09  9:43               ` Wu Fengguang
2009-05-09 10:22               ` Ingo Molnar
2009-05-09 10:22                 ` Ingo Molnar
2009-05-09 10:45                 ` Wu Fengguang
2009-05-09 10:45                   ` Wu Fengguang
2009-05-09 10:01           ` Ingo Molnar
2009-05-09 10:01             ` Ingo Molnar
2009-05-09 10:27             ` Ingo Molnar
2009-05-09 10:27               ` Ingo Molnar
2009-05-09 10:57             ` Wu Fengguang
2009-05-09 10:57               ` Wu Fengguang
2009-05-09 11:05               ` Ingo Molnar
2009-05-09 11:05                 ` Ingo Molnar
2009-05-09 12:23                 ` Wu Fengguang
2009-05-09 12:23                   ` Wu Fengguang
2009-05-09 14:05                   ` Ingo Molnar
2009-05-09 14:05                     ` Ingo Molnar
2009-05-10  8:35                     ` Wu Fengguang
2009-05-10  8:35                       ` Wu Fengguang
2009-05-11 12:01                       ` Ingo Molnar
2009-05-11 12:01                         ` Ingo Molnar
2009-05-09 10:36           ` Ingo Molnar
2009-05-09 10:36             ` Ingo Molnar
2009-05-08 12:58     ` ftrace: concurrent accesses possible? Wu Fengguang
2009-05-08 12:58       ` Wu Fengguang
2009-05-08 13:17       ` Steven Rostedt
2009-05-08 13:17         ` Steven Rostedt
2009-05-08 13:43         ` Wu Fengguang
2009-05-08 13:43           ` Wu Fengguang
2009-05-08 20:24     ` [PATCH 4/8] proc: export more page flags in /proc/kpageflags Andrew Morton
2009-05-08 20:24       ` Andrew Morton
2009-05-09 10:44       ` Ingo Molnar
2009-05-09 10:44         ` Ingo Molnar
2009-05-10  3:58         ` Andrew Morton
2009-05-10  3:58           ` Andrew Morton
2009-05-10  5:26         ` Andrew Morton
2009-05-10  5:26           ` Andrew Morton
2009-05-11 11:45           ` Ingo Molnar
2009-05-11 11:45             ` Ingo Molnar
2009-05-11 18:31             ` Andrew Morton
2009-05-11 18:31               ` Andrew Morton
2009-05-11 22:08               ` Ingo Molnar [this message]
2009-05-11 22:08                 ` Ingo Molnar
2009-05-11 19:03             ` Andy Isaacson
2009-05-11 19:03               ` Andy Isaacson
2009-05-08 10:53 ` [PATCH 5/8] pagemap: document clarifications Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 6/8] pagemap: document 9 more exported page flags Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-09  8:13   ` KOSAKI Motohiro
2009-05-09  8:13     ` KOSAKI Motohiro
2009-05-09  8:18     ` Wu Fengguang
2009-05-09  8:18       ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 7/8] pagemap: add page-types tool Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 10:53 ` [PATCH 8/8] pagemap: export PG_hwpoison Wu Fengguang
2009-05-08 10:53   ` Wu Fengguang
2009-05-08 11:49   ` Ingo Molnar
2009-05-08 11:49     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090511220834.GA26614@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mpm@selenic.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.