From: Christoph Hellwig <hch@infradead.org>
To: Theodore Tso <tytso@mit.edu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jan Kara <jack@suse.cz>, Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
akpm@linux-foundation.org, yanmin_zhang@linux.intel.com,
richard@rsk.demon.co.uk, damien.wyart@free.fr,
Alex Chiang <achiang@hp.com>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>
Subject: Re: [PATCH 0/11] Per-bdi writeback flusher threads v8
Date: Thu, 28 May 2009 15:38:22 -0400 [thread overview]
Message-ID: <20090528193822.GA30982@infradead.org> (raw)
In-Reply-To: <20090528193246.GX26625@mit.edu>
On Thu, May 28, 2009 at 03:32:46PM -0400, Theodore Tso wrote:
>
> I'm pretty sure that after the first call to invalidate_inodes() in
> fs/super.c's generic_shutdown_super(), we really don't need to hold
> the BKL or the superblock lock (and let the filesystems' low-level
> write_super(0 and put_super() take the lock if they really need it),
> but we probably need to take a closer look at this to make sure it's
> true for all filesystems. (IIRC, I think Christoph was looking to
> clean up lock_super(); at least with respect to the write_super call.
> I don't know what his plans regarding the BKL and put_super(),
> though.)
Both the BKL and lock_super are not held for ->put_super anymore in
the vfs tree. In fact in the vfs tree there are no callers of
lock_super in the VFS anymore.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Theodore Tso <tytso@mit.edu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jan Kara <jack@suse.cz>, Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vge
Subject: Re: [PATCH 0/11] Per-bdi writeback flusher threads v8
Date: Thu, 28 May 2009 15:38:22 -0400 [thread overview]
Message-ID: <20090528193822.GA30982@infradead.org> (raw)
In-Reply-To: <20090528193246.GX26625@mit.edu>
On Thu, May 28, 2009 at 03:32:46PM -0400, Theodore Tso wrote:
>
> I'm pretty sure that after the first call to invalidate_inodes() in
> fs/super.c's generic_shutdown_super(), we really don't need to hold
> the BKL or the superblock lock (and let the filesystems' low-level
> write_super(0 and put_super() take the lock if they really need it),
> but we probably need to take a closer look at this to make sure it's
> true for all filesystems. (IIRC, I think Christoph was looking to
> clean up lock_super(); at least with respect to the write_super call.
> I don't know what his plans regarding the BKL and put_super(),
> though.)
Both the BKL and lock_super are not held for ->put_super anymore in
the vfs tree. In fact in the vfs tree there are no callers of
lock_super in the VFS anymore.
next prev parent reply other threads:[~2009-05-28 19:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 9:41 [PATCH 0/11] Per-bdi writeback flusher threads v8 Jens Axboe
2009-05-27 9:41 ` [PATCH 01/11] ntfs: remove old debug check for dirty data in ntfs_put_super() Jens Axboe
2009-05-27 9:41 ` [PATCH 02/11] btrfs: properly register fs backing device Jens Axboe
2009-05-27 9:41 ` [PATCH 03/11] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-05-27 9:41 ` [PATCH 04/11] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-05-27 11:11 ` Peter Zijlstra
2009-05-27 11:24 ` Jens Axboe
2009-05-27 15:14 ` Jan Kara
2009-05-27 17:50 ` Jens Axboe
2009-05-28 14:45 ` Jan Kara
2009-05-27 9:41 ` [PATCH 05/11] writeback: get rid of pdflush completely Jens Axboe
2009-05-27 9:41 ` [PATCH 06/11] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-05-27 9:41 ` [PATCH 07/11] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-05-28 9:27 ` Jan Kara
2009-05-28 10:40 ` Jens Axboe
2009-05-28 12:43 ` Jan Kara
2009-05-28 12:53 ` Jens Axboe
2009-05-28 13:58 ` Jan Kara
2009-05-27 9:41 ` [PATCH 08/11] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-05-27 9:41 ` [PATCH 09/11] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-05-27 9:41 ` [PATCH 10/11] writeback: add name to backing_dev_info Jens Axboe
2009-05-27 9:41 ` [PATCH 11/11] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-05-27 12:41 ` [PATCH 0/11] Per-bdi writeback flusher threads v8 Richard Kennedy
2009-05-27 12:47 ` Jens Axboe
2009-05-27 14:47 ` Theodore Tso
2009-05-27 15:05 ` Jens Axboe
2009-05-27 17:53 ` Theodore Tso
2009-05-27 17:53 ` Theodore Tso
2009-05-27 17:57 ` Jens Axboe
2009-05-27 17:58 ` Theodore Tso
2009-05-27 17:58 ` Theodore Tso
2009-05-27 18:14 ` Jens Axboe
2009-05-27 19:15 ` Jens Axboe
2009-05-27 19:45 ` Jens Axboe
2009-05-28 0:49 ` Theodore Tso
2009-05-28 9:28 ` Jan Kara
2009-05-28 9:28 ` Jan Kara
2009-05-28 9:36 ` Jens Axboe
2009-05-28 15:23 ` Eric W. Biederman
2009-05-28 19:32 ` Theodore Tso
2009-05-28 19:38 ` Christoph Hellwig [this message]
2009-05-28 19:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528193822.GA30982@infradead.org \
--to=hch@infradead.org \
--cc=achiang@hp.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=damien.wyart@free.fr \
--cc=david@fromorbit.com \
--cc=ebiederm@aristanetworks.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
--cc=tytso@mit.edu \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.