All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Nick Piggin <npiggin@suse.de>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andi Kleen <andi@firstfloor.org>,
	"riel@redhat.com" <riel@redhat.com>,
	"chris.mason@oracle.com" <chris.mason@oracle.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/5] HWPOISON: define VM_FAULT_HWPOISON to 0 when feature is disabled
Date: Fri, 12 Jun 2009 17:45:25 +0200	[thread overview]
Message-ID: <20090612154525.GA14438@elte.hu> (raw)
In-Reply-To: <20090612131754.GA32105@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> So i find the whole feature rather dubious - what's the point? We 
> should panic at this point - we just corrupted user data so that 
> piece of hardware cannot be trusted. Nor can any subsequent kernel 
> bug messages be trusted.

s/panic/print nasty message

Not sure what i was smoking there. Sysadmin will panic from a memory 
corruption message anyway.

What feels wrong to me is: kill a process and - in the case where 
that process is restartable or expendable - suggest to the admin 
that "everything is fine, we handled it just fine".

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Nick Piggin <npiggin@suse.de>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andi Kleen <andi@firstfloor.org>,
	"riel@redhat.com" <riel@redhat.com>,
	"chris.mason@oracle.com" <chris.mason@oracle.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/5] HWPOISON: define VM_FAULT_HWPOISON to 0 when feature is disabled
Date: Fri, 12 Jun 2009 17:45:25 +0200	[thread overview]
Message-ID: <20090612154525.GA14438@elte.hu> (raw)
In-Reply-To: <20090612131754.GA32105@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> So i find the whole feature rather dubious - what's the point? We 
> should panic at this point - we just corrupted user data so that 
> piece of hardware cannot be trusted. Nor can any subsequent kernel 
> bug messages be trusted.

s/panic/print nasty message

Not sure what i was smoking there. Sysadmin will panic from a memory 
corruption message anyway.

What feels wrong to me is: kill a process and - in the case where 
that process is restartable or expendable - suggest to the admin 
that "everything is fine, we handled it just fine".

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-06-12 15:45 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 14:22 [PATCH 0/5] [RFC] HWPOISON incremental fixes Wu Fengguang
2009-06-11 14:22 ` Wu Fengguang
2009-06-11 14:22 ` [PATCH 1/5] HWPOISON: define VM_FAULT_HWPOISON to 0 when feature is disabled Wu Fengguang
2009-06-11 14:22   ` Wu Fengguang
2009-06-11 15:44   ` Rik van Riel
2009-06-11 15:44     ` Rik van Riel
2009-06-12 10:00   ` Andi Kleen
2009-06-12 10:00     ` Andi Kleen
2009-06-12 13:15     ` Wu Fengguang
2009-06-12 13:15       ` Wu Fengguang
2009-06-12 11:22   ` Ingo Molnar
2009-06-12 11:22     ` Ingo Molnar
2009-06-12 12:57     ` Wu Fengguang
2009-06-12 12:57       ` Wu Fengguang
2009-06-12 13:17       ` Ingo Molnar
2009-06-12 13:17         ` Ingo Molnar
2009-06-12 13:33         ` Wu Fengguang
2009-06-12 13:33           ` Wu Fengguang
2009-06-12 15:36           ` Ingo Molnar
2009-06-12 15:36             ` Ingo Molnar
2009-06-12 16:14             ` Wu Fengguang
2009-06-12 16:14               ` Wu Fengguang
2009-06-12 18:07               ` Alan Cox
2009-06-12 18:07                 ` Alan Cox
2009-06-12 17:55             ` Theodore Tso
2009-06-12 17:55               ` Theodore Tso
2009-06-12 13:58         ` Andi Kleen
2009-06-12 13:58           ` Andi Kleen
2009-06-12 15:28         ` Linus Torvalds
2009-06-12 15:28           ` Linus Torvalds
2009-06-12 15:35           ` Ingo Molnar
2009-06-12 15:35             ` Ingo Molnar
2009-06-12 16:05             ` Rik van Riel
2009-06-12 16:05               ` Rik van Riel
2009-06-12 16:37             ` H. Peter Anvin
2009-06-12 16:37               ` H. Peter Anvin
2009-06-12 16:48               ` Ingo Molnar
2009-06-12 16:48                 ` Ingo Molnar
2009-06-15  7:04               ` Nick Piggin
2009-06-15  7:04                 ` Nick Piggin
2009-06-15  6:52             ` Nick Piggin
2009-06-15  6:52               ` Nick Piggin
2009-06-16 20:27               ` Russ Anderson
2009-06-16 20:27                 ` Russ Anderson
2009-06-17  7:51                 ` Nick Piggin
2009-06-17  7:51                   ` Nick Piggin
2009-06-12 15:45         ` Ingo Molnar [this message]
2009-06-12 15:45           ` Ingo Molnar
2009-06-12 16:12           ` Linus Torvalds
2009-06-12 16:12             ` Linus Torvalds
2009-06-11 14:22 ` [PATCH 2/5] HWPOISON: fix tasklist_lock/anon_vma locking order Wu Fengguang
2009-06-11 14:22   ` Wu Fengguang
2009-06-11 15:59   ` Rik van Riel
2009-06-11 15:59     ` Rik van Riel
2009-06-12 10:03   ` Andi Kleen
2009-06-12 10:03     ` Andi Kleen
2009-06-12 10:07     ` Nick Piggin
2009-06-12 10:07       ` Nick Piggin
2009-06-12 13:27     ` Wu Fengguang
2009-06-12 13:27       ` Wu Fengguang
2009-06-12 14:04       ` Wu Fengguang
2009-06-12 14:04         ` Wu Fengguang
2009-06-11 14:22 ` [PATCH 3/5] HWPOISON: remove early kill option for now Wu Fengguang
2009-06-11 14:22   ` Wu Fengguang
2009-06-11 16:06   ` Rik van Riel
2009-06-11 16:06     ` Rik van Riel
2009-06-12  9:59   ` Andi Kleen
2009-06-12  9:59     ` Andi Kleen
2009-06-11 14:22 ` [PATCH 4/5] HWPOISON: report sticky EIO for poisoned file Wu Fengguang
2009-06-11 14:22   ` Wu Fengguang
2009-06-11 16:31   ` Rik van Riel
2009-06-11 16:31     ` Rik van Riel
2009-06-12 10:07   ` Andi Kleen
2009-06-12 10:07     ` Andi Kleen
2009-06-12 13:41     ` Wu Fengguang
2009-06-12 13:41       ` Wu Fengguang
2009-06-11 14:22 ` [PATCH 5/5] HWPOISON: use the safer invalidate page for possible metadata pages Wu Fengguang
2009-06-11 14:22   ` Wu Fengguang
2009-06-11 16:36   ` Rik van Riel
2009-06-11 16:36     ` Rik van Riel
2009-06-12 10:56 ` [PATCH 0/5] [RFC] HWPOISON incremental fixes Andi Kleen
2009-06-12 10:56   ` Andi Kleen
2009-06-12 13:59   ` Wu Fengguang
2009-06-12 13:59     ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090612154525.GA14438@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=chris.mason@oracle.com \
    --cc=fengguang.wu@intel.com \
    --cc=hpa@zytor.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.