From: Andrew Morton <akpm@linux-foundation.org>
To: "David Härdeman" <david@hardeman.nu>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-input@vger.kernel.org, jbarnes@virtuousgeek.org
Subject: Re: [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality.
Date: Wed, 1 Jul 2009 11:06:16 -0700 [thread overview]
Message-ID: <20090701110616.60c05a5d.akpm@linux-foundation.org> (raw)
In-Reply-To: <35c700707581a42af21dd9edc82a5e84.squirrel@www.hardeman.nu>
On Wed, 1 Jul 2009 09:47:46 +0200 (CEST)
David H__rdeman <david@hardeman.nu> wrote:
> >> + struct wbcir_data *data = input_get_drvdata(dev);
> >> +
> >> + if (scancode < 0 || scancode > 0xFFFFFFFF)
> >
> > Neither of the comparisons in this expression can ever be true.
>
> Didn't know if I could be certain that int is always 32 bit on all
> platforms which use/might use the chip...can I?
Yep, int and unsigned int are always 32-bit.
It's not a big deal at all - the compiler will optimise the tests away
completely. The tests may have some value as code commentary, and they
provide robustness should someone change the type of `scancode'.
> >> + return -EINVAL;
> >> +
> >> + *keycode = (int)wbcir_do_getkeycode(data, (u32)scancode);
> >
> > uneeded casts.
> >
> > Something has gone wrong with the types here. Where does the fault lie
> > - this driver, or input core?
>
> Two issues:
>
> a) the input layer API confused me
>
> include/linux/input.h provides:
>
> struct input_event {
> struct timeval time;
> __u16 type;
> __u16 code;
> __s32 value;
> };
>
> (keycode is an unsigned 16 bit integer)
>
> int input_get_keycode(struct input_dev *dev, int scancode, int *keycode);
> int input_set_keycode(struct input_dev *dev, int scancode, int keycode);
>
> (keycode is an int)
>
> static inline void input_report_key(struct input_dev *dev,
> unsigned int code,
> int value)
> {
> input_event(dev, EV_KEY, code, !!value);
> }
>
> (keycode is an uint)
>
>
> b) 32 bit scancodes
>
> I wanted to use 32 bit scancodes in my driver since the largest IR message
> supported by the driver is RC6 mode 6A which can potentially have a 1 + 15
> bits "customer" field + 8 bits address + 8 bits command = 32 bits.
>
> Casting the int scancode passed to input_[get__set]_keycode to an uint and
> assuming it would be at least 32 bits on all platforms using the chip was
> the best solution I could come up with without changing the input API.
erp. Hopefully this is all something which Dmitry can help us with.
> >> +{
> >> + struct wbcir_data *data = (struct wbcir_data *)cookie;
> >> + unsigned long flags;
> >> +
> >> + /*
> >> + * data->keyup_jiffies is used to prevent a race condition if a
> >> + * hardware interrupt occurs at this point and the keyup timer
> >> + * event is moved further into the future as a result.
> >> + */
> >
> >hm. I don't see what the race is, nor how the comparison fixes it. If
> >I _did_ understand this, perhaps I could suggest alternative fixes.
> >But I don't so I can't. Oh well.
>
> When the interrupt service routine detects an IR command it reports a
> keydown event and sets a timer to report a keyup event in the future if no
> repeated ir messages are detected (in which case the timer-driven keyup
> should be pushed further into the future to allow the input core to do its
> auto-repeat-handling magic).
>
> What I wanted to protect against was something like this:
>
> Thread 1 Thread 2
> -------- --------
> ISR called, grabs
> wbcir_lock, reports
> keydown for key X,
> sets up keyup timer,
> releases lock, exits
>
> (many ms later)
>
> keyup timer function called
> and preempted before grabbing
> wbcir_lock
>
> ISR called, grabs wbcir_lock,
> notices a repeat event for
> key X, pushes the keyup timer
> further into the future using
> mod_timer (thus reenabling the
> timer), releases lock, exits
> keyup timer function grabs
> wbcir_lock, reports keyup,
> exits.
> (many ms later)
>
> keyup timer function called *again*,
> reports keyup, exits.
>
> The result would be (if I understood the timer implementation correctly)
> that a keyup event is reported immediately after the second ISR even
> though the "first" timer function call should have been cancelled/pushed
> further into the future at that point.
>
> Does this make any sense? :)
yes. The timer will be rescheduledin the scenario which you describe.
Here's my problem: often when I ask a question about some code, what I
_really_ mean is "if I didn't understand this code today, others
probably won't understand it when reading it a year from now. Hence it
perhaps needs additional commentary to prevent this". But I tire of
complaining about code comments ;)
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "David Härdeman" <david@hardeman.nu>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-input@vger.kernel.org, jbarnes@virtuousgeek.org
Subject: Re: [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality.
Date: Wed, 1 Jul 2009 11:06:16 -0700 [thread overview]
Message-ID: <20090701110616.60c05a5d.akpm@linux-foundation.org> (raw)
In-Reply-To: <35c700707581a42af21dd9edc82a5e84.squirrel@www.hardeman.nu>
On Wed, 1 Jul 2009 09:47:46 +0200 (CEST)
David H__rdeman <david@hardeman.nu> wrote:
> >> + struct wbcir_data *data = input_get_drvdata(dev);
> >> +
> >> + if (scancode < 0 || scancode > 0xFFFFFFFF)
> >
> > Neither of the comparisons in this expression can ever be true.
>
> Didn't know if I could be certain that int is always 32 bit on all
> platforms which use/might use the chip...can I?
Yep, int and unsigned int are always 32-bit.
It's not a big deal at all - the compiler will optimise the tests away
completely. The tests may have some value as code commentary, and they
provide robustness should someone change the type of `scancode'.
> >> + return -EINVAL;
> >> +
> >> + *keycode = (int)wbcir_do_getkeycode(data, (u32)scancode);
> >
> > uneeded casts.
> >
> > Something has gone wrong with the types here. Where does the fault lie
> > - this driver, or input core?
>
> Two issues:
>
> a) the input layer API confused me
>
> include/linux/input.h provides:
>
> struct input_event {
> struct timeval time;
> __u16 type;
> __u16 code;
> __s32 value;
> };
>
> (keycode is an unsigned 16 bit integer)
>
> int input_get_keycode(struct input_dev *dev, int scancode, int *keycode);
> int input_set_keycode(struct input_dev *dev, int scancode, int keycode);
>
> (keycode is an int)
>
> static inline void input_report_key(struct input_dev *dev,
> unsigned int code,
> int value)
> {
> input_event(dev, EV_KEY, code, !!value);
> }
>
> (keycode is an uint)
>
>
> b) 32 bit scancodes
>
> I wanted to use 32 bit scancodes in my driver since the largest IR message
> supported by the driver is RC6 mode 6A which can potentially have a 1 + 15
> bits "customer" field + 8 bits address + 8 bits command = 32 bits.
>
> Casting the int scancode passed to input_[get__set]_keycode to an uint and
> assuming it would be at least 32 bits on all platforms using the chip was
> the best solution I could come up with without changing the input API.
erp. Hopefully this is all something which Dmitry can help us with.
> >> +{
> >> + struct wbcir_data *data = (struct wbcir_data *)cookie;
> >> + unsigned long flags;
> >> +
> >> + /*
> >> + * data->keyup_jiffies is used to prevent a race condition if a
> >> + * hardware interrupt occurs at this point and the keyup timer
> >> + * event is moved further into the future as a result.
> >> + */
> >
> >hm. I don't see what the race is, nor how the comparison fixes it. If
> >I _did_ understand this, perhaps I could suggest alternative fixes.
> >But I don't so I can't. Oh well.
>
> When the interrupt service routine detects an IR command it reports a
> keydown event and sets a timer to report a keyup event in the future if no
> repeated ir messages are detected (in which case the timer-driven keyup
> should be pushed further into the future to allow the input core to do its
> auto-repeat-handling magic).
>
> What I wanted to protect against was something like this:
>
> Thread 1 Thread 2
> -------- --------
> ISR called, grabs
> wbcir_lock, reports
> keydown for key X,
> sets up keyup timer,
> releases lock, exits
>
> (many ms later)
>
> keyup timer function called
> and preempted before grabbing
> wbcir_lock
>
> ISR called, grabs wbcir_lock,
> notices a repeat event for
> key X, pushes the keyup timer
> further into the future using
> mod_timer (thus reenabling the
> timer), releases lock, exits
> keyup timer function grabs
> wbcir_lock, reports keyup,
> exits.
> (many ms later)
>
> keyup timer function called *again*,
> reports keyup, exits.
>
> The result would be (if I understood the timer implementation correctly)
> that a keyup event is reported immediately after the second ISR even
> though the "first" timer function call should have been cancelled/pushed
> further into the future at that point.
>
> Does this make any sense? :)
yes. The timer will be rescheduledin the scenario which you describe.
Here's my problem: often when I ask a question about some code, what I
_really_ mean is "if I didn't understand this code today, others
probably won't understand it when reading it a year from now. Hence it
perhaps needs additional commentary to prevent this". But I tire of
complaining about code comments ;)
next prev parent reply other threads:[~2009-07-01 18:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 5:18 [PATCH 0/2] Winbond IR driver David Härdeman
2009-06-27 5:18 ` David Härdeman
2009-06-27 5:18 ` [PATCH 1/2] ACPI: reintroduce acpi_device_ops .shutdown method David Härdeman
2009-06-27 5:18 ` David Härdeman
2009-06-30 21:10 ` Andrew Morton
2009-06-30 21:10 ` Andrew Morton
2009-06-30 23:11 ` Bjorn Helgaas
2009-07-01 8:20 ` David Härdeman
2009-07-01 8:20 ` David Härdeman
2009-07-08 16:52 ` Bjorn Helgaas
2009-07-08 16:52 ` Bjorn Helgaas
2009-07-09 21:38 ` [PATCH 0/2] Winbond driver as PNP Bjorn Helgaas
2009-07-09 21:38 ` Bjorn Helgaas
2009-07-09 21:39 ` [PATCH 1/2] PNP: add .shutdown method Bjorn Helgaas
2009-07-09 21:40 ` [PATCH 2/2] Winbond: convert from ACPI to PNP driver Bjorn Helgaas
2009-07-09 21:40 ` Bjorn Helgaas
2009-07-10 7:55 ` [PATCH 0/2] Winbond driver as PNP David Härdeman
2009-07-10 7:55 ` David Härdeman
2009-07-10 16:01 ` Bjorn Helgaas
2009-07-10 16:01 ` Bjorn Helgaas
2009-06-27 5:18 ` [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality David Härdeman
2009-06-27 5:18 ` David Härdeman
2009-06-30 21:23 ` Andrew Morton
2009-06-30 21:23 ` Andrew Morton
2009-07-01 7:47 ` David Härdeman
2009-07-01 7:47 ` David Härdeman
2009-07-01 18:06 ` Andrew Morton [this message]
2009-07-01 18:06 ` Andrew Morton
2009-07-01 21:45 ` David Härdeman
2009-07-01 21:45 ` David Härdeman
2009-07-01 21:47 ` David Härdeman
2009-07-01 21:47 ` David Härdeman
2009-07-01 21:53 ` Jesse Barnes
2009-07-01 21:53 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701110616.60c05a5d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@hardeman.nu \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.