All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "David Härdeman" <david@hardeman.nu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-input@vger.kernel.org, jbarnes@virtuousgeek.org,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 0/2] Winbond driver as PNP
Date: Fri, 10 Jul 2009 10:01:21 -0600	[thread overview]
Message-ID: <200907101001.22122.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <11512ed726f2d6754f46e76c7db191a8.squirrel@www.hardeman.nu>

On Friday 10 July 2009 01:55:27 am David Härdeman wrote:
> On Thu, July 9, 2009 23:38, Bjorn Helgaas wrote:
> > Here are two sample patches to show you what I was suggesting.  These
> > apply on top of the two Winbond patches currently in -mm.
> 
> Thanks, great service :)
> 
> I'll test the patches as soon as I have time and access to the hardware.
> 
> One question though, the resulting patch series (if AKPM merges these
> patches in addition to the existing ones and drops the patch adding
> .shutdown to acpi_driver) will be git bisect unfriendly.
> 
> Should I roll two new patches instead to replace the three patches
> currently in -mm?

If you like the approach and it works, I would take the latter
approach (replace the three patches with two new ones -- e.g.,
add-pnp-shutdown-method and add-winbond-pnp-driver).  I don't
think we have to worry about bisectability until they show up
in a git tree.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "David Härdeman" <david@hardeman.nu>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-input@vger.kernel.org, jbarnes@virtuousgeek.org,
	"Len Brown" <lenb@kernel.org>
Subject: Re: [PATCH 0/2] Winbond driver as PNP
Date: Fri, 10 Jul 2009 10:01:21 -0600	[thread overview]
Message-ID: <200907101001.22122.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <11512ed726f2d6754f46e76c7db191a8.squirrel@www.hardeman.nu>

On Friday 10 July 2009 01:55:27 am David Härdeman wrote:
> On Thu, July 9, 2009 23:38, Bjorn Helgaas wrote:
> > Here are two sample patches to show you what I was suggesting.  These
> > apply on top of the two Winbond patches currently in -mm.
> 
> Thanks, great service :)
> 
> I'll test the patches as soon as I have time and access to the hardware.
> 
> One question though, the resulting patch series (if AKPM merges these
> patches in addition to the existing ones and drops the patch adding
> .shutdown to acpi_driver) will be git bisect unfriendly.
> 
> Should I roll two new patches instead to replace the three patches
> currently in -mm?

If you like the approach and it works, I would take the latter
approach (replace the three patches with two new ones -- e.g.,
add-pnp-shutdown-method and add-winbond-pnp-driver).  I don't
think we have to worry about bisectability until they show up
in a git tree.

Bjorn

  reply	other threads:[~2009-07-10 16:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-27  5:18 [PATCH 0/2] Winbond IR driver David Härdeman
2009-06-27  5:18 ` David Härdeman
2009-06-27  5:18 ` [PATCH 1/2] ACPI: reintroduce acpi_device_ops .shutdown method David Härdeman
2009-06-27  5:18   ` David Härdeman
2009-06-30 21:10   ` Andrew Morton
2009-06-30 21:10     ` Andrew Morton
2009-06-30 23:11     ` Bjorn Helgaas
2009-07-01  8:20       ` David Härdeman
2009-07-01  8:20         ` David Härdeman
2009-07-08 16:52         ` Bjorn Helgaas
2009-07-08 16:52           ` Bjorn Helgaas
2009-07-09 21:38           ` [PATCH 0/2] Winbond driver as PNP Bjorn Helgaas
2009-07-09 21:38             ` Bjorn Helgaas
2009-07-09 21:39             ` [PATCH 1/2] PNP: add .shutdown method Bjorn Helgaas
2009-07-09 21:40             ` [PATCH 2/2] Winbond: convert from ACPI to PNP driver Bjorn Helgaas
2009-07-09 21:40               ` Bjorn Helgaas
2009-07-10  7:55             ` [PATCH 0/2] Winbond driver as PNP David Härdeman
2009-07-10  7:55               ` David Härdeman
2009-07-10 16:01               ` Bjorn Helgaas [this message]
2009-07-10 16:01                 ` Bjorn Helgaas
2009-06-27  5:18 ` [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality David Härdeman
2009-06-27  5:18   ` David Härdeman
2009-06-30 21:23   ` Andrew Morton
2009-06-30 21:23     ` Andrew Morton
2009-07-01  7:47     ` David Härdeman
2009-07-01  7:47       ` David Härdeman
2009-07-01 18:06       ` Andrew Morton
2009-07-01 18:06         ` Andrew Morton
2009-07-01 21:45         ` David Härdeman
2009-07-01 21:45           ` David Härdeman
2009-07-01 21:47     ` David Härdeman
2009-07-01 21:47       ` David Härdeman
2009-07-01 21:53       ` Jesse Barnes
2009-07-01 21:53         ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907101001.22122.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@hardeman.nu \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.