All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "David Härdeman" <david@hardeman.nu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality.
Date: Wed, 1 Jul 2009 14:53:51 -0700	[thread overview]
Message-ID: <20090701145351.78c0f28b@jbarnes-g45> (raw)
In-Reply-To: <20090701214753.GB5946@hardeman.nu>

On Wed, 1 Jul 2009 23:47:53 +0200
David Härdeman <david@hardeman.nu> wrote:

> This patch adds a driver for the the Consumer IR (CIR) functionality
> of the Winbond WPCD376I chipset (found on e.g. Intel DG45FC
> motherboards).
> 
> Changes since the driver was first posted to the list:
> o Homebrew dprintk -> dev_dbg
> o Some magic values changed to defines
> o Fixed a bug where the wake-ir-command mask/value would not be
>    written properly
> o Fixed the use of the invert parameter both for wake and normal
>    IR reception.
> 
> Changes since the second post to the list (AKPM's remarks):
> o Various comments added
> o Removed some casts
> o use bitrev8
> o convert data->irdata to unsigned longs, use __set_bit and test_bit
> 
> Andrew, please replace the patch you currently have in the -mm tree
> with this one.
> 
> Signed-off-by: David Härdeman <david@hardeman.nu>

Looking nice to me...  Thanks for writing this, David.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "David Härdeman" <david@hardeman.nu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality.
Date: Wed, 1 Jul 2009 14:53:51 -0700	[thread overview]
Message-ID: <20090701145351.78c0f28b@jbarnes-g45> (raw)
In-Reply-To: <20090701214753.GB5946@hardeman.nu>

On Wed, 1 Jul 2009 23:47:53 +0200
David Härdeman <david@hardeman.nu> wrote:

> This patch adds a driver for the the Consumer IR (CIR) functionality
> of the Winbond WPCD376I chipset (found on e.g. Intel DG45FC
> motherboards).
> 
> Changes since the driver was first posted to the list:
> o Homebrew dprintk -> dev_dbg
> o Some magic values changed to defines
> o Fixed a bug where the wake-ir-command mask/value would not be
>    written properly
> o Fixed the use of the invert parameter both for wake and normal
>    IR reception.
> 
> Changes since the second post to the list (AKPM's remarks):
> o Various comments added
> o Removed some casts
> o use bitrev8
> o convert data->irdata to unsigned longs, use __set_bit and test_bit
> 
> Andrew, please replace the patch you currently have in the -mm tree
> with this one.
> 
> Signed-off-by: David Härdeman <david@hardeman.nu>

Looking nice to me...  Thanks for writing this, David.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2009-07-01 21:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-27  5:18 [PATCH 0/2] Winbond IR driver David Härdeman
2009-06-27  5:18 ` David Härdeman
2009-06-27  5:18 ` [PATCH 1/2] ACPI: reintroduce acpi_device_ops .shutdown method David Härdeman
2009-06-27  5:18   ` David Härdeman
2009-06-30 21:10   ` Andrew Morton
2009-06-30 21:10     ` Andrew Morton
2009-06-30 23:11     ` Bjorn Helgaas
2009-07-01  8:20       ` David Härdeman
2009-07-01  8:20         ` David Härdeman
2009-07-08 16:52         ` Bjorn Helgaas
2009-07-08 16:52           ` Bjorn Helgaas
2009-07-09 21:38           ` [PATCH 0/2] Winbond driver as PNP Bjorn Helgaas
2009-07-09 21:38             ` Bjorn Helgaas
2009-07-09 21:39             ` [PATCH 1/2] PNP: add .shutdown method Bjorn Helgaas
2009-07-09 21:40             ` [PATCH 2/2] Winbond: convert from ACPI to PNP driver Bjorn Helgaas
2009-07-09 21:40               ` Bjorn Helgaas
2009-07-10  7:55             ` [PATCH 0/2] Winbond driver as PNP David Härdeman
2009-07-10  7:55               ` David Härdeman
2009-07-10 16:01               ` Bjorn Helgaas
2009-07-10 16:01                 ` Bjorn Helgaas
2009-06-27  5:18 ` [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality David Härdeman
2009-06-27  5:18   ` David Härdeman
2009-06-30 21:23   ` Andrew Morton
2009-06-30 21:23     ` Andrew Morton
2009-07-01  7:47     ` David Härdeman
2009-07-01  7:47       ` David Härdeman
2009-07-01 18:06       ` Andrew Morton
2009-07-01 18:06         ` Andrew Morton
2009-07-01 21:45         ` David Härdeman
2009-07-01 21:45           ` David Härdeman
2009-07-01 21:47     ` David Härdeman
2009-07-01 21:47       ` David Härdeman
2009-07-01 21:53       ` Jesse Barnes [this message]
2009-07-01 21:53         ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090701145351.78c0f28b@jbarnes-g45 \
    --to=jbarnes@virtuousgeek.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@hardeman.nu \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.