All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, Jens Axboe <jens.axboe@oracle.com>
Cc: linux-fsdevel@vger.kernel.org,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 13/18] SYSV: do not manipulate s_dirt directly
Date: Thu, 09 Jul 2009 11:49:53 +0300	[thread overview]
Message-ID: <20090709084953.12122.17032.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20090709084822.12122.79749.sendpatchset@localhost.localdomain>

... use new VFS helpers instead.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/sysv/inode.c |    6 +++---
 fs/sysv/super.c |    2 +-
 fs/sysv/sysv.h  |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
index 9824743..7cf8d82 100644
--- a/fs/sysv/inode.c
+++ b/fs/sysv/inode.c
@@ -60,7 +60,7 @@ static void sysv_write_super(struct super_block *sb)
 	if (!(sb->s_flags & MS_RDONLY))
 		sysv_sync_fs(sb, 1);
 	else
-		sb->s_dirt = 0;
+		mark_sb_clean(sb);
 }
 
 static int sysv_remount(struct super_block *sb, int *flags, char *data)
@@ -70,7 +70,7 @@ static int sysv_remount(struct super_block *sb, int *flags, char *data)
 	if (sbi->s_forced_ro)
 		*flags |= MS_RDONLY;
 	if (!(*flags & MS_RDONLY))
-		sb->s_dirt = 1;
+		mark_sb_dirty(sb);
 	unlock_super(sb);
 	return 0;
 }
@@ -79,7 +79,7 @@ static void sysv_put_super(struct super_block *sb)
 {
 	struct sysv_sb_info *sbi = SYSV_SB(sb);
 
-	if (sb->s_dirt)
+	if (is_sb_dirty(sb))
 		sysv_write_super(sb);
 
 	if (!(sb->s_flags & MS_RDONLY)) {
diff --git a/fs/sysv/super.c b/fs/sysv/super.c
index 5a903da..f0d3679 100644
--- a/fs/sysv/super.c
+++ b/fs/sysv/super.c
@@ -347,7 +347,7 @@ static int complete_read_super(struct super_block *sb, int silent, int size)
 		sb->s_flags |= MS_RDONLY;
 	if (sbi->s_truncate)
 		sb->s_root->d_op = &sysv_dentry_operations;
-	sb->s_dirt = 1;
+	mark_sb_dirty(sb);
 	return 1;
 }
 
diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h
index 53786eb..1467ff2 100644
--- a/fs/sysv/sysv.h
+++ b/fs/sysv/sysv.h
@@ -118,7 +118,7 @@ static inline void dirty_sb(struct super_block *sb)
 	mark_buffer_dirty(sbi->s_bh1);
 	if (sbi->s_bh1 != sbi->s_bh2)
 		mark_buffer_dirty(sbi->s_bh2);
-	sb->s_dirt = 1;
+	mark_sb_dirty(sb);
 }
 
 
-- 
1.6.0.6


  parent reply	other threads:[~2009-07-09  7:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  8:48 [PATCH v3 00/18] periodic write-back timer optimization Artem Bityutskiy
2009-07-09  8:48 ` Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 01/18] VFS: introduce helpers for manipulation s_dirty flag Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 02/18] AFFS: do not manipulate s_dirt directly Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 03/18] BFS: " Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 04/18] EXOFS: " Artem Bityutskiy
2009-07-12  9:53   ` Boaz Harrosh
2009-07-12 14:02     ` Artem Bityutskiy
2009-07-12 14:02       ` Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 05/18] EXT2: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 06/18] EXT4: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 07/18] FAT: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 08/18] HFS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 09/18] HFSPLUS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 10/18] JFFS2: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 11/18] NILFS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 12/18] reiserfs: " Artem Bityutskiy
2009-07-09  8:49 ` Artem Bityutskiy [this message]
2009-07-09  8:49 ` [PATCH v3 14/18] UDF: " Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 15/18] UFS: " Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 16/18] VFS: use is_sb_dirty helper Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 17/18] rename s_dirt to s_dirty Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 18/18] writeback: optimize periodic sync_supers Artem Bityutskiy
2009-07-09 12:37 ` [PATCH v3 00/18] periodic write-back timer optimization Andi Kleen
2009-07-09 13:04   ` Artem Bityutskiy
2009-07-09 13:04     ` Artem Bityutskiy
2009-07-15  6:21 ` Artem Bityutskiy
2009-07-15  6:21   ` Artem Bityutskiy
2009-07-24 15:45   ` Artem Bityutskiy
2009-07-24 15:45     ` Artem Bityutskiy
2009-09-14 15:27     ` Artem Bityutskiy
2009-09-14 15:27       ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090709084953.12122.17032.sendpatchset@localhost.localdomain \
    --to=artem.bityutskiy@nokia.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.