All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	Jens Axboe <jens.axboe@oracle.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/18] periodic write-back timer optimization
Date: Thu, 09 Jul 2009 16:04:57 +0300	[thread overview]
Message-ID: <4A55EAF9.9070907@nokia.com> (raw)
In-Reply-To: <871voq6nh6.fsf@basil.nowhere.org>

Andi Kleen wrote:
> Artem Bityutskiy <Artem.Bityutskiy@nokia.com> writes:
> 
>> The patches attempt to optimize the periodic write-back and stop it when
>> there are no dirty data. IOW, we do not want the thread to wake up every
>> 5 seconds (by default), find there is nothing to do, and so on.
> 
> Is waking up every 5 seconds really a problem?

Yes, it is. In OMAP3 we may switch the core and most of peripherals
to off and we may stay in off and consume really few power. And waking
up from off every 5 seconds for no good reason is bad.

> The normal rule of thumb is iirc that longer sleep times than a few hundred
> ms give dimishing returns in terms of power saving.

I think our pm guys measured this on OMAP3 and it translates to
~hour of idle mode. And yes, this is bad for devices which
run from battery.

> A simple way might be simple to batch the timer better with other timers.

I agree. There is a lot of work in this direction. There are many
places where we could use range hrtimers or deferrable timers
and improve PM. But I consider this to be the second level of
optimization. The first level is to get rid of unneeded events
completely.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	Jens Axboe <jens.axboe@oracle.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/18] periodic write-back timer optimization
Date: Thu, 09 Jul 2009 16:04:57 +0300	[thread overview]
Message-ID: <4A55EAF9.9070907@nokia.com> (raw)
In-Reply-To: <871voq6nh6.fsf@basil.nowhere.org>

Andi Kleen wrote:
> Artem Bityutskiy <Artem.Bityutskiy@nokia.com> writes:
> 
>> The patches attempt to optimize the periodic write-back and stop it when
>> there are no dirty data. IOW, we do not want the thread to wake up every
>> 5 seconds (by default), find there is nothing to do, and so on.
> 
> Is waking up every 5 seconds really a problem?

Yes, it is. In OMAP3 we may switch the core and most of peripherals
to off and we may stay in off and consume really few power. And waking
up from off every 5 seconds for no good reason is bad.

> The normal rule of thumb is iirc that longer sleep times than a few hundred
> ms give dimishing returns in terms of power saving.

I think our pm guys measured this on OMAP3 and it translates to
~hour of idle mode. And yes, this is bad for devices which
run from battery.

> A simple way might be simple to batch the timer better with other timers.

I agree. There is a lot of work in this direction. There are many
places where we could use range hrtimers or deferrable timers
and improve PM. But I consider this to be the second level of
optimization. The first level is to get rid of unneeded events
completely.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-07-09 13:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  8:48 [PATCH v3 00/18] periodic write-back timer optimization Artem Bityutskiy
2009-07-09  8:48 ` Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 01/18] VFS: introduce helpers for manipulation s_dirty flag Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 02/18] AFFS: do not manipulate s_dirt directly Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 03/18] BFS: " Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 04/18] EXOFS: " Artem Bityutskiy
2009-07-12  9:53   ` Boaz Harrosh
2009-07-12 14:02     ` Artem Bityutskiy
2009-07-12 14:02       ` Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 05/18] EXT2: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 06/18] EXT4: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 07/18] FAT: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 08/18] HFS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 09/18] HFSPLUS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 10/18] JFFS2: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 11/18] NILFS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 12/18] reiserfs: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 13/18] SYSV: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 14/18] UDF: " Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 15/18] UFS: " Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 16/18] VFS: use is_sb_dirty helper Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 17/18] rename s_dirt to s_dirty Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 18/18] writeback: optimize periodic sync_supers Artem Bityutskiy
2009-07-09 12:37 ` [PATCH v3 00/18] periodic write-back timer optimization Andi Kleen
2009-07-09 13:04   ` Artem Bityutskiy [this message]
2009-07-09 13:04     ` Artem Bityutskiy
2009-07-15  6:21 ` Artem Bityutskiy
2009-07-15  6:21   ` Artem Bityutskiy
2009-07-24 15:45   ` Artem Bityutskiy
2009-07-24 15:45     ` Artem Bityutskiy
2009-09-14 15:27     ` Artem Bityutskiy
2009-09-14 15:27       ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A55EAF9.9070907@nokia.com \
    --to=artem.bityutskiy@nokia.com \
    --cc=andi@firstfloor.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.