Re: [PATCH v3 04/18] EXOFS: do not manipulate s_dirt directly

[Boaz Harrosh <bharrosh@panasas.com>]

On 07/09/2009 11:48 AM, Artem Bityutskiy wrote:
> ... use new VFS helpers instead.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> Acked-by: Boaz Harrosh <bharrosh@panasas.com>

Hi Artem.

Linus has pulled the exofs tree for 2.6.31-rc3 if you sync
with it you'll find one more simple call site for is_sb_dirty(sb).
(See below)

Thanks
Boaz

---
git diff --stat -p fs/exofs/file.c
 fs/exofs/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/exofs/file.c b/fs/exofs/file.c
index 839b9dc..be38834 100644
--- a/fs/exofs/file.c
+++ b/fs/exofs/file.c
@@ -58,7 +58,7 @@ static int exofs_file_fsync(struct file *filp, struct dentry *dentry,
 	/* This is a good place to write the sb */
 	/* TODO: Sechedule an sb-sync on create */
 	sb = inode->i_sb;
-	if (sb->s_dirt)
+	if (is_sb_dirty(sb))
 		exofs_sync_fs(sb, 1);
 
 	return ret;