* ABI/API breakage
@ 2009-07-20 12:44 Christoph Egger
2009-07-20 14:15 ` Keir Fraser
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Egger @ 2009-07-20 12:44 UTC (permalink / raw)
To: xen-devel, dcm
Hi!
Changeset 19639 changed the ABI/API w/o taking care about backward
compatibility.
This breaks the xen build in upstream qemu in file hw/xen_domainbuild.c
FYI,
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ABI/API breakage
2009-07-20 12:44 ABI/API breakage Christoph Egger
@ 2009-07-20 14:15 ` Keir Fraser
2009-07-20 14:37 ` Christoph Egger
0 siblings, 1 reply; 5+ messages in thread
From: Keir Fraser @ 2009-07-20 14:15 UTC (permalink / raw)
To: Christoph Egger, xen-devel@lists.xensource.com, dcm@mccr.org
On 20/07/2009 13:44, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> Hi!
>
> Changeset 19639 changed the ABI/API w/o taking care about backward
> compatibility.
> This breaks the xen build in upstream qemu in file hw/xen_domainbuild.c
Is xc_linux_build() the only problematic function? That one could be
reverted easily enough. Actually superpages should really just get bunged in
'struct xc_dom_image' I think. Then the interface for all domain builder
functions reverts to what it was previously.
-- Keir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ABI/API breakage
2009-07-20 14:15 ` Keir Fraser
@ 2009-07-20 14:37 ` Christoph Egger
2009-07-20 14:49 ` Keir Fraser
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Egger @ 2009-07-20 14:37 UTC (permalink / raw)
To: Keir Fraser; +Cc: dcm@mccr.org, xen-devel@lists.xensource.com
On Monday 20 July 2009 16:15:31 Keir Fraser wrote:
> On 20/07/2009 13:44, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > Hi!
> >
> > Changeset 19639 changed the ABI/API w/o taking care about backward
> > compatibility.
> > This breaks the xen build in upstream qemu in file hw/xen_domainbuild.c
>
> Is xc_linux_build() the only problematic function? That one could be
> reverted easily enough. Actually superpages should really just get bunged
> in 'struct xc_dom_image' I think. Then the interface for all domain builder
> functions reverts to what it was previously.
For qemu, xc_linux_build() is the only one problematic function.
From the engineering point-of-view, your proposal to collapse superpages
into 'struct xc_dom_image' is the best solution.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ABI/API breakage
2009-07-20 14:37 ` Christoph Egger
@ 2009-07-20 14:49 ` Keir Fraser
2009-07-20 15:56 ` Christoph Egger
0 siblings, 1 reply; 5+ messages in thread
From: Keir Fraser @ 2009-07-20 14:49 UTC (permalink / raw)
To: Christoph Egger; +Cc: dcm@mccr.org, xen-devel@lists.xensource.com
On 20/07/2009 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>> Is xc_linux_build() the only problematic function? That one could be
>> reverted easily enough. Actually superpages should really just get bunged
>> in 'struct xc_dom_image' I think. Then the interface for all domain builder
>> functions reverts to what it was previously.
>
> For qemu, xc_linux_build() is the only one problematic function.
> From the engineering point-of-view, your proposal to collapse superpages
> into 'struct xc_dom_image' is the best solution.
Try changeset 19963.
-- Keir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ABI/API breakage
2009-07-20 14:49 ` Keir Fraser
@ 2009-07-20 15:56 ` Christoph Egger
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Egger @ 2009-07-20 15:56 UTC (permalink / raw)
To: xen-devel; +Cc: dcm@mccr.org, Keir Fraser
On Monday 20 July 2009 16:49:01 Keir Fraser wrote:
> On 20/07/2009 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> >> Is xc_linux_build() the only problematic function? That one could be
> >> reverted easily enough. Actually superpages should really just get
> >> bunged in 'struct xc_dom_image' I think. Then the interface for all
> >> domain builder functions reverts to what it was previously.
> >
> > For qemu, xc_linux_build() is the only one problematic function.
> > From the engineering point-of-view, your proposal to collapse superpages
> > into 'struct xc_dom_image' is the best solution.
>
> Try changeset 19963.
Confirmed. This unbreaks build of qemu. Tnx for fixing.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-07-20 15:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-20 12:44 ABI/API breakage Christoph Egger
2009-07-20 14:15 ` Keir Fraser
2009-07-20 14:37 ` Christoph Egger
2009-07-20 14:49 ` Keir Fraser
2009-07-20 15:56 ` Christoph Egger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.