From: Arnd Bergmann <arnd@arndb.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Fischer, Anna" <anna.fischer@hp.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Or Gerlitz <ogerlitz@voltaire.com>,
Edge Virtual Bridging <evb@yahoogroups.com>,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH] macvlan: add tap device backend
Date: Mon, 10 Aug 2009 20:43:32 +0200 [thread overview]
Message-ID: <200908102043.32937.arnd@arndb.de> (raw)
In-Reply-To: <4A7FC27F.1090904@trash.net>
On Monday 10 August 2009, Patrick McHardy wrote:
> macvlan will remove all macvlan/vtap devices when the underlying
> device in unregistered, at which time you need to release the
> device references you're holding. I'd suggest to change the
> macvlan_device_event() handler to use
>
> vlan->dev->rtnl_link_ops->dellink(vlan->dev)
>
> instead of macvlan_dellink() so the macvtap_dellink callback
> is invoked.
Ok, will do that. Thanks,
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <shemminger@linux-foundation.org>,
"" <davem@davemloft.net>, "Michael S. Tsirkin" <mst@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Or Gerlitz <ogerlitz@voltaire.com>,
"Fischer, Anna" <anna.fischer@hp.com>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Edge Virtual Bridging <evb@yahoogroups.com>
Subject: Re: [PATCH] macvlan: add tap device backend
Date: Mon, 10 Aug 2009 20:43:32 +0200 [thread overview]
Message-ID: <200908102043.32937.arnd@arndb.de> (raw)
In-Reply-To: <4A7FC27F.1090904@trash.net>
On Monday 10 August 2009, Patrick McHardy wrote:
> macvlan will remove all macvlan/vtap devices when the underlying
> device in unregistered, at which time you need to release the
> device references you're holding. I'd suggest to change the
> macvlan_device_event() handler to use
>
> vlan->dev->rtnl_link_ops->dellink(vlan->dev)
>
> instead of macvlan_dellink() so the macvtap_dellink callback
> is invoked.
Ok, will do that. Thanks,
Arnd <><
next prev parent reply other threads:[~2009-08-10 18:43 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 21:50 [Bridge] [PATCH] macvlan: add tap device backend Arnd Bergmann
2009-08-06 21:50 ` Arnd Bergmann
2009-08-07 3:20 ` [Bridge] " David Miller
2009-08-07 3:20 ` David Miller
2009-08-07 17:35 ` [Bridge] " Daniel Robbins
2009-08-07 17:35 ` Daniel Robbins
2009-08-09 8:02 ` Michael S. Tsirkin
2009-08-09 8:02 ` Michael S. Tsirkin
2009-08-09 20:42 ` [Bridge] " Arnd Bergmann
2009-08-09 20:42 ` Arnd Bergmann
2009-08-10 8:50 ` [Bridge] " Michael S. Tsirkin
2009-08-10 8:50 ` Michael S. Tsirkin
2009-08-10 13:29 ` [Bridge] " Arnd Bergmann
2009-08-10 13:29 ` Arnd Bergmann
2009-08-10 13:42 ` [Bridge] " Michael S. Tsirkin
2009-08-10 13:42 ` Michael S. Tsirkin
2009-08-10 6:47 ` [Bridge] " Patrick McHardy
2009-08-10 6:47 ` Patrick McHardy
2009-08-10 18:43 ` Arnd Bergmann [this message]
2009-08-10 18:43 ` Arnd Bergmann
[not found] <0199E0D51A61344794750DC57738F58E6D6A6CD7F6@GVW1118EXC.americas.hpqcorp.net>
2009-08-07 19:10 ` [Bridge] " Paul Congdon (UC Davis)
2009-08-07 19:10 ` Paul Congdon (UC Davis)
2009-08-07 19:10 ` Paul Congdon (UC Davis)
2009-08-07 19:35 ` Stephen Hemminger
2009-08-07 19:35 ` Stephen Hemminger
2009-08-07 19:44 ` Fischer, Anna
2009-08-07 19:44 ` Fischer, Anna
2009-08-07 20:17 ` david
2009-08-07 20:17 ` david
2009-08-07 19:47 ` Paul Congdon (UC Davis)
2009-08-07 19:47 ` Paul Congdon (UC Davis)
2009-08-07 21:38 ` Arnd Bergmann
2009-08-07 21:38 ` Arnd Bergmann
2009-08-07 22:05 ` Arnd Bergmann
2009-08-07 22:05 ` Arnd Bergmann
2009-08-10 12:40 ` Fischer, Anna
2009-08-10 12:40 ` Fischer, Anna
2009-08-10 12:40 ` Fischer, Anna
2009-08-10 19:04 ` Arnd Bergmann
2009-08-10 19:04 ` Arnd Bergmann
2009-08-10 19:32 ` Michael S. Tsirkin
2009-08-10 19:32 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908102043.32937.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=anna.fischer@hp.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=evb@yahoogroups.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.