[PATCH] Fix 'acpi' command loading tables from disk

[PATCH] Fix 'acpi' command loading tables from disk

[xose]

The 'acpi' command currently fails to add ACPI tables loaded from
disk. The files are read and parsed correctly, but the tables are
never actually added to the tables list.

The following patch fixes this bug:


diff --git a/commands/acpi.c b/commands/acpi.c
index d903d44..e7cb9e6 100644
--- a/commands/acpi.c
+++ b/commands/acpi.c
@@ -681,6 +681,9 @@ grub_cmd_acpi (struct grub_extcmd *cmd,
 	  table->size = size;
 	  table->addr = buf;
 	  playground_size += table->size;
+
+	  table->next = acpi_tables;
+	  acpi_tables = table;
 	}
     }


-xose

Re: [PATCH] Fix 'acpi' command loading tables from disk

[Robert Millan]

On Thu, Sep 10, 2009 at 02:21:14PM +0200, xose wrote:
> The 'acpi' command currently fails to add ACPI tables loaded from
> disk. The files are read and parsed correctly, but the tables are
> never actually added to the tables list.
> 
> The following patch fixes this bug:
> 
> 
> diff --git a/commands/acpi.c b/commands/acpi.c
> index d903d44..e7cb9e6 100644
> --- a/commands/acpi.c
> +++ b/commands/acpi.c
> @@ -681,6 +681,9 @@ grub_cmd_acpi (struct grub_extcmd *cmd,
>  	  table->size = size;
>  	  table->addr = buf;
>  	  playground_size += table->size;
> +
> +	  table->next = acpi_tables;
> +	  acpi_tables = table;
>  	}
>      }

According to Vladimir, this patch is fine.  Please, could you provide a
ChangeLog entry?  Then it can be committed.

Thanks

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Re: [PATCH] Fix 'acpi' command loading tables from disk

[xose]

On Sun, Sep 13, 2009 at 2:27 AM, Robert Millan <rmh@aybabtu.com> wrote:
> On Thu, Sep 10, 2009 at 02:21:14PM +0200, xose wrote:
>> The 'acpi' command currently fails to add ACPI tables loaded from
>> disk. The files are read and parsed correctly, but the tables are
>> never actually added to the tables list.
>>
>> The following patch fixes this bug:
>>
>>
>> diff --git a/commands/acpi.c b/commands/acpi.c
>> index d903d44..e7cb9e6 100644
>> --- a/commands/acpi.c
>> +++ b/commands/acpi.c
>> @@ -681,6 +681,9 @@ grub_cmd_acpi (struct grub_extcmd *cmd,
>>         table->size = size;
>>         table->addr = buf;
>>         playground_size += table->size;
>> +
>> +       table->next = acpi_tables;
>> +       acpi_tables = table;
>>       }
>>      }
>
> According to Vladimir, this patch is fine.  Please, could you provide a
> ChangeLog entry?  Then it can be committed.

Sure, I forgot it the first time, sorry about that.


2009-09-13  José Martínez  <xosemp@gmail.com>

	* commands/acpi.c (grub_cmd_acpi): Fix loading ACPI tables from file.



> Thanks
>
> --
> Robert Millan
>
>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>  how) you may access your data; but nobody's threatening your freedom: we
>  still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: [PATCH] Fix 'acpi' command loading tables from disk

[Robert Millan]

On Sun, Sep 13, 2009 at 03:22:41AM +0200, xose wrote:
> On Sun, Sep 13, 2009 at 2:27 AM, Robert Millan <rmh@aybabtu.com> wrote:
> > On Thu, Sep 10, 2009 at 02:21:14PM +0200, xose wrote:
> >> The 'acpi' command currently fails to add ACPI tables loaded from
> >> disk. The files are read and parsed correctly, but the tables are
> >> never actually added to the tables list.
> >>
> >> The following patch fixes this bug:
> >>
> >>
> >> diff --git a/commands/acpi.c b/commands/acpi.c
> >> index d903d44..e7cb9e6 100644
> >> --- a/commands/acpi.c
> >> +++ b/commands/acpi.c
> >> @@ -681,6 +681,9 @@ grub_cmd_acpi (struct grub_extcmd *cmd,
> >>         table->size = size;
> >>         table->addr = buf;
> >>         playground_size += table->size;
> >> +
> >> +       table->next = acpi_tables;
> >> +       acpi_tables = table;
> >>       }
> >>      }
> >
> > According to Vladimir, this patch is fine.  Please, could you provide a
> > ChangeLog entry?  Then it can be committed.
> 
> Sure, I forgot it the first time, sorry about that.
> 
> 
> 2009-09-13  José Martínez  <xosemp@gmail.com>
> 
> 	* commands/acpi.c (grub_cmd_acpi): Fix loading ACPI tables from file.

I checked this in.  Btw, in the future please include patches as plain text
attachments.

Thanks!

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."