* [PATCH] Fix a bug in function create in kvm_vm @ 2009-09-28 7:45 Yolkfull Chow 2009-10-05 19:03 ` [Autotest] " Lucas Meneghel Rodrigues 0 siblings, 1 reply; 6+ messages in thread From: Yolkfull Chow @ 2009-09-28 7:45 UTC (permalink / raw) To: kvm; +Cc: autotest, Yolkfull Chow Signed-off-by: Yolkfull Chow <yzhou@redhat.com> --- client/tests/kvm/kvm_vm.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 55220f9..8aeffff 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@ -406,7 +406,7 @@ class VM: self.process.get_output())) return False - logging.debug("VM appears to be alive with PID %d", + logging.debug("VM appears to be alive with PID %d" % self.process.get_pid()) return True -- 1.6.2.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm 2009-09-28 7:45 [PATCH] Fix a bug in function create in kvm_vm Yolkfull Chow @ 2009-10-05 19:03 ` Lucas Meneghel Rodrigues 2009-10-10 8:24 ` Yolkfull Chow 0 siblings, 1 reply; 6+ messages in thread From: Lucas Meneghel Rodrigues @ 2009-10-05 19:03 UTC (permalink / raw) To: Yolkfull Chow; +Cc: kvm, autotest Hi Yolkfull! I've checked your patch, but it turns out that the comma is valid syntax for the logging module. By any chance you actually had an error with it? On Mon, Sep 28, 2009 at 4:45 AM, Yolkfull Chow <yzhou@redhat.com> wrote: > > Signed-off-by: Yolkfull Chow <yzhou@redhat.com> > --- > client/tests/kvm/kvm_vm.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py > index 55220f9..8aeffff 100755 > --- a/client/tests/kvm/kvm_vm.py > +++ b/client/tests/kvm/kvm_vm.py > @@ -406,7 +406,7 @@ class VM: > self.process.get_output())) > return False > > - logging.debug("VM appears to be alive with PID %d", > + logging.debug("VM appears to be alive with PID %d" % > self.process.get_pid()) > return True > > -- > 1.6.2.5 > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > -- Lucas ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm 2009-10-05 19:03 ` [Autotest] " Lucas Meneghel Rodrigues @ 2009-10-10 8:24 ` Yolkfull Chow 2009-10-10 8:48 ` Yolkfull Chow 0 siblings, 1 reply; 6+ messages in thread From: Yolkfull Chow @ 2009-10-10 8:24 UTC (permalink / raw) To: Lucas Meneghel Rodrigues; +Cc: kvm, autotest On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: > Hi Yolkfull! I've checked your patch, but it turns out that the comma > is valid syntax for the logging module. By any chance you actually had > an error with it? Hi Lucas, I just checked, yes it's valid syntax for this module. Before this I met a traceback during running autotest and it indicated this line around,thus I doubt about this by mistake. Sorry for confusing. ;-) But I found for the variables in logging.debug(),sometimes it use comma to format while sometimes '%' which will drop code readability. Anyway, thanks for checking. > > On Mon, Sep 28, 2009 at 4:45 AM, Yolkfull Chow <yzhou@redhat.com> wrote: > > > > Signed-off-by: Yolkfull Chow <yzhou@redhat.com> > > --- > > client/tests/kvm/kvm_vm.py | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py > > index 55220f9..8aeffff 100755 > > --- a/client/tests/kvm/kvm_vm.py > > +++ b/client/tests/kvm/kvm_vm.py > > @@ -406,7 +406,7 @@ class VM: > > self.process.get_output())) > > return False > > > > - logging.debug("VM appears to be alive with PID %d", > > + logging.debug("VM appears to be alive with PID %d" % > > self.process.get_pid()) > > return True > > > > -- > > 1.6.2.5 > > > > _______________________________________________ > > Autotest mailing list > > Autotest@test.kernel.org > > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > > > > > -- > Lucas > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm 2009-10-10 8:24 ` Yolkfull Chow @ 2009-10-10 8:48 ` Yolkfull Chow 2009-10-11 23:53 ` Lucas Meneghel Rodrigues 0 siblings, 1 reply; 6+ messages in thread From: Yolkfull Chow @ 2009-10-10 8:48 UTC (permalink / raw) To: Lucas Meneghel Rodrigues; +Cc: kvm, autotest On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: > > Hi Yolkfull! I've checked your patch, but it turns out that the comma > > is valid syntax for the logging module. By any chance you actually had > > an error with it? > > Hi Lucas, > I just checked, yes it's valid syntax for this module. Before this I met > a traceback during running autotest and it indicated this line > around,thus I doubt about this by mistake. Sorry for confusing. ;-) > > But I found for the variables in logging.debug(),sometimes it use comma > to format while sometimes '%' which will drop code readability. Another reason is if someone who still using kvm_log want to backport codes from this tree, not only need he replace all 'logging' with 'kvm_log' but also need change these comma syntax. ;-) > > Anyway, thanks for checking. > > > > > On Mon, Sep 28, 2009 at 4:45 AM, Yolkfull Chow <yzhou@redhat.com> wrote: > > > > > > Signed-off-by: Yolkfull Chow <yzhou@redhat.com> > > > --- > > > client/tests/kvm/kvm_vm.py | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py > > > index 55220f9..8aeffff 100755 > > > --- a/client/tests/kvm/kvm_vm.py > > > +++ b/client/tests/kvm/kvm_vm.py > > > @@ -406,7 +406,7 @@ class VM: > > > self.process.get_output())) > > > return False > > > > > > - logging.debug("VM appears to be alive with PID %d", > > > + logging.debug("VM appears to be alive with PID %d" % > > > self.process.get_pid()) > > > return True > > > > > > -- > > > 1.6.2.5 > > > > > > _______________________________________________ > > > Autotest mailing list > > > Autotest@test.kernel.org > > > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > > > > > > > > > > -- > > Lucas > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm 2009-10-10 8:48 ` Yolkfull Chow @ 2009-10-11 23:53 ` Lucas Meneghel Rodrigues 2009-10-12 6:58 ` Yolkfull Chow 0 siblings, 1 reply; 6+ messages in thread From: Lucas Meneghel Rodrigues @ 2009-10-11 23:53 UTC (permalink / raw) To: Yolkfull Chow; +Cc: kvm, autotest On Sat, 2009-10-10 at 16:48 +0800, Yolkfull Chow wrote: > On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: > > > Hi Yolkfull! I've checked your patch, but it turns out that the comma > > > is valid syntax for the logging module. By any chance you actually had > > > an error with it? > > > > Hi Lucas, > > I just checked, yes it's valid syntax for this module. Before this I met > > a traceback during running autotest and it indicated this line > > around,thus I doubt about this by mistake. Sorry for confusing. ;-) > > > > But I found for the variables in logging.debug(),sometimes it use comma > > to format while sometimes '%' which will drop code readability. > > Another reason is if someone who still using kvm_log want to backport > codes from this tree, not only need he replace all 'logging' with > 'kvm_log' but also need change these comma syntax. ;-) Yes, we prefer using comma on logging statements allways, but sometimes we make mistakes and use the standard string format with %. When porting code, try to keep in mind that and try to use allways the comma, but don't worry too much about it... just general guidelines :) Lucas ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm 2009-10-11 23:53 ` Lucas Meneghel Rodrigues @ 2009-10-12 6:58 ` Yolkfull Chow 0 siblings, 0 replies; 6+ messages in thread From: Yolkfull Chow @ 2009-10-12 6:58 UTC (permalink / raw) To: Lucas Meneghel Rodrigues; +Cc: kvm, autotest On Sun, Oct 11, 2009 at 08:53:05PM -0300, Lucas Meneghel Rodrigues wrote: > On Sat, 2009-10-10 at 16:48 +0800, Yolkfull Chow wrote: > > On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > > > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: > > > > Hi Yolkfull! I've checked your patch, but it turns out that the comma > > > > is valid syntax for the logging module. By any chance you actually had > > > > an error with it? > > > > > > Hi Lucas, > > > I just checked, yes it's valid syntax for this module. Before this I met > > > a traceback during running autotest and it indicated this line > > > around,thus I doubt about this by mistake. Sorry for confusing. ;-) > > > > > > But I found for the variables in logging.debug(),sometimes it use comma > > > to format while sometimes '%' which will drop code readability. > > > > Another reason is if someone who still using kvm_log want to backport > > codes from this tree, not only need he replace all 'logging' with > > 'kvm_log' but also need change these comma syntax. ;-) > > Yes, we prefer using comma on logging statements allways, but sometimes > we make mistakes and use the standard string format with %. > > When porting code, try to keep in mind that and try to use allways the > comma, but don't worry too much about it... just general guidelines :) Ok, that could be the style. Thanks very much for remind. :) Cheers, > > Lucas > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-10-12 6:58 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-09-28 7:45 [PATCH] Fix a bug in function create in kvm_vm Yolkfull Chow 2009-10-05 19:03 ` [Autotest] " Lucas Meneghel Rodrigues 2009-10-10 8:24 ` Yolkfull Chow 2009-10-10 8:48 ` Yolkfull Chow 2009-10-11 23:53 ` Lucas Meneghel Rodrigues 2009-10-12 6:58 ` Yolkfull Chow
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.