* Re: [Patch 3/7] tabled: add the status display [not found] <20100114211216.53d51c13@redhat.com> @ 2010-01-20 19:51 ` Jeff Garzik 2010-01-20 20:19 ` Pete Zaitcev 0 siblings, 1 reply; 3+ messages in thread From: Jeff Garzik @ 2010-01-20 19:51 UTC (permalink / raw) To: Pete Zaitcev; +Cc: Project Hail List On 01/14/2010 11:12 PM, Pete Zaitcev wrote: > I find it too tiresome to monitor the status with kill -USR1. > This is more fun. The patch seems not too ugly regarding the factoring > of the cli_xxx methods. > > Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com> > > --- > doc/etc.tabled.conf | 3 > server/Makefile.am | 4 > server/config.c | 19 +++ > server/replica.c | 64 +++++++++++- > server/server.c | 104 +++++++++++++------- > server/status.c | 218 ++++++++++++++++++++++++++++++++++++++++++ > server/tabled.h | 12 +- > 7 files changed, 379 insertions(+), 45 deletions(-) applied... but we need some way to either turn this off, or limit to a list of incoming IP addresses. This is an admin interface, which should not be automatically available to all end-user applications. Jeff ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 3/7] tabled: add the status display 2010-01-20 19:51 ` [Patch 3/7] tabled: add the status display Jeff Garzik @ 2010-01-20 20:19 ` Pete Zaitcev 2010-01-20 21:49 ` Jeff Garzik 0 siblings, 1 reply; 3+ messages in thread From: Pete Zaitcev @ 2010-01-20 20:19 UTC (permalink / raw) To: Jeff Garzik; +Cc: Project Hail List On Wed, 20 Jan 2010 14:51:59 -0500 Jeff Garzik <jeff@garzik.org> wrote: > On 01/14/2010 11:12 PM, Pete Zaitcev wrote: > > I find it too tiresome to monitor the status with kill -USR1. > > This is more fun. The patch seems not too ugly regarding the factoring > > of the cli_xxx methods. > > > > Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com> > > > > --- > > doc/etc.tabled.conf | 3 > > server/Makefile.am | 4 > > server/config.c | 19 +++ > > server/replica.c | 64 +++++++++++- > > server/server.c | 104 +++++++++++++------- > > server/status.c | 218 ++++++++++++++++++++++++++++++++++++++++++ > > server/tabled.h | 12 +- > > 7 files changed, 379 insertions(+), 45 deletions(-) > > applied... but we need some way to either turn this off, or limit to a > list of incoming IP addresses. This is an admin interface, which should > not be automatically available to all end-user applications. I thought it was obvious that StatusPort defaults to off (zero). if (tabled_srv.status_port) net_open_known(tabled_srv.status_port, true); -- Pete ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 3/7] tabled: add the status display 2010-01-20 20:19 ` Pete Zaitcev @ 2010-01-20 21:49 ` Jeff Garzik 0 siblings, 0 replies; 3+ messages in thread From: Jeff Garzik @ 2010-01-20 21:49 UTC (permalink / raw) To: Pete Zaitcev; +Cc: Project Hail List On 01/20/2010 03:19 PM, Pete Zaitcev wrote: > On Wed, 20 Jan 2010 14:51:59 -0500 > Jeff Garzik<jeff@garzik.org> wrote: > >> On 01/14/2010 11:12 PM, Pete Zaitcev wrote: >>> I find it too tiresome to monitor the status with kill -USR1. >>> This is more fun. The patch seems not too ugly regarding the factoring >>> of the cli_xxx methods. >>> >>> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com> >>> >>> --- >>> doc/etc.tabled.conf | 3 >>> server/Makefile.am | 4 >>> server/config.c | 19 +++ >>> server/replica.c | 64 +++++++++++- >>> server/server.c | 104 +++++++++++++------- >>> server/status.c | 218 ++++++++++++++++++++++++++++++++++++++++++ >>> server/tabled.h | 12 +- >>> 7 files changed, 379 insertions(+), 45 deletions(-) >> >> applied... but we need some way to either turn this off, or limit to a >> list of incoming IP addresses. This is an admin interface, which should >> not be automatically available to all end-user applications. > > I thought it was obvious that StatusPort defaults to off (zero). > > if (tabled_srv.status_port) > net_open_known(tabled_srv.status_port, true); I missed that detail. That works. Though eventually I hope someone will create a patch for filtering incoming connections via IP address. Not an issue that needs attention pre-1.0 unless a volunteer appears, though. Jeff ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-20 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100114211216.53d51c13@redhat.com>
2010-01-20 19:51 ` [Patch 3/7] tabled: add the status display Jeff Garzik
2010-01-20 20:19 ` Pete Zaitcev
2010-01-20 21:49 ` Jeff Garzik
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.