Re: [RFC PATCH] introduce sys_membarrier(): process-wide memory barrier (v5)

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Steven Rostedt (rostedt@goodmis.org) wrote:
> On Thu, 2010-01-21 at 11:22 -0500, Mathieu Desnoyers wrote:
> > * Steven Rostedt (rostedt@goodmis.org) wrote:
> 
> > > You may also need spin_lock_irqsave, et al. variants too.
> > 
> > Yep, or we simply use the local_irq_save/restore separately. That could
> > be a good idea given that only few specialized sites are affected.
> 
> If it gets used more often, then we need to consider RT. RT modifies
> spin_lock_irqsave into a standard mutex that does not disable
> interrupts. But if something does:
> 
> 	local_irq_save(flags);
> 	spin_lock_mb(&lock);
> 	[...]
> 
> Then it will break RT (if lock is to be converted).

Good point !

Mathieu

> 
> -- Steve
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68