From: David Brownell <david-b@pacbell.net>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Bill Gatliff <bgat@billgatliff.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier
Date: Mon, 25 Jan 2010 22:34:29 -0800 [thread overview]
Message-ID: <201001252234.30169.david-b@pacbell.net> (raw)
In-Reply-To: <20100125181100.GA13805@oksana.dev.rtsoft.ru>
On Monday 25 January 2010, Anton Vorontsov wrote:
>
> +config GPIOLIB_NOTIFIER
> + bool
> + help
> + This symbol is selected by subsystems that need to handle GPIO
> + chips addition and removal. E.g., this is used for the
> + OpenFirmware bindings.
> +
I'm no huge fan of notifiers, but I suppose they have their place.
However ... I don't see a lot of win to making this optional. Just
inline the little two blocking_notifier_call_chain() calls directly,
making this a *LOT* simpler.
- Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
David Brownell <dbrownell@users.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
Bill Gatliff <bgat@billgatliff.com>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier
Date: Mon, 25 Jan 2010 22:34:29 -0800 [thread overview]
Message-ID: <201001252234.30169.david-b@pacbell.net> (raw)
In-Reply-To: <20100125181100.GA13805@oksana.dev.rtsoft.ru>
On Monday 25 January 2010, Anton Vorontsov wrote:
>
> +config GPIOLIB_NOTIFIER
> + bool
> + help
> + This symbol is selected by subsystems that need to handle GPIO
> + chips addition and removal. E.g., this is used for the
> + OpenFirmware bindings.
> +
I'm no huge fan of notifiers, but I suppose they have their place.
However ... I don't see a lot of win to making this optional. Just
inline the little two blocking_notifier_call_chain() calls directly,
making this a *LOT* simpler.
- Dave
next prev parent reply other threads:[~2010-01-26 6:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 18:09 [PATCH 0/4] OF GPIO integration for I2C/SPI GPIO chips Anton Vorontsov
2010-01-25 18:09 ` Anton Vorontsov
2010-01-25 18:11 ` [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier Anton Vorontsov
2010-01-25 18:11 ` Anton Vorontsov
2010-01-26 6:34 ` David Brownell [this message]
2010-01-26 6:34 ` David Brownell
2010-01-26 17:28 ` Anton Vorontsov
2010-01-26 17:28 ` Anton Vorontsov
2010-01-26 21:01 ` David Brownell
2010-01-26 21:01 ` David Brownell
2010-01-25 18:11 ` [PATCH 2/4] of/gpio: Add support for two-stage registration for the of_gpio_chips Anton Vorontsov
2010-01-25 18:11 ` Anton Vorontsov
2010-01-26 6:36 ` David Brownell
2010-01-26 6:36 ` David Brownell
2010-01-26 17:43 ` Anton Vorontsov
2010-01-26 17:43 ` Anton Vorontsov
2010-01-26 21:02 ` David Brownell
2010-01-26 21:02 ` David Brownell
2010-01-25 18:11 ` [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks Anton Vorontsov
2010-01-25 18:11 ` Anton Vorontsov
2010-01-25 18:11 ` [PATCH 4/4] powerpc/mcu_mpc8349emitx: Remove OF GPIO handling stuff Anton Vorontsov
2010-01-25 18:11 ` Anton Vorontsov
2010-01-26 6:43 ` David Brownell
2010-01-26 6:43 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2010-02-05 20:32 [PATCH v2 0/4] OF GPIO integration for I2C/SPI GPIO chips Anton Vorontsov
2010-02-05 20:32 ` [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier Anton Vorontsov
2010-02-05 20:32 ` Anton Vorontsov
2010-02-09 17:16 ` Grant Likely
2010-02-09 17:16 ` Grant Likely
2010-03-05 19:59 ` Andrew Morton
2010-03-05 19:59 ` Andrew Morton
2010-03-05 20:30 ` Anton Vorontsov
2010-03-05 20:30 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001252234.30169.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=bgat@billgatliff.com \
--cc=dbaryshkov@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.