From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Bill Gatliff <bgat@billgatliff.com>
Subject: Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier
Date: Fri, 5 Mar 2010 23:30:24 +0300 [thread overview]
Message-ID: <20100305203024.GA28132@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100305115918.f6c75b12.akpm@linux-foundation.org>
On Fri, Mar 05, 2010 at 11:59:18AM -0800, Andrew Morton wrote:
[...]
> > > /**
> > > * gpiochip_add() - register a gpio_chip
> > > * @chip: the chip to register, with chip->base initialized
> > > @@ -1103,6 +1107,9 @@ fail:
> > > pr_err("gpiochip_add: gpios %d..%d (%s) not registered\n",
> > > chip->base, chip->base + chip->ngpio - 1,
> > > chip->label ? : "generic");
> > > + else
> > > + blocking_notifier_call_chain(&gpio_notifier,
> > > + GPIO_NOTIFY_CHIP_ADDED, chip);
> >
> > Rather than doing an else block which will need to be reworked if/when
> > any additional code is added to the bottom of this routine, please
> > rework the if() block to bail on failure instead of implicitly falling
> > through to the return statement.
>
> This still hasn't happened.
It's in your tree already :-)
gpiolib-cosmetic-improvements-for-error-handling-in-gpiochip_add.patch
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
David Brownell <dbrownell@users.sourceforge.net>,
Bill Gatliff <bgat@billgatliff.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier
Date: Fri, 5 Mar 2010 23:30:24 +0300 [thread overview]
Message-ID: <20100305203024.GA28132@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100305115918.f6c75b12.akpm@linux-foundation.org>
On Fri, Mar 05, 2010 at 11:59:18AM -0800, Andrew Morton wrote:
[...]
> > > /**
> > > * gpiochip_add() - register a gpio_chip
> > > * @chip: the chip to register, with chip->base initialized
> > > @@ -1103,6 +1107,9 @@ fail:
> > > pr_err("gpiochip_add: gpios %d..%d (%s) not registered\n",
> > > chip->base, chip->base + chip->ngpio - 1,
> > > chip->label ? : "generic");
> > > + else
> > > + blocking_notifier_call_chain(&gpio_notifier,
> > > + GPIO_NOTIFY_CHIP_ADDED, chip);
> >
> > Rather than doing an else block which will need to be reworked if/when
> > any additional code is added to the bottom of this routine, please
> > rework the if() block to bail on failure instead of implicitly falling
> > through to the return statement.
>
> This still hasn't happened.
It's in your tree already :-)
gpiolib-cosmetic-improvements-for-error-handling-in-gpiochip_add.patch
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-03-05 20:30 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 20:32 [PATCH v2 0/4] OF GPIO integration for I2C/SPI GPIO chips Anton Vorontsov
2010-02-05 20:32 ` Anton Vorontsov
2010-02-05 20:32 ` [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier Anton Vorontsov
2010-02-05 20:32 ` Anton Vorontsov
2010-02-09 17:16 ` Grant Likely
2010-02-09 17:16 ` Grant Likely
2010-03-05 19:59 ` Andrew Morton
2010-03-05 19:59 ` Andrew Morton
2010-03-05 20:30 ` Anton Vorontsov [this message]
2010-03-05 20:30 ` Anton Vorontsov
2010-02-05 20:32 ` [PATCH 2/4] of/gpio: Add support for two-stage registration for the of_gpio_chips Anton Vorontsov
2010-02-05 20:32 ` Anton Vorontsov
2010-02-05 20:32 ` [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks Anton Vorontsov
2010-02-05 20:32 ` Anton Vorontsov
2010-02-08 21:02 ` Andrew Morton
2010-02-08 21:02 ` Andrew Morton
2010-02-09 17:08 ` Grant Likely
2010-02-09 17:08 ` Grant Likely
2010-02-09 19:06 ` Anton Vorontsov
2010-02-09 19:06 ` Anton Vorontsov
2010-02-09 17:13 ` Grant Likely
2010-02-09 17:13 ` Grant Likely
2010-02-09 19:16 ` Anton Vorontsov
2010-02-09 19:16 ` Anton Vorontsov
[not found] ` <20100305120015.a2008f46.akpm@linux-foundation.org>
[not found] ` <fa686aa41003051228w38579483yd4e95bb8eacf40f7@mail.gmail.com>
[not found] ` <20100305123527.d6d68e56.akpm@linux-foundation.org>
2010-03-05 23:47 ` Grant Likely
2010-03-05 23:47 ` Grant Likely
2010-03-06 0:28 ` Anton Vorontsov
2010-03-06 0:28 ` Anton Vorontsov
2010-03-06 3:54 ` Grant Likely
2010-03-06 3:54 ` Grant Likely
2010-03-06 5:05 ` Anton Vorontsov
2010-03-06 5:05 ` Anton Vorontsov
2010-03-06 16:43 ` Grant Likely
2010-03-06 16:43 ` Grant Likely
2010-03-07 1:47 ` Anton Vorontsov
2010-03-07 1:47 ` Anton Vorontsov
2010-03-07 6:11 ` Grant Likely
2010-03-07 6:11 ` Grant Likely
2010-03-12 21:07 ` Andrew Morton
2010-03-12 21:07 ` Andrew Morton
2010-03-12 21:38 ` Grant Likely
2010-03-12 21:38 ` Grant Likely
2010-04-30 17:45 ` Anton Vorontsov
2010-04-30 17:45 ` Anton Vorontsov
2010-02-05 20:32 ` [PATCH 4/4] powerpc/mcu_mpc8349emitx: Remove OF GPIO handling stuff Anton Vorontsov
2010-02-05 20:32 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2010-01-25 18:09 [PATCH 0/4] OF GPIO integration for I2C/SPI GPIO chips Anton Vorontsov
2010-01-25 18:11 ` [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier Anton Vorontsov
2010-01-25 18:11 ` Anton Vorontsov
2010-01-26 6:34 ` David Brownell
2010-01-26 6:34 ` David Brownell
2010-01-26 17:28 ` Anton Vorontsov
2010-01-26 17:28 ` Anton Vorontsov
2010-01-26 21:01 ` David Brownell
2010-01-26 21:01 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305203024.GA28132@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=akpm@linux-foundation.org \
--cc=bgat@billgatliff.com \
--cc=dbaryshkov@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.