* [PATCH] xen: fbdev frontend needs xenbus frontend
@ 2010-02-24 13:58 Bastian Blank
2010-02-25 12:40 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 5+ messages in thread
From: Bastian Blank @ 2010-02-24 13:58 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: xen-devel
The fbdev (and kbddev) frontend needs the xenbus frontend, but does not
define a dependency. Make the fbdev frontend select the xenbus
frontend.
Signed-off-by: Bastian Blank <waldi@debian.org>
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 188e1ba..efac9e3 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2063,6 +2063,7 @@ config XEN_FBDEV_FRONTEND
select FB_SYS_IMAGEBLIT
select FB_SYS_FOPS
select FB_DEFERRED_IO
+ select XEN_XENBUS_FRONTEND
default y
help
This driver implements the front-end of the Xen virtual
--
No more blah, blah, blah!
-- Kirk, "Miri", stardate 2713.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: fbdev frontend needs xenbus frontend
2010-02-24 13:58 [PATCH] xen: fbdev frontend needs xenbus frontend Bastian Blank
@ 2010-02-25 12:40 ` Konrad Rzeszutek Wilk
2010-02-25 17:37 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2010-02-25 12:40 UTC (permalink / raw)
To: Bastian Blank; +Cc: Jeremy Fitzhardinge, xen-devel
On Wed, Feb 24, 2010 at 02:58:28PM +0100, Bastian Blank wrote:
> The fbdev (and kbddev) frontend needs the xenbus frontend, but does not
> define a dependency. Make the fbdev frontend select the xenbus
> frontend.
Isn't this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so
(and if the above mention commit isn't in xen/next)
shouldn't you also make this change for drives/input/Kconfig for
XEN_KBDDEV_FRONTEND?
>
> Signed-off-by: Bastian Blank <waldi@debian.org>
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 188e1ba..efac9e3 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -2063,6 +2063,7 @@ config XEN_FBDEV_FRONTEND
> select FB_SYS_IMAGEBLIT
> select FB_SYS_FOPS
> select FB_DEFERRED_IO
> + select XEN_XENBUS_FRONTEND
> default y
> help
> This driver implements the front-end of the Xen virtual
> --
> No more blah, blah, blah!
> -- Kirk, "Miri", stardate 2713.6
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: fbdev frontend needs xenbus frontend
2010-02-25 12:40 ` Konrad Rzeszutek Wilk
@ 2010-02-25 17:37 ` Jeremy Fitzhardinge
2010-02-25 17:48 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2010-02-25 17:37 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Bastian Blank, xen-devel
On 02/25/2010 04:40 AM, Konrad Rzeszutek Wilk wrote:
> On Wed, Feb 24, 2010 at 02:58:28PM +0100, Bastian Blank wrote:
>
>> The fbdev (and kbddev) frontend needs the xenbus frontend, but does not
>> define a dependency. Make the fbdev frontend select the xenbus
>> frontend.
>>
> Isn't this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so
> (and if the above mention commit isn't in xen/next)
> shouldn't you also make this change for drives/input/Kconfig for
> XEN_KBDDEV_FRONTEND?
>
Did that end up in .33? Should we put it in -stable too?
J
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] xen: fbdev frontend needs xenbus frontend
2010-02-25 17:37 ` Jeremy Fitzhardinge
@ 2010-02-25 17:48 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2010-02-25 17:48 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Bastian Blank, xen-devel
On Thu, Feb 25, 2010 at 09:37:38AM -0800, Jeremy Fitzhardinge wrote:
> On 02/25/2010 04:40 AM, Konrad Rzeszutek Wilk wrote:
>> On Wed, Feb 24, 2010 at 02:58:28PM +0100, Bastian Blank wrote:
>>
>>> The fbdev (and kbddev) frontend needs the xenbus frontend, but does not
>>> define a dependency. Make the fbdev frontend select the xenbus
>>> frontend.
>>>
>> Isn't this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so
>> (and if the above mention commit isn't in xen/next)
>> shouldn't you also make this change for drives/input/Kconfig for
>> XEN_KBDDEV_FRONTEND?
>>
>
> Did that end up in .33? Should we put it in -stable too?
I took a look at the code and I think Bastian's is OK. The -stable
has this:
152 config XEN_KBDDEV_FRONTEND
153 tristate "Xen virtual keyboard and mouse support"
154 depends on XEN_FBDEV_FRONTEND
155 default y
So it would end up selecting the xenbus frontend as well with Bastian's
patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] xen: Disable stack protector for irq helper
@ 2009-10-04 18:30 Bastian Blank
2009-10-04 23:06 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 5+ messages in thread
From: Bastian Blank @ 2009-10-04 18:30 UTC (permalink / raw)
To: Ingo Molnar
Cc: Jeremy Fitzhardinge, the arch/x86 maintainers, Stable Kernel,
Linux Kernel Mailing List, Xen-devel
The stack protector needs additional registers on x86_32, which are not
saved in calls to the small paravirt interrupt handlers. This leads to
early crashes as registers are overwritten and not saved by the caller
as instructed.
Signed-off-by: Bastian Blank <waldi@debian.org>
diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 3bb4fc2..ac19398 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -5,9 +5,9 @@
CFLAGS_REMOVE_irq.o = -pg
endif
-# Make sure early boot has no stackprotector
nostackp := $(call cc-option, -fno-stack-protector)
CFLAGS_enlighten.o := $(nostackp)
+CFLAGS_irq.o := $(nostackp)
CFLAGS_mmu.o := $(nostackp)
obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \
--
Mind your own business, Spock. I'm sick of your halfbreed interference.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: Disable stack protector for irq helper
2009-10-04 18:30 [PATCH] xen: Disable stack protector for irq helper Bastian Blank
@ 2009-10-04 23:06 ` Jeremy Fitzhardinge
2009-10-05 1:52 ` [PATCH] xen: fbdev frontend needs xenbus frontend Bastian Blank
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2009-10-04 23:06 UTC (permalink / raw)
To: Bastian Blank, Ingo Molnar, the arch/x86 maintainers,
Stable Kernel, Linux Kernel Mailing List, Xen-devel
On 10/04/09 11:30, Bastian Blank wrote:
> The stack protector needs additional registers on x86_32, which are not
> saved in calls to the small paravirt interrupt handlers. This leads to
> early crashes as registers are overwritten and not saved by the caller
> as instructed.
>
Thanks for the patch, but I don't think its quite right.
PV_CALLEE_SAVE_REGS_THUNK() is responsible for generating a wrapper for
the functions to save/restore all the appropriate registers. If it is
failing to do so, then the correct fix is to update
PV_SAVE/RESTORE_ALL_CALLER_REGS.
Or have I misunderstood you analysis?
Thanks,
J
> Signed-off-by: Bastian Blank <waldi@debian.org>
>
> diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
> index 3bb4fc2..ac19398 100644
> --- a/arch/x86/xen/Makefile
> +++ b/arch/x86/xen/Makefile
> @@ -5,9 +5,9 @@
> CFLAGS_REMOVE_irq.o = -pg
> endif
>
> -# Make sure early boot has no stackprotector
> nostackp := $(call cc-option, -fno-stack-protector)
> CFLAGS_enlighten.o := $(nostackp)
> +CFLAGS_irq.o := $(nostackp)
> CFLAGS_mmu.o := $(nostackp)
>
> obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] xen: fbdev frontend needs xenbus frontend
2009-10-04 23:06 ` Jeremy Fitzhardinge
@ 2009-10-05 1:52 ` Bastian Blank
0 siblings, 0 replies; 5+ messages in thread
From: Bastian Blank @ 2009-10-05 1:52 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: xen-devel
Make the fbdev frontend select the xenbus frontend.
Signed-off-by: Bastian Blank <waldi@debian.org>
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 3b54b39..1b332d1 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2070,6 +2070,7 @@ config XEN_FBDEV_FRONTEND
select FB_SYS_IMAGEBLIT
select FB_SYS_FOPS
select FB_DEFERRED_IO
+ select XEN_XENBUS_FRONTEND
default y
help
This driver implements the front-end of the Xen virtual
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-25 17:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-24 13:58 [PATCH] xen: fbdev frontend needs xenbus frontend Bastian Blank
2010-02-25 12:40 ` Konrad Rzeszutek Wilk
2010-02-25 17:37 ` Jeremy Fitzhardinge
2010-02-25 17:48 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2009-10-04 18:30 [PATCH] xen: Disable stack protector for irq helper Bastian Blank
2009-10-04 23:06 ` Jeremy Fitzhardinge
2009-10-05 1:52 ` [PATCH] xen: fbdev frontend needs xenbus frontend Bastian Blank
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.