All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
	Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFS: Fix RCU warnings in nfs_inode_return_delegation_noreclaim() [ver #2]
Date: Tue, 30 Mar 2010 10:25:42 -0700	[thread overview]
Message-ID: <20100330172542.GI2513@linux.vnet.ibm.com> (raw)
In-Reply-To: <1269968671.10116.17.camel@edumazet-laptop>

On Tue, Mar 30, 2010 at 07:04:31PM +0200, Eric Dumazet wrote:
> Le mardi 30 mars 2010 =E0 09:49 -0700, Paul E. McKenney a =E9crit :
> > On Tue, Mar 30, 2010 at 05:39:11PM +0100, David Howells wrote:
> > > Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> > >=20
> > > > Scrap this one -- Arnd has it covered, under the much better na=
me
> > > > of rcu_dereference_const().
> > >=20
> > > Not convinced of that name either.  That sounds like the RCU dere=
ference of
> > > constant (R/O) data.
> >=20
> > Which it is, as long as the lock is held.
> >=20
> > But what name would you suggest?
> >=20
>=20
> Maybe use 'protected' word or something like that, or 'owned', ...
>=20
> rcu_dereference_protected() or rcu_dereference_owned()

I do like rcu_dereference_protected() -- a bit longer than
rcu_dereference_locked(), but covers the initialization and cleanup
accesses that might be protected by privatization rather than by lockin=
g.

Other thoughts?

							Thanx, Paul

WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
	Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFS: Fix RCU warnings in nfs_inode_return_delegation_noreclaim() [ver #2]
Date: Tue, 30 Mar 2010 10:25:42 -0700	[thread overview]
Message-ID: <20100330172542.GI2513@linux.vnet.ibm.com> (raw)
In-Reply-To: <1269968671.10116.17.camel@edumazet-laptop>

On Tue, Mar 30, 2010 at 07:04:31PM +0200, Eric Dumazet wrote:
> Le mardi 30 mars 2010 à 09:49 -0700, Paul E. McKenney a écrit :
> > On Tue, Mar 30, 2010 at 05:39:11PM +0100, David Howells wrote:
> > > Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> > > 
> > > > Scrap this one -- Arnd has it covered, under the much better name
> > > > of rcu_dereference_const().
> > > 
> > > Not convinced of that name either.  That sounds like the RCU dereference of
> > > constant (R/O) data.
> > 
> > Which it is, as long as the lock is held.
> > 
> > But what name would you suggest?
> > 
> 
> Maybe use 'protected' word or something like that, or 'owned', ...
> 
> rcu_dereference_protected() or rcu_dereference_owned()

I do like rcu_dereference_protected() -- a bit longer than
rcu_dereference_locked(), but covers the initialization and cleanup
accesses that might be protected by privatization rather than by locking.

Other thoughts?

							Thanx, Paul

  reply	other threads:[~2010-03-30 17:25 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 13:33 [PATCH] NFS: Fix RCU warnings in nfs_inode_return_delegation_noreclaim() [ver #2] David Howells
     [not found] ` <20100318133302.29754.1584.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2010-03-19  2:25   ` Paul E. McKenney
2010-03-19  2:25     ` Paul E. McKenney
2010-03-29 19:02     ` David Howells
2010-03-29 19:21       ` Paul E. McKenney
2010-03-29 20:15         ` David Howells
2010-03-29 20:26           ` Eric Dumazet
2010-03-29 20:26             ` Eric Dumazet
2010-03-29 21:05           ` Paul E. McKenney
2010-03-29 22:22             ` David Howells
2010-03-29 22:36               ` Paul E. McKenney
2010-03-29 22:59                 ` David Howells
2010-03-29 23:26                   ` Paul E. McKenney
2010-03-30 15:40                     ` Paul E. McKenney
2010-03-30 16:39                       ` David Howells
2010-03-30 16:49                         ` Paul E. McKenney
2010-03-30 17:04                           ` Eric Dumazet
2010-03-30 17:04                             ` Eric Dumazet
2010-03-30 17:25                             ` Paul E. McKenney [this message]
2010-03-30 17:25                               ` Paul E. McKenney
2010-03-30 23:51                           ` David Howells
2010-03-31  0:08                             ` Paul E. McKenney
2010-03-31 14:04                               ` David Howells
2010-03-31 15:16                                 ` Paul E. McKenney
2010-03-31 17:37                                   ` David Howells
2010-03-31 18:30                                     ` Paul E. McKenney
2010-03-31 18:32                                     ` Eric Dumazet
2010-03-31 18:32                                       ` Eric Dumazet
2010-03-31 22:53                                       ` David Howells
2010-04-01  1:29                                         ` Paul E. McKenney
2010-04-01 11:45                                           ` David Howells
2010-04-01 14:39                                             ` Paul E. McKenney
2010-04-01 14:46                                               ` David Howells
2010-04-05 17:57                                                 ` Paul E. McKenney
2010-04-06  9:30                                                   ` David Howells
2010-04-06 16:14                                                   ` David Howells
2010-04-06 17:29                                                     ` Paul E. McKenney
2010-04-06 19:34                                                       ` David Howells
2010-04-07  0:02                                                         ` Paul E. McKenney
2010-04-07 13:22                                                           ` David Howells
2010-04-07 15:57                                                             ` Paul E. McKenney
2010-04-07 16:35                                                               ` RCU condition checks David Howells
2010-04-07 17:10                                                                 ` Paul E. McKenney
2010-04-11 22:57                                                                   ` Trond Myklebust
     [not found]                                                                     ` <1271026643.6620.37.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-04-12 16:47                                                                       ` Paul E. McKenney
2010-04-12 16:47                                                                         ` Paul E. McKenney
2010-03-30 16:37                     ` [PATCH] NFS: Fix RCU warnings in nfs_inode_return_delegation_noreclaim() [ver #2] David Howells
2010-03-30 17:01                       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100330172542.GI2513@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=dhowells@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.