From: Andrea Arcangeli <aarcange@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Dan Carpenter <error27@gmail.com>, Izik Eidus <ieidus@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Wed, 21 Apr 2010 17:46:15 +0000 [thread overview]
Message-ID: <20100421174615.GO32034@random.random> (raw)
In-Reply-To: <4BCF18A8.8080809@redhat.com>
On Wed, Apr 21, 2010 at 11:24:24AM -0400, Rik van Riel wrote:
> On 04/21/2010 06:27 AM, Dan Carpenter wrote:
> > The follow_page() function can potentially return -EFAULT so I added
> > checks for this.
> >
> > Also I silenced an uninitialized variable warning on my version of gcc
> > (version 4.3.2).
> >
> > Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> Acked-by: Rik van Riel <riel@redhat.com>
while (!(page = follow_page(vma, start, foll_flags)))
{
gup only checks for null, so when exactly is follow_page going to
return -EFAULT? It's not immediately clear.
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Dan Carpenter <error27@gmail.com>, Izik Eidus <ieidus@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Wed, 21 Apr 2010 19:46:15 +0200 [thread overview]
Message-ID: <20100421174615.GO32034@random.random> (raw)
In-Reply-To: <4BCF18A8.8080809@redhat.com>
On Wed, Apr 21, 2010 at 11:24:24AM -0400, Rik van Riel wrote:
> On 04/21/2010 06:27 AM, Dan Carpenter wrote:
> > The follow_page() function can potentially return -EFAULT so I added
> > checks for this.
> >
> > Also I silenced an uninitialized variable warning on my version of gcc
> > (version 4.3.2).
> >
> > Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> Acked-by: Rik van Riel <riel@redhat.com>
while (!(page = follow_page(vma, start, foll_flags)))
{
gup only checks for null, so when exactly is follow_page going to
return -EFAULT? It's not immediately clear.
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Dan Carpenter <error27@gmail.com>, Izik Eidus <ieidus@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Wed, 21 Apr 2010 19:46:15 +0200 [thread overview]
Message-ID: <20100421174615.GO32034@random.random> (raw)
In-Reply-To: <4BCF18A8.8080809@redhat.com>
On Wed, Apr 21, 2010 at 11:24:24AM -0400, Rik van Riel wrote:
> On 04/21/2010 06:27 AM, Dan Carpenter wrote:
> > The follow_page() function can potentially return -EFAULT so I added
> > checks for this.
> >
> > Also I silenced an uninitialized variable warning on my version of gcc
> > (version 4.3.2).
> >
> > Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> Acked-by: Rik van Riel <riel@redhat.com>
while (!(page = follow_page(vma, start, foll_flags)))
{
gup only checks for null, so when exactly is follow_page going to
return -EFAULT? It's not immediately clear.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-21 17:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 10:27 [patch] ksm: check for ERR_PTR from follow_page() Dan Carpenter
2010-04-21 10:27 ` Dan Carpenter
2010-04-21 10:27 ` Dan Carpenter
2010-04-21 15:24 ` Rik van Riel
2010-04-21 15:24 ` Rik van Riel
2010-04-21 15:24 ` Rik van Riel
2010-04-21 17:46 ` Andrea Arcangeli [this message]
2010-04-21 17:46 ` Andrea Arcangeli
2010-04-21 17:46 ` Andrea Arcangeli
2010-04-21 20:53 ` Johannes Weiner
2010-04-21 20:53 ` Johannes Weiner
2010-04-21 20:53 ` Johannes Weiner
2010-04-21 20:58 ` Andrea Arcangeli
2010-04-21 20:58 ` Andrea Arcangeli
2010-04-21 20:58 ` Andrea Arcangeli
2010-04-21 21:10 ` Johannes Weiner
2010-04-21 21:10 ` Johannes Weiner
2010-04-21 21:10 ` Johannes Weiner
2010-04-21 23:51 ` Izik Eidus
2010-04-21 23:51 ` Izik Eidus
2010-04-21 23:51 ` Izik Eidus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421174615.GO32034@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=ieidus@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.