All of lore.kernel.org
 help / color / mirror / Atom feed
From: Izik Eidus <ieidus@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-janitors@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Wed, 21 Apr 2010 23:51:18 +0000	[thread overview]
Message-ID: <20100422025118.360ea4bc@redhat.com> (raw)
In-Reply-To: <20100421102759.GA29647@bicker>

On Wed, 21 Apr 2010 12:27:59 +0200
Dan Carpenter <error27@gmail.com> wrote:

Hello

> The follow_page() function can potentially return -EFAULT so I added 
> checks for this.
> 
> Also I silenced an uninitialized variable warning on my version of gcc 
> (version 4.3.2).
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I'm not very familiar with this code, so handle with care.


Acked-by: Izik Eidus <ieidus@redhat.com>

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Izik Eidus <ieidus@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-janitors@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Thu, 22 Apr 2010 02:51:18 +0300	[thread overview]
Message-ID: <20100422025118.360ea4bc@redhat.com> (raw)
In-Reply-To: <20100421102759.GA29647@bicker>

On Wed, 21 Apr 2010 12:27:59 +0200
Dan Carpenter <error27@gmail.com> wrote:

Hello

> The follow_page() function can potentially return -EFAULT so I added 
> checks for this.
> 
> Also I silenced an uninitialized variable warning on my version of gcc 
> (version 4.3.2).
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I'm not very familiar with this code, so handle with care.


Acked-by: Izik Eidus <ieidus@redhat.com>

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Izik Eidus <ieidus@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-janitors@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Thu, 22 Apr 2010 02:51:18 +0300	[thread overview]
Message-ID: <20100422025118.360ea4bc@redhat.com> (raw)
In-Reply-To: <20100421102759.GA29647@bicker>

On Wed, 21 Apr 2010 12:27:59 +0200
Dan Carpenter <error27@gmail.com> wrote:

Hello

> The follow_page() function can potentially return -EFAULT so I added 
> checks for this.
> 
> Also I silenced an uninitialized variable warning on my version of gcc 
> (version 4.3.2).
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I'm not very familiar with this code, so handle with care.


Acked-by: Izik Eidus <ieidus@redhat.com>

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-04-21 23:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 10:27 [patch] ksm: check for ERR_PTR from follow_page() Dan Carpenter
2010-04-21 10:27 ` Dan Carpenter
2010-04-21 10:27 ` Dan Carpenter
2010-04-21 15:24 ` Rik van Riel
2010-04-21 15:24   ` Rik van Riel
2010-04-21 15:24   ` Rik van Riel
2010-04-21 17:46   ` Andrea Arcangeli
2010-04-21 17:46     ` Andrea Arcangeli
2010-04-21 17:46     ` Andrea Arcangeli
2010-04-21 20:53     ` Johannes Weiner
2010-04-21 20:53       ` Johannes Weiner
2010-04-21 20:53       ` Johannes Weiner
2010-04-21 20:58       ` Andrea Arcangeli
2010-04-21 20:58         ` Andrea Arcangeli
2010-04-21 20:58         ` Andrea Arcangeli
2010-04-21 21:10         ` Johannes Weiner
2010-04-21 21:10           ` Johannes Weiner
2010-04-21 21:10           ` Johannes Weiner
2010-04-21 23:51 ` Izik Eidus [this message]
2010-04-21 23:51   ` Izik Eidus
2010-04-21 23:51   ` Izik Eidus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100422025118.360ea4bc@redhat.com \
    --to=ieidus@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=error27@gmail.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.