From: Andrea Arcangeli <aarcange@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@redhat.com>, Dan Carpenter <error27@gmail.com>,
Izik Eidus <ieidus@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Wed, 21 Apr 2010 20:58:07 +0000 [thread overview]
Message-ID: <20100421205807.GV32034@random.random> (raw)
In-Reply-To: <20100421205305.GO20640@cmpxchg.org>
On Wed, Apr 21, 2010 at 10:53:05PM +0200, Johannes Weiner wrote:
> Check below that loop. If it returns non-null, the first check is
> whether it IS_ERR().
Indeed.
> + * Returns the mapped (struct page *), %NULL if no mapping exists, or
> + * an error pointer if there is a mapping to something not represented
> + * by a page descriptor (see also vm_normal_page()).
where exactly in vm_normal_page? Note I already checked vm_normal_page
before sending the prev email and I didn't immediately see. I search
return and they all return NULL except the return pfn_to_page(pfn), so
is pfn_to_page that returns -EFAULT (the implementations I checked
don't but there are plenty that I didn't check...).
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@redhat.com>, Dan Carpenter <error27@gmail.com>,
Izik Eidus <ieidus@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Wed, 21 Apr 2010 22:58:07 +0200 [thread overview]
Message-ID: <20100421205807.GV32034@random.random> (raw)
In-Reply-To: <20100421205305.GO20640@cmpxchg.org>
On Wed, Apr 21, 2010 at 10:53:05PM +0200, Johannes Weiner wrote:
> Check below that loop. If it returns non-null, the first check is
> whether it IS_ERR().
Indeed.
> + * Returns the mapped (struct page *), %NULL if no mapping exists, or
> + * an error pointer if there is a mapping to something not represented
> + * by a page descriptor (see also vm_normal_page()).
where exactly in vm_normal_page? Note I already checked vm_normal_page
before sending the prev email and I didn't immediately see. I search
return and they all return NULL except the return pfn_to_page(pfn), so
is pfn_to_page that returns -EFAULT (the implementations I checked
don't but there are plenty that I didn't check...).
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@redhat.com>, Dan Carpenter <error27@gmail.com>,
Izik Eidus <ieidus@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ksm: check for ERR_PTR from follow_page()
Date: Wed, 21 Apr 2010 22:58:07 +0200 [thread overview]
Message-ID: <20100421205807.GV32034@random.random> (raw)
In-Reply-To: <20100421205305.GO20640@cmpxchg.org>
On Wed, Apr 21, 2010 at 10:53:05PM +0200, Johannes Weiner wrote:
> Check below that loop. If it returns non-null, the first check is
> whether it IS_ERR().
Indeed.
> + * Returns the mapped (struct page *), %NULL if no mapping exists, or
> + * an error pointer if there is a mapping to something not represented
> + * by a page descriptor (see also vm_normal_page()).
where exactly in vm_normal_page? Note I already checked vm_normal_page
before sending the prev email and I didn't immediately see. I search
return and they all return NULL except the return pfn_to_page(pfn), so
is pfn_to_page that returns -EFAULT (the implementations I checked
don't but there are plenty that I didn't check...).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-21 20:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 10:27 [patch] ksm: check for ERR_PTR from follow_page() Dan Carpenter
2010-04-21 10:27 ` Dan Carpenter
2010-04-21 10:27 ` Dan Carpenter
2010-04-21 15:24 ` Rik van Riel
2010-04-21 15:24 ` Rik van Riel
2010-04-21 15:24 ` Rik van Riel
2010-04-21 17:46 ` Andrea Arcangeli
2010-04-21 17:46 ` Andrea Arcangeli
2010-04-21 17:46 ` Andrea Arcangeli
2010-04-21 20:53 ` Johannes Weiner
2010-04-21 20:53 ` Johannes Weiner
2010-04-21 20:53 ` Johannes Weiner
2010-04-21 20:58 ` Andrea Arcangeli [this message]
2010-04-21 20:58 ` Andrea Arcangeli
2010-04-21 20:58 ` Andrea Arcangeli
2010-04-21 21:10 ` Johannes Weiner
2010-04-21 21:10 ` Johannes Weiner
2010-04-21 21:10 ` Johannes Weiner
2010-04-21 23:51 ` Izik Eidus
2010-04-21 23:51 ` Izik Eidus
2010-04-21 23:51 ` Izik Eidus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421205807.GV32034@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=ieidus@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.