Re: [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC

Re: [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC

[Greg KH]

On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote:
> Dear all,
> 
> It is device driver for DA9052 Power Management IC from Dialog Semiconductor.

What are we supposed to do with this?

Please read Documentation/SubmittingPatches for how to submit a patch
(hint, you need to break it up, and provide a "Signed-off-by:" line, and
send it to the correct people and subsystem mailing lists.)

And why did you add a selinux file?  I think something is wrong with how
you generated your patch.

thanks,

greg k-h

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [PATCH] Device driver for DA9052 PMIC IC

[Greg KH]

On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote:
> Dear all,
> 
> It is device driver for DA9052 Power Management IC from Dialog Semiconductor.

What are we supposed to do with this?

Please read Documentation/SubmittingPatches for how to submit a patch
(hint, you need to break it up, and provide a "Signed-off-by:" line, and
send it to the correct people and subsystem mailing lists.)

And why did you add a selinux file?  I think something is wrong with how
you generated your patch.

thanks,

greg k-h

Re: [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC

[Greg KH]

On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote:
> Dear all,
> 
> It is device driver for DA9052 Power Management IC from Dialog Semiconductor.

Oh, also please run your code through the scripts/checkpatch.pl script.
It found:
	total: 4635 errors, 1558 warnings, 24394 lines checked
with this patch.

If you don't want to do the work to fix this up, please let me know and
I'll be glad to move these drivers into the staging tree, where they can
live until stuff like this is cleaned up.

thanks,

greg k-h

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [PATCH] Device driver for DA9052 PMIC IC

[Greg KH]

On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote:
> Dear all,
> 
> It is device driver for DA9052 Power Management IC from Dialog Semiconductor.

Oh, also please run your code through the scripts/checkpatch.pl script.
It found:
	total: 4635 errors, 1558 warnings, 24394 lines checked
with this patch.

If you don't want to do the work to fix this up, please let me know and
I'll be glad to move these drivers into the staging tree, where they can
live until stuff like this is cleaned up.

thanks,

greg k-h