* Re: [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC [not found] <3495EC08FA53E94AAA00CC4743D5BA7E010C1E94@pandora.diasemi.com> @ 2010-05-07 16:13 ` Greg KH 2010-05-07 16:18 ` Greg KH 1 sibling, 0 replies; 4+ messages in thread From: Greg KH @ 2010-05-07 16:13 UTC (permalink / raw) To: David Dajun Chen Cc: linux-kernel, Jonathan Cameron, sameo, lm-sensors, rpurdie, lrg, dmitry.torokhov On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote: > Dear all, > > It is device driver for DA9052 Power Management IC from Dialog Semiconductor. What are we supposed to do with this? Please read Documentation/SubmittingPatches for how to submit a patch (hint, you need to break it up, and provide a "Signed-off-by:" line, and send it to the correct people and subsystem mailing lists.) And why did you add a selinux file? I think something is wrong with how you generated your patch. thanks, greg k-h _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Device driver for DA9052 PMIC IC @ 2010-05-07 16:13 ` Greg KH 0 siblings, 0 replies; 4+ messages in thread From: Greg KH @ 2010-05-07 16:13 UTC (permalink / raw) To: David Dajun Chen Cc: linux-kernel, Jonathan Cameron, sameo, lm-sensors, rpurdie, lrg, dmitry.torokhov On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote: > Dear all, > > It is device driver for DA9052 Power Management IC from Dialog Semiconductor. What are we supposed to do with this? Please read Documentation/SubmittingPatches for how to submit a patch (hint, you need to break it up, and provide a "Signed-off-by:" line, and send it to the correct people and subsystem mailing lists.) And why did you add a selinux file? I think something is wrong with how you generated your patch. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC [not found] <3495EC08FA53E94AAA00CC4743D5BA7E010C1E94@pandora.diasemi.com> @ 2010-05-07 16:18 ` Greg KH 2010-05-07 16:18 ` Greg KH 1 sibling, 0 replies; 4+ messages in thread From: Greg KH @ 2010-05-07 16:18 UTC (permalink / raw) To: David Dajun Chen Cc: linux-kernel, Jonathan Cameron, sameo, lm-sensors, rpurdie, lrg, dmitry.torokhov On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote: > Dear all, > > It is device driver for DA9052 Power Management IC from Dialog Semiconductor. Oh, also please run your code through the scripts/checkpatch.pl script. It found: total: 4635 errors, 1558 warnings, 24394 lines checked with this patch. If you don't want to do the work to fix this up, please let me know and I'll be glad to move these drivers into the staging tree, where they can live until stuff like this is cleaned up. thanks, greg k-h _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Device driver for DA9052 PMIC IC @ 2010-05-07 16:18 ` Greg KH 0 siblings, 0 replies; 4+ messages in thread From: Greg KH @ 2010-05-07 16:18 UTC (permalink / raw) To: David Dajun Chen Cc: linux-kernel, Jonathan Cameron, sameo, lm-sensors, rpurdie, lrg, dmitry.torokhov On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote: > Dear all, > > It is device driver for DA9052 Power Management IC from Dialog Semiconductor. Oh, also please run your code through the scripts/checkpatch.pl script. It found: total: 4635 errors, 1558 warnings, 24394 lines checked with this patch. If you don't want to do the work to fix this up, please let me know and I'll be glad to move these drivers into the staging tree, where they can live until stuff like this is cleaned up. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-07 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <3495EC08FA53E94AAA00CC4743D5BA7E010C1E94@pandora.diasemi.com>
2010-05-07 16:13 ` [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC Greg KH
2010-05-07 16:13 ` Greg KH
2010-05-07 16:18 ` [lm-sensors] " Greg KH
2010-05-07 16:18 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.