From: Huaxu Wan <huaxu.wan@linux.intel.com>
To: Huaxu Wan <huaxu.wan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
huaxu.wan@intel.com, Carsten Emde <C.Emde@osadl.org>
Subject: [lm-sensors] [PATCH 2/2 V2] hwmon: (coretemp) Get TjMax value from
Date: Mon, 10 May 2010 03:50:31 +0000 [thread overview]
Message-ID: <20100510035031.GD9181@owl> (raw)
In-Reply-To: <20100507095945.GB12190@owl>
The MSR IA32_TEMPERATURE_TARGET contains the TjMax value in the newer
processers.
Signed-off-by: Huaxu Wan <huaxu.wan@linux.intel.com>
Signed-off-by: Carsten Emde <C.Emde@osadl.org>
---
arch/x86/include/asm/msr-index.h | 2 +
drivers/hwmon/coretemp.c | 52 ++++++++++++++++++++++++++++++++++++-
2 files changed, 52 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
index 4604e6a..9bc0cf8 100644
--- a/arch/x86/include/asm/msr-index.h
+++ b/arch/x86/include/asm/msr-index.h
@@ -232,6 +232,8 @@
#define MSR_IA32_MISC_ENABLE 0x000001a0
+#define MSR_IA32_TEMPERATURE_TARGET 0x000001a2
+
/* MISC_ENABLE bits: architectural */
#define MSR_IA32_MISC_ENABLE_FAST_STRING (1ULL << 0)
#define MSR_IA32_MISC_ENABLE_TCC (1ULL << 1)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index d194207..9959390 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -241,6 +241,54 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *
return tjmax;
}
+static int __devinit get_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *dev)
+{
+ /* The 100C is default for both mobile and non mobile CPUs */
+ int err;
+ u32 eax, edx;
+ u32 val;
+
+ /* A new feature of current Intel(R) processors, the
+ IA32_TEMPERATURE_TARGET contains the TjMax value */
+ err = rdmsr_safe_on_cpu(id, MSR_IA32_TEMPERATURE_TARGET, &eax, &edx);
+ if (err){
+ dev_warn(dev, "Unable to read TjMax from CPU.\n");
+ } else {
+ val = (eax >> 16 ) & 0xff;
+ /*
+ * If the TjMax is not plausible, an assumption
+ * will be used
+ */
+ if (( val > 80) && (val < 120)){
+ dev_info(dev, "TjMax is %d C. \n", val);
+ return val * 1000;
+ }
+ }
+
+ /*
+ * An assumption is made for early CPUs and unreadable MSR.
+ * NOTE: the given value may not be correct.
+ */
+
+ switch(c->x86_model){
+ case 0xe :
+ case 0xf :
+ case 0x16 :
+ case 0x1a :
+ dev_warn(dev, "TjMax is assumed as 100 C! \n");
+ return 100000;
+ break;
+ case 0x17 :
+ case 0x1c : /* Atom CPUs */
+ return adjust_tjmax(c, id, dev);
+ break;
+ default :
+ dev_warn(dev, "CPU (model=0x%x) is not supported yet,"
+ " using default TjMax of 100C.\n", c->x86_model);
+ return 100000;
+ }
+}
+
static int __devinit coretemp_probe(struct platform_device *pdev)
{
struct coretemp_data *data;
@@ -283,14 +331,14 @@ static int __devinit coretemp_probe(struct platform_device *pdev)
}
}
- data->tjmax = adjust_tjmax(c, data->id, &pdev->dev);
+ data->tjmax = get_tjmax(c, data->id, &pdev->dev);
platform_set_drvdata(pdev, data);
/* read the still undocumented IA32_TEMPERATURE_TARGET it exists
on older CPUs but not in this register, Atoms don't have it either */
if ((c->x86_model > 0xe) && (c->x86_model != 0x1c)) {
- err = rdmsr_safe_on_cpu(data->id, 0x1a2, &eax, &edx);
+ err = rdmsr_safe_on_cpu(data->id, MSR_IA32_TEMPERATURE_TARGET, &eax, &edx);
if (err) {
dev_warn(&pdev->dev, "Unable to read"
" IA32_TEMPERATURE_TARGET MSR\n");
--
1.6.3.3.363.g725cf7
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Huaxu Wan <huaxu.wan@linux.intel.com>
To: Huaxu Wan <huaxu.wan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
huaxu.wan@intel.com, Carsten Emde <C.Emde@osadl.org>
Subject: [PATCH 2/2 V2] hwmon: (coretemp) Get TjMax value from MSR
Date: Mon, 10 May 2010 11:50:31 +0800 [thread overview]
Message-ID: <20100510035031.GD9181@owl> (raw)
In-Reply-To: <20100507095945.GB12190@owl>
The MSR IA32_TEMPERATURE_TARGET contains the TjMax value in the newer
processers.
Signed-off-by: Huaxu Wan <huaxu.wan@linux.intel.com>
Signed-off-by: Carsten Emde <C.Emde@osadl.org>
---
arch/x86/include/asm/msr-index.h | 2 +
drivers/hwmon/coretemp.c | 52 ++++++++++++++++++++++++++++++++++++-
2 files changed, 52 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
index 4604e6a..9bc0cf8 100644
--- a/arch/x86/include/asm/msr-index.h
+++ b/arch/x86/include/asm/msr-index.h
@@ -232,6 +232,8 @@
#define MSR_IA32_MISC_ENABLE 0x000001a0
+#define MSR_IA32_TEMPERATURE_TARGET 0x000001a2
+
/* MISC_ENABLE bits: architectural */
#define MSR_IA32_MISC_ENABLE_FAST_STRING (1ULL << 0)
#define MSR_IA32_MISC_ENABLE_TCC (1ULL << 1)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index d194207..9959390 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -241,6 +241,54 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *
return tjmax;
}
+static int __devinit get_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *dev)
+{
+ /* The 100C is default for both mobile and non mobile CPUs */
+ int err;
+ u32 eax, edx;
+ u32 val;
+
+ /* A new feature of current Intel(R) processors, the
+ IA32_TEMPERATURE_TARGET contains the TjMax value */
+ err = rdmsr_safe_on_cpu(id, MSR_IA32_TEMPERATURE_TARGET, &eax, &edx);
+ if (err){
+ dev_warn(dev, "Unable to read TjMax from CPU.\n");
+ } else {
+ val = (eax >> 16 ) & 0xff;
+ /*
+ * If the TjMax is not plausible, an assumption
+ * will be used
+ */
+ if (( val > 80) && (val < 120)){
+ dev_info(dev, "TjMax is %d C. \n", val);
+ return val * 1000;
+ }
+ }
+
+ /*
+ * An assumption is made for early CPUs and unreadable MSR.
+ * NOTE: the given value may not be correct.
+ */
+
+ switch(c->x86_model){
+ case 0xe :
+ case 0xf :
+ case 0x16 :
+ case 0x1a :
+ dev_warn(dev, "TjMax is assumed as 100 C! \n");
+ return 100000;
+ break;
+ case 0x17 :
+ case 0x1c : /* Atom CPUs */
+ return adjust_tjmax(c, id, dev);
+ break;
+ default :
+ dev_warn(dev, "CPU (model=0x%x) is not supported yet,"
+ " using default TjMax of 100C.\n", c->x86_model);
+ return 100000;
+ }
+}
+
static int __devinit coretemp_probe(struct platform_device *pdev)
{
struct coretemp_data *data;
@@ -283,14 +331,14 @@ static int __devinit coretemp_probe(struct platform_device *pdev)
}
}
- data->tjmax = adjust_tjmax(c, data->id, &pdev->dev);
+ data->tjmax = get_tjmax(c, data->id, &pdev->dev);
platform_set_drvdata(pdev, data);
/* read the still undocumented IA32_TEMPERATURE_TARGET it exists
on older CPUs but not in this register, Atoms don't have it either */
if ((c->x86_model > 0xe) && (c->x86_model != 0x1c)) {
- err = rdmsr_safe_on_cpu(data->id, 0x1a2, &eax, &edx);
+ err = rdmsr_safe_on_cpu(data->id, MSR_IA32_TEMPERATURE_TARGET, &eax, &edx);
if (err) {
dev_warn(&pdev->dev, "Unable to read"
" IA32_TEMPERATURE_TARGET MSR\n");
--
1.6.3.3.363.g725cf7
next prev parent reply other threads:[~2010-05-10 3:50 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 15:38 [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Huaxu Wan
2010-03-05 16:19 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Luca Tettamanti
2010-03-08 14:44 ` Huaxu Wan
2010-05-07 9:59 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Huaxu Wan
2010-05-07 9:59 ` Huaxu Wan
2010-05-07 13:29 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Carsten Emde
2010-05-07 13:29 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Carsten Emde
2010-05-10 3:09 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Huaxu Wan
2010-05-10 3:09 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Huaxu Wan
2010-05-10 3:50 ` Huaxu Wan [this message]
2010-05-10 3:50 ` [PATCH 2/2 V2] " Huaxu Wan
2010-05-29 5:39 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Maxim Levitsky
2010-05-29 5:39 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Maxim Levitsky
2010-05-30 14:43 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Maxim Levitsky
2010-05-30 14:43 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Maxim Levitsky
2010-05-31 1:39 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Huaxu Wan
2010-05-31 1:39 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Huaxu Wan
2010-06-02 16:34 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Maxim Levitsky
2010-06-02 16:34 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Maxim Levitsky
2010-06-02 20:10 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Maxim Levitsky
2010-06-02 20:10 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Maxim Levitsky
2010-06-12 13:03 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Maxim Levitsky
2010-06-12 13:03 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Maxim Levitsky
2010-06-13 2:27 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Wan, Huaxu
2010-06-13 2:27 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Wan, Huaxu
2010-07-26 8:16 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Maxim Levitsky
2010-07-26 8:16 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Maxim Levitsky
2010-08-30 1:42 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Huaxu Wan
2010-08-30 1:42 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Huaxu Wan
2010-08-31 21:01 ` [lm-sensors] [PATCH 2/2] hwmon: (coretemp) Get TjMax value from Fenghua Yu
2010-08-31 21:01 ` [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Fenghua Yu
-- strict thread matches above, loose matches on Subject: below --
2010-03-05 15:28 [lm-sensors] [PATCH 1/2] hwmon: (coretemp) Detect the thermal Huaxu Wan
2010-05-07 9:54 ` Huaxu Wan
2010-05-07 9:54 ` [PATCH 1/2] hwmon: (coretemp) Detect the thermal sensors by CPUID Huaxu Wan
2010-05-07 12:43 ` [lm-sensors] [PATCH 1/2] hwmon: (coretemp) Detect the thermal Jean Delvare
2010-05-07 12:43 ` [PATCH 1/2] hwmon: (coretemp) Detect the thermal sensors by CPUID Jean Delvare
2010-05-07 13:21 ` [lm-sensors] [PATCH 1/2] hwmon: (coretemp) Detect the thermal Carsten Emde
2010-05-07 13:21 ` [lm-sensors] [PATCH 1/2] hwmon: (coretemp) Detect the thermal sensors by CPUID Carsten Emde
2010-05-10 2:35 ` [lm-sensors] [PATCH 1/2] hwmon: (coretemp) Detect the thermal Huaxu Wan
2010-05-10 2:35 ` [lm-sensors] [PATCH 1/2] hwmon: (coretemp) Detect the thermal sensors by CPUID Huaxu Wan
2010-05-10 3:35 ` [lm-sensors] [PATCH 1/2 V2] hwmon: (coretemp) Detect the thermal Huaxu Wan
2010-05-10 3:35 ` [PATCH 1/2 V2] hwmon: (coretemp) Detect the thermal sensors by CPUID Huaxu Wan
2010-05-10 12:45 ` [lm-sensors] [PATCH 1/2 V2] hwmon: (coretemp) Detect the Valdis.Kletnieks
2010-05-10 12:45 ` [PATCH 1/2 V2] hwmon: (coretemp) Detect the thermal sensors by CPUID Valdis.Kletnieks
2010-05-11 3:41 ` [lm-sensors] [PATCH 1/2 V2] hwmon: (coretemp) Detect the Huaxu Wan
2010-05-11 3:41 ` [PATCH 1/2 V2] hwmon: (coretemp) Detect the thermal sensors by CPUID Huaxu Wan
2010-05-11 7:55 ` [lm-sensors] [PATCH 1/2 V3] hwmon: (coretemp) Detect the thermal Huaxu Wan
2010-05-11 8:01 ` [PATCH 1/2 V3] hwmon: (coretemp) Detect the thermal sensors by CPUID Huaxu Wan
2010-05-11 21:45 ` [lm-sensors] [PATCH 1/2 V3] hwmon: (coretemp) Detect the Valdis.Kletnieks
2010-05-11 21:45 ` [PATCH 1/2 V3] hwmon: (coretemp) Detect the thermal sensors by CPUID Valdis.Kletnieks
2010-05-14 3:20 ` [lm-sensors] [PATCH 1/2 V3] hwmon: (coretemp) Detect the Henrique de Moraes Holschuh
2010-05-14 3:20 ` [lm-sensors] [PATCH 1/2 V3] hwmon: (coretemp) Detect the thermal sensors by CPUID Henrique de Moraes Holschuh
2010-05-14 6:58 ` [lm-sensors] [PATCH 1/2 V3 minor change] hwmon: (coretemp) Detect Huaxu Wan
2010-05-14 6:58 ` [PATCH 1/2 V3 minor change] hwmon: (coretemp) Detect the thermal sensors by CPUID Huaxu Wan
2010-05-17 9:41 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel Carsten Emde
2010-05-17 9:41 ` [PATCH 0/2] hwmon: Update coretemp to current Intel processors Carsten Emde
2010-05-17 9:41 ` [lm-sensors] [PATCH 1/2] Detect the thermal sensors by CPUID Carsten Emde
2010-05-17 9:41 ` Carsten Emde
2010-05-17 9:41 ` [lm-sensors] [PATCH 2/2] Get TjMax value from MSR Carsten Emde
2010-05-17 9:41 ` Carsten Emde
2010-05-18 4:47 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Dmitry Gromov
2010-05-18 7:01 ` Carsten Emde
2010-05-18 7:01 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Carsten Emde
2010-05-18 12:03 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Dmitry Gromov
2010-05-18 12:03 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Dmitry Gromov
2010-05-19 1:27 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Huaxu Wan
2010-05-19 1:27 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Huaxu Wan
2010-05-18 5:07 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Wan, Huaxu
2010-05-18 6:45 ` Dmitry Gromov
2010-05-18 7:13 ` Carsten Emde
2010-05-18 7:13 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Carsten Emde
2010-05-19 0:50 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Huaxu Wan
2010-05-19 0:50 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Huaxu Wan
2010-05-19 3:12 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Dmitry Gromov
2010-05-19 3:12 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Dmitry Gromov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510035031.GD9181@owl \
--to=huaxu.wan@linux.intel.com \
--cc=C.Emde@osadl.org \
--cc=huaxu.wan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.