All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	David Brownell
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
	<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: PMBus support in Linux
Date: Sat, 29 May 2010 10:12:29 -0700	[thread overview]
Message-ID: <20100529171229.GA21284@ericsson.com> (raw)
In-Reply-To: <20100529154741.GB7572-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

On Sat, May 29, 2010 at 11:47:41AM -0400, Wolfram Sang wrote:
> 
> > Yes. PMBus uses i2c as transport, so it can use the existing i2c/smbus infrastructure. 
> > Data reported is voltage, temperature, current, power, and fan data as available
> > from the individual chip. Chips support a chip dependent number of channels.
> > Values reported are typically in the form of X = Y * 2^N, ie there is a mantissa
> > and an exponent.
> > 
> > So I would say it maps pretty well; I don't really see a substantial difference
> > to other HW monitoring chips in that respect. Key difference may be that PMBus devices 
> > typically also have a control component, but I don't have plans to implement that,
> > at least not for now.
> 
> I just had a glimpse, but I came to a similar conclusion. As I further
> understood, PMBus devices support a standard range of commands with the
> possibility of manufacturer extenstions.
> 
> So, the approach I see (unless I miss something) would be writing an
> hwmon-I2C-driver named pmbus-devices.c or so which covers the generic
> functionality and provides some hooks for manufacturer extensions, if those are
> necessary? (Altough I'd hope a number of devices would be covered by the
> generic driver) Makes sense?
> 
That would be one option. It would require either a register() API call, or a table
of supported chips, or a combination of both, to identify how many channels
(or pages, in PMBus terminology) per chip are supported and to identify supported
objects/registers.

The other option would be to write separate drivers (one for each chip) and not provide
a common infrastructure. Not sure if that is a good idea, though; I personally prefer
the first option.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	David Brownell
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
	<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: [lm-sensors] PMBus support in Linux
Date: Sat, 29 May 2010 17:12:29 +0000	[thread overview]
Message-ID: <20100529171229.GA21284@ericsson.com> (raw)
In-Reply-To: <20100529154741.GB7572-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

On Sat, May 29, 2010 at 11:47:41AM -0400, Wolfram Sang wrote:
> 
> > Yes. PMBus uses i2c as transport, so it can use the existing i2c/smbus infrastructure. 
> > Data reported is voltage, temperature, current, power, and fan data as available
> > from the individual chip. Chips support a chip dependent number of channels.
> > Values reported are typically in the form of X = Y * 2^N, ie there is a mantissa
> > and an exponent.
> > 
> > So I would say it maps pretty well; I don't really see a substantial difference
> > to other HW monitoring chips in that respect. Key difference may be that PMBus devices 
> > typically also have a control component, but I don't have plans to implement that,
> > at least not for now.
> 
> I just had a glimpse, but I came to a similar conclusion. As I further
> understood, PMBus devices support a standard range of commands with the
> possibility of manufacturer extenstions.
> 
> So, the approach I see (unless I miss something) would be writing an
> hwmon-I2C-driver named pmbus-devices.c or so which covers the generic
> functionality and provides some hooks for manufacturer extensions, if those are
> necessary? (Altough I'd hope a number of devices would be covered by the
> generic driver) Makes sense?
> 
That would be one option. It would require either a register() API call, or a table
of supported chips, or a combination of both, to identify how many channels
(or pages, in PMBus terminology) per chip are supported and to identify supported
objects/registers.

The other option would be to write separate drivers (one for each chip) and not provide
a common infrastructure. Not sure if that is a good idea, though; I personally prefer
the first option.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2010-05-29 17:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28 16:16 PMBus support in Linux Guenter Roeck
2010-05-29  2:34 ` Wolfram Sang
2010-05-29  2:34   ` [lm-sensors] " Wolfram Sang
2010-05-29  4:42   ` Guenter Roeck
2010-05-29  4:42     ` [lm-sensors] " Guenter Roeck
     [not found]     ` <20100529044239.GA19155-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-05-29  8:53       ` Wolfram Sang
2010-05-29  8:53         ` [lm-sensors] " Wolfram Sang
     [not found]         ` <20100529085301.GA14982-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-29 15:33           ` Guenter Roeck
2010-05-29 15:33             ` [lm-sensors] " Guenter Roeck
     [not found]             ` <20100529153312.GA20814-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-05-29 15:47               ` Wolfram Sang
2010-05-29 15:47                 ` [lm-sensors] " Wolfram Sang
     [not found]                 ` <20100529154741.GB7572-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-29 17:12                   ` Guenter Roeck [this message]
2010-05-29 17:12                     ` Guenter Roeck
     [not found]                     ` <20100529171229.GA21284-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-05-30  4:15                       ` Wolfram Sang
2010-05-30  4:15                         ` [lm-sensors] " Wolfram Sang
     [not found]                         ` <20100530041507.GA20222-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-30 15:08                           ` Guenter Roeck
2010-05-30 15:08                             ` [lm-sensors] " Guenter Roeck
     [not found]   ` <20100529023401.GB12507-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-29  7:39     ` Jean Delvare
2010-05-29  7:39       ` [lm-sensors] " Jean Delvare
     [not found]       ` <20100529093929.38e03e06-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-05-29  8:16         ` Wolfram Sang
2010-05-29  8:16           ` [lm-sensors] " Wolfram Sang
     [not found]           ` <20100529081633.GA7428-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-29 10:03             ` Jean Delvare
2010-05-29 10:03               ` [lm-sensors] " Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100529171229.GA21284@ericsson.com \
    --to=guenter.roeck-izefyvvap7pwk0htik3j/w@public.gmane.org \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.