All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org, anthony@codemonkey.ws
Cc: chrisw@redhat.com, alex.williamson@redhat.com,
	kvm@vger.kernel.org, quintela@redhat.com
Subject: [RFC PATCH 1/6] qemu_ram_alloc: Remove duplicate code
Date: Tue, 08 Jun 2010 13:15:20 -0600	[thread overview]
Message-ID: <20100608191520.4451.1193.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100608191447.4451.47795.stgit@localhost.localdomain>

No reason not to call qemu_ram_map() once we have the allocation
and remove duplicate code.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 exec.c |   37 ++++++++++---------------------------
 1 files changed, 10 insertions(+), 27 deletions(-)

diff --git a/exec.c b/exec.c
index 7b0e1c5..c60f9e7 100644
--- a/exec.c
+++ b/exec.c
@@ -2816,18 +2816,17 @@ ram_addr_t qemu_ram_map(ram_addr_t size, void *host)
 
 ram_addr_t qemu_ram_alloc(ram_addr_t size)
 {
-    RAMBlock *new_block;
+    void *host;
 
     size = TARGET_PAGE_ALIGN(size);
-    new_block = qemu_malloc(sizeof(*new_block));
 
     if (mem_path) {
 #if defined (__linux__) && !defined(TARGET_S390X)
-        new_block->host = file_ram_alloc(size, mem_path);
-        if (!new_block->host) {
-            new_block->host = qemu_vmalloc(size);
+        host = file_ram_alloc(size, mem_path);
+        if (!host) {
+            host = qemu_vmalloc(size);
 #ifdef MADV_MERGEABLE
-            madvise(new_block->host, size, MADV_MERGEABLE);
+            madvise(host, size, MADV_MERGEABLE);
 #endif
         }
 #else
@@ -2837,33 +2836,17 @@ ram_addr_t qemu_ram_alloc(ram_addr_t size)
     } else {
 #if defined(TARGET_S390X) && defined(CONFIG_KVM)
         /* XXX S390 KVM requires the topmost vma of the RAM to be < 256GB */
-        new_block->host = mmap((void*)0x1000000, size,
-                                PROT_EXEC|PROT_READ|PROT_WRITE,
-                                MAP_SHARED | MAP_ANONYMOUS, -1, 0);
+        host = mmap((void*)0x1000000, size, PROT_EXEC|PROT_READ|PROT_WRITE,
+                    MAP_SHARED | MAP_ANONYMOUS, -1, 0);
 #else
-        new_block->host = qemu_vmalloc(size);
+        host = qemu_vmalloc(size);
 #endif
 #ifdef MADV_MERGEABLE
-        madvise(new_block->host, size, MADV_MERGEABLE);
+        madvise(host, size, MADV_MERGEABLE);
 #endif
     }
-    new_block->offset = last_ram_offset;
-    new_block->length = size;
-
-    new_block->next = ram_blocks;
-    ram_blocks = new_block;
-
-    phys_ram_dirty = qemu_realloc(phys_ram_dirty,
-        (last_ram_offset + size) >> TARGET_PAGE_BITS);
-    memset(phys_ram_dirty + (last_ram_offset >> TARGET_PAGE_BITS),
-           0xff, size >> TARGET_PAGE_BITS);
-
-    last_ram_offset += size;
 
-    if (kvm_enabled())
-        kvm_setup_guest_memory(new_block->host, size);
-
-    return new_block->offset;
+    return qemu_ram_map(size, host);
 }
 
 void qemu_ram_free(ram_addr_t addr)

WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org, anthony@codemonkey.ws
Cc: chrisw@redhat.com, alex.williamson@redhat.com,
	kvm@vger.kernel.org, quintela@redhat.com
Subject: [Qemu-devel] [RFC PATCH 1/6] qemu_ram_alloc: Remove duplicate code
Date: Tue, 08 Jun 2010 13:15:20 -0600	[thread overview]
Message-ID: <20100608191520.4451.1193.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100608191447.4451.47795.stgit@localhost.localdomain>

No reason not to call qemu_ram_map() once we have the allocation
and remove duplicate code.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 exec.c |   37 ++++++++++---------------------------
 1 files changed, 10 insertions(+), 27 deletions(-)

diff --git a/exec.c b/exec.c
index 7b0e1c5..c60f9e7 100644
--- a/exec.c
+++ b/exec.c
@@ -2816,18 +2816,17 @@ ram_addr_t qemu_ram_map(ram_addr_t size, void *host)
 
 ram_addr_t qemu_ram_alloc(ram_addr_t size)
 {
-    RAMBlock *new_block;
+    void *host;
 
     size = TARGET_PAGE_ALIGN(size);
-    new_block = qemu_malloc(sizeof(*new_block));
 
     if (mem_path) {
 #if defined (__linux__) && !defined(TARGET_S390X)
-        new_block->host = file_ram_alloc(size, mem_path);
-        if (!new_block->host) {
-            new_block->host = qemu_vmalloc(size);
+        host = file_ram_alloc(size, mem_path);
+        if (!host) {
+            host = qemu_vmalloc(size);
 #ifdef MADV_MERGEABLE
-            madvise(new_block->host, size, MADV_MERGEABLE);
+            madvise(host, size, MADV_MERGEABLE);
 #endif
         }
 #else
@@ -2837,33 +2836,17 @@ ram_addr_t qemu_ram_alloc(ram_addr_t size)
     } else {
 #if defined(TARGET_S390X) && defined(CONFIG_KVM)
         /* XXX S390 KVM requires the topmost vma of the RAM to be < 256GB */
-        new_block->host = mmap((void*)0x1000000, size,
-                                PROT_EXEC|PROT_READ|PROT_WRITE,
-                                MAP_SHARED | MAP_ANONYMOUS, -1, 0);
+        host = mmap((void*)0x1000000, size, PROT_EXEC|PROT_READ|PROT_WRITE,
+                    MAP_SHARED | MAP_ANONYMOUS, -1, 0);
 #else
-        new_block->host = qemu_vmalloc(size);
+        host = qemu_vmalloc(size);
 #endif
 #ifdef MADV_MERGEABLE
-        madvise(new_block->host, size, MADV_MERGEABLE);
+        madvise(host, size, MADV_MERGEABLE);
 #endif
     }
-    new_block->offset = last_ram_offset;
-    new_block->length = size;
-
-    new_block->next = ram_blocks;
-    ram_blocks = new_block;
-
-    phys_ram_dirty = qemu_realloc(phys_ram_dirty,
-        (last_ram_offset + size) >> TARGET_PAGE_BITS);
-    memset(phys_ram_dirty + (last_ram_offset >> TARGET_PAGE_BITS),
-           0xff, size >> TARGET_PAGE_BITS);
-
-    last_ram_offset += size;
 
-    if (kvm_enabled())
-        kvm_setup_guest_memory(new_block->host, size);
-
-    return new_block->offset;
+    return qemu_ram_map(size, host);
 }
 
 void qemu_ram_free(ram_addr_t addr)

  reply	other threads:[~2010-06-08 19:15 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 19:14 [RFC PATCH 0/6] RAM migration overhaul Alex Williamson
2010-06-08 19:14 ` [Qemu-devel] " Alex Williamson
2010-06-08 19:15 ` Alex Williamson [this message]
2010-06-08 19:15   ` [Qemu-devel] [RFC PATCH 1/6] qemu_ram_alloc: Remove duplicate code Alex Williamson
2010-06-08 21:00   ` Chris Wright
2010-06-08 21:00     ` [Qemu-devel] " Chris Wright
2010-06-08 19:15 ` [RFC PATCH 2/6] ram_blocks: Convert to a QLIST Alex Williamson
2010-06-08 19:15   ` [Qemu-devel] " Alex Williamson
2010-06-08 21:26   ` Chris Wright
2010-06-08 21:26     ` [Qemu-devel] " Chris Wright
2010-06-08 21:45     ` Alex Williamson
2010-06-08 21:45       ` [Qemu-devel] " Alex Williamson
2010-06-08 21:51       ` Chris Wright
2010-06-08 21:51         ` [Qemu-devel] " Chris Wright
2010-06-09  8:19       ` Juan Quintela
2010-06-09  8:19         ` [Qemu-devel] " Juan Quintela
2010-06-09 20:11   ` [Qemu-devel] " Cam Macdonell
2010-06-09 20:11     ` Cam Macdonell
2010-06-09 20:55     ` Alex Williamson
2010-06-09 20:55       ` Alex Williamson
2010-06-09 21:12       ` Yoshiaki Tamura
2010-06-09 21:12         ` Yoshiaki Tamura
2010-06-08 19:15 ` [RFC PATCH 3/6] RAMBlock: Add a name field Alex Williamson
2010-06-08 19:15   ` [Qemu-devel] " Alex Williamson
2010-06-08 20:07   ` Anthony Liguori
2010-06-08 20:07     ` [Qemu-devel] " Anthony Liguori
2010-06-08 20:09     ` Alex Williamson
2010-06-08 20:09       ` [Qemu-devel] " Alex Williamson
2010-06-08 21:41   ` Chris Wright
2010-06-08 21:41     ` [Qemu-devel] " Chris Wright
2010-06-09  3:13     ` Alex Williamson
2010-06-09  3:13       ` [Qemu-devel] " Alex Williamson
2010-06-09 11:55     ` Avi Kivity
2010-06-09 11:55       ` [Qemu-devel] " Avi Kivity
2010-06-09 12:56     ` Paul Brook
2010-06-09 12:56       ` Paul Brook
2010-06-09  2:30   ` [Qemu-devel] " Paul Brook
2010-06-09  2:30     ` Paul Brook
2010-06-09  2:40     ` Anthony Liguori
2010-06-09  2:40       ` Anthony Liguori
2010-06-09  2:54       ` Paul Brook
2010-06-09  2:54         ` Paul Brook
2010-06-09  4:19         ` Alex Williamson
2010-06-09  4:19           ` Alex Williamson
2010-06-09 12:18           ` Paul Brook
2010-06-09 12:18             ` Paul Brook
2010-06-09 16:37             ` Alex Williamson
2010-06-09 16:37               ` Alex Williamson
2010-06-09 20:36               ` Paul Brook
2010-06-09 20:36                 ` Paul Brook
2010-06-10  8:23                 ` Gerd Hoffmann
2010-06-10  8:23                   ` Gerd Hoffmann
2010-06-10 14:33                   ` Alex Williamson
2010-06-10 14:33                     ` Alex Williamson
2010-06-10 14:49                     ` Paul Brook
2010-06-10 14:49                       ` Paul Brook
2010-06-10 15:21                       ` Alex Williamson
2010-06-10 15:21                         ` Alex Williamson
2010-06-11  8:48                         ` Gerd Hoffmann
2010-06-11  8:48                           ` Gerd Hoffmann
2010-06-11 15:50                           ` Alex Williamson
2010-06-11 15:50                             ` Alex Williamson
2010-06-11 16:12                             ` Paul Brook
2010-06-11 16:12                               ` Paul Brook
2010-06-11  8:45                     ` Gerd Hoffmann
2010-06-11  8:45                       ` Gerd Hoffmann
2010-06-10 15:05                 ` Alex Williamson
2010-06-10 15:05                   ` Alex Williamson
2010-06-10 16:40               ` Chris Wright
2010-06-10 16:40                 ` Chris Wright
2010-06-10 16:45                 ` Paul Brook
2010-06-10 16:45                   ` Paul Brook
2010-06-09 11:58         ` Avi Kivity
2010-06-09 11:58           ` Avi Kivity
2010-06-09 13:57           ` Anthony Liguori
2010-06-09 13:57             ` Anthony Liguori
2010-06-09 14:09             ` Paul Brook
2010-06-09 14:09               ` Paul Brook
2010-06-09  7:28       ` Gerd Hoffmann
2010-06-09  7:28         ` Gerd Hoffmann
2010-06-08 19:16 ` [RFC PATCH 4/6] Remove uses of ram.last_offset (aka last_ram_offset) Alex Williamson
2010-06-08 19:16   ` [Qemu-devel] " Alex Williamson
2010-06-08 19:16 ` [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset Alex Williamson
2010-06-08 19:16   ` [Qemu-devel] " Alex Williamson
2010-06-08 20:12   ` Anthony Liguori
2010-06-08 20:12     ` [Qemu-devel] " Anthony Liguori
2010-06-08 21:12     ` Alex Williamson
2010-06-08 21:12       ` [Qemu-devel] " Alex Williamson
2010-06-08 20:54   ` Chris Wright
2010-06-08 20:54     ` [Qemu-devel] " Chris Wright
2010-06-08 21:22     ` Alex Williamson
2010-06-08 21:22       ` [Qemu-devel] " Alex Williamson
2010-06-08 19:16 ` [RFC PATCH 6/6] savevm: Use RAM blocks for basis of migration Alex Williamson
2010-06-08 19:16   ` [Qemu-devel] " Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100608191520.4451.1193.stgit@localhost.localdomain \
    --to=alex.williamson@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=chrisw@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.