From: Paul Brook <paul@codesourcery.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, chrisw@redhat.com, kvm@vger.kernel.org,
quintela@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
Date: Fri, 11 Jun 2010 17:12:35 +0100 [thread overview]
Message-ID: <201006111712.35756.paul@codesourcery.com> (raw)
In-Reply-To: <1276271431.3100.26.camel@x201>
> The trouble I'm running into is that the SaveStateEntry.instance_id is
> effectively private, and there's no easy way to associate a
> SaveStateEntry to a device since it passes an opaque pointer, which
> could be whatever the driver decides it wants. I'm wondering if we
> should pass the DeviceState pointer in when registering the vmstate so
> that we can stuff the instance_id into the DeviceInfo. Or maybe
> DeviceInfo should include a pointer to the SaveStateEntry. It all seems
> pretty messy. Any thoughts?
DeviceInfo is effectively a const structure (it may be modified at startup,
but there's only one of it shared between multiple devices). I suspect you
mean DeviceState.
Most likely a lot of the messyness is because we still have devices that have
not been qdev-ified, so the VMState code can't assume it has a device. We
should fix this.
Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Brook <paul@codesourcery.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
Date: Fri, 11 Jun 2010 17:12:35 +0100 [thread overview]
Message-ID: <201006111712.35756.paul@codesourcery.com> (raw)
In-Reply-To: <1276271431.3100.26.camel@x201>
> The trouble I'm running into is that the SaveStateEntry.instance_id is
> effectively private, and there's no easy way to associate a
> SaveStateEntry to a device since it passes an opaque pointer, which
> could be whatever the driver decides it wants. I'm wondering if we
> should pass the DeviceState pointer in when registering the vmstate so
> that we can stuff the instance_id into the DeviceInfo. Or maybe
> DeviceInfo should include a pointer to the SaveStateEntry. It all seems
> pretty messy. Any thoughts?
DeviceInfo is effectively a const structure (it may be modified at startup,
but there's only one of it shared between multiple devices). I suspect you
mean DeviceState.
Most likely a lot of the messyness is because we still have devices that have
not been qdev-ified, so the VMState code can't assume it has a device. We
should fix this.
Paul
next prev parent reply other threads:[~2010-06-11 16:13 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 19:14 [RFC PATCH 0/6] RAM migration overhaul Alex Williamson
2010-06-08 19:14 ` [Qemu-devel] " Alex Williamson
2010-06-08 19:15 ` [RFC PATCH 1/6] qemu_ram_alloc: Remove duplicate code Alex Williamson
2010-06-08 19:15 ` [Qemu-devel] " Alex Williamson
2010-06-08 21:00 ` Chris Wright
2010-06-08 21:00 ` [Qemu-devel] " Chris Wright
2010-06-08 19:15 ` [RFC PATCH 2/6] ram_blocks: Convert to a QLIST Alex Williamson
2010-06-08 19:15 ` [Qemu-devel] " Alex Williamson
2010-06-08 21:26 ` Chris Wright
2010-06-08 21:26 ` [Qemu-devel] " Chris Wright
2010-06-08 21:45 ` Alex Williamson
2010-06-08 21:45 ` [Qemu-devel] " Alex Williamson
2010-06-08 21:51 ` Chris Wright
2010-06-08 21:51 ` [Qemu-devel] " Chris Wright
2010-06-09 8:19 ` Juan Quintela
2010-06-09 8:19 ` [Qemu-devel] " Juan Quintela
2010-06-09 20:11 ` [Qemu-devel] " Cam Macdonell
2010-06-09 20:11 ` Cam Macdonell
2010-06-09 20:55 ` Alex Williamson
2010-06-09 20:55 ` Alex Williamson
2010-06-09 21:12 ` Yoshiaki Tamura
2010-06-09 21:12 ` Yoshiaki Tamura
2010-06-08 19:15 ` [RFC PATCH 3/6] RAMBlock: Add a name field Alex Williamson
2010-06-08 19:15 ` [Qemu-devel] " Alex Williamson
2010-06-08 20:07 ` Anthony Liguori
2010-06-08 20:07 ` [Qemu-devel] " Anthony Liguori
2010-06-08 20:09 ` Alex Williamson
2010-06-08 20:09 ` [Qemu-devel] " Alex Williamson
2010-06-08 21:41 ` Chris Wright
2010-06-08 21:41 ` [Qemu-devel] " Chris Wright
2010-06-09 3:13 ` Alex Williamson
2010-06-09 3:13 ` [Qemu-devel] " Alex Williamson
2010-06-09 11:55 ` Avi Kivity
2010-06-09 11:55 ` [Qemu-devel] " Avi Kivity
2010-06-09 12:56 ` Paul Brook
2010-06-09 12:56 ` Paul Brook
2010-06-09 2:30 ` [Qemu-devel] " Paul Brook
2010-06-09 2:30 ` Paul Brook
2010-06-09 2:40 ` Anthony Liguori
2010-06-09 2:40 ` Anthony Liguori
2010-06-09 2:54 ` Paul Brook
2010-06-09 2:54 ` Paul Brook
2010-06-09 4:19 ` Alex Williamson
2010-06-09 4:19 ` Alex Williamson
2010-06-09 12:18 ` Paul Brook
2010-06-09 12:18 ` Paul Brook
2010-06-09 16:37 ` Alex Williamson
2010-06-09 16:37 ` Alex Williamson
2010-06-09 20:36 ` Paul Brook
2010-06-09 20:36 ` Paul Brook
2010-06-10 8:23 ` Gerd Hoffmann
2010-06-10 8:23 ` Gerd Hoffmann
2010-06-10 14:33 ` Alex Williamson
2010-06-10 14:33 ` Alex Williamson
2010-06-10 14:49 ` Paul Brook
2010-06-10 14:49 ` Paul Brook
2010-06-10 15:21 ` Alex Williamson
2010-06-10 15:21 ` Alex Williamson
2010-06-11 8:48 ` Gerd Hoffmann
2010-06-11 8:48 ` Gerd Hoffmann
2010-06-11 15:50 ` Alex Williamson
2010-06-11 15:50 ` Alex Williamson
2010-06-11 16:12 ` Paul Brook [this message]
2010-06-11 16:12 ` Paul Brook
2010-06-11 8:45 ` Gerd Hoffmann
2010-06-11 8:45 ` Gerd Hoffmann
2010-06-10 15:05 ` Alex Williamson
2010-06-10 15:05 ` Alex Williamson
2010-06-10 16:40 ` Chris Wright
2010-06-10 16:40 ` Chris Wright
2010-06-10 16:45 ` Paul Brook
2010-06-10 16:45 ` Paul Brook
2010-06-09 11:58 ` Avi Kivity
2010-06-09 11:58 ` Avi Kivity
2010-06-09 13:57 ` Anthony Liguori
2010-06-09 13:57 ` Anthony Liguori
2010-06-09 14:09 ` Paul Brook
2010-06-09 14:09 ` Paul Brook
2010-06-09 7:28 ` Gerd Hoffmann
2010-06-09 7:28 ` Gerd Hoffmann
2010-06-08 19:16 ` [RFC PATCH 4/6] Remove uses of ram.last_offset (aka last_ram_offset) Alex Williamson
2010-06-08 19:16 ` [Qemu-devel] " Alex Williamson
2010-06-08 19:16 ` [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset Alex Williamson
2010-06-08 19:16 ` [Qemu-devel] " Alex Williamson
2010-06-08 20:12 ` Anthony Liguori
2010-06-08 20:12 ` [Qemu-devel] " Anthony Liguori
2010-06-08 21:12 ` Alex Williamson
2010-06-08 21:12 ` [Qemu-devel] " Alex Williamson
2010-06-08 20:54 ` Chris Wright
2010-06-08 20:54 ` [Qemu-devel] " Chris Wright
2010-06-08 21:22 ` Alex Williamson
2010-06-08 21:22 ` [Qemu-devel] " Alex Williamson
2010-06-08 19:16 ` [RFC PATCH 6/6] savevm: Use RAM blocks for basis of migration Alex Williamson
2010-06-08 19:16 ` [Qemu-devel] " Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006111712.35756.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=chrisw@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.