From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()
Date: Sat, 26 Jun 2010 00:38:23 +0000 [thread overview]
Message-ID: <20100626093823.ab4eb33c.takuya.yoshikawa@gmail.com> (raw)
In-Reply-To: <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp>
On Fri, 25 Jun 2010 21:25:57 +0200
Alexander Graf <agraf@suse.de> wrote:
>
> This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get around to track down why, but I figured you should now. Is there any way to get you a PPC development box? A simple G4 or G5 should be 200$ on ebay by now :).
>
I'm sorry, I thought this change was just trivial code transformation
and test for x86 would be OK: but not actually. Probably the reason is
around the timing of copy_to_user() and newly introduced clear_user()
for clean slot.
>
> Alex
>
WARNING: multiple messages have this Message-ID (diff)
From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: Takuya Yoshikawa
<yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>,
avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()
Date: Sat, 26 Jun 2010 00:38:23 +0000 [thread overview]
Message-ID: <20100626093823.ab4eb33c.takuya.yoshikawa@gmail.com> (raw)
In-Reply-To: <E5BC6546-6255-4E25-B3DD-F6B6261B6830-l3A5Bk7waGM@public.gmane.org>
On Fri, 25 Jun 2010 21:25:57 +0200
Alexander Graf <agraf@suse.de> wrote:
>
> This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get around to track down why, but I figured you should now. Is there any way to get you a PPC development box? A simple G4 or G5 should be 200$ on ebay by now :).
>
I'm sorry, I thought this change was just trivial code transformation
and test for x86 would be OK: but not actually. Probably the reason is
around the timing of copy_to_user() and newly introduced clear_user()
for clean slot.
>
> Alex
>
WARNING: multiple messages have this Message-ID (diff)
From: Takuya Yoshikawa <takuya.yoshikawa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: Takuya Yoshikawa
<yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>,
avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()
Date: Sat, 26 Jun 2010 09:38:23 +0900 [thread overview]
Message-ID: <20100626093823.ab4eb33c.takuya.yoshikawa@gmail.com> (raw)
In-Reply-To: <E5BC6546-6255-4E25-B3DD-F6B6261B6830-l3A5Bk7waGM@public.gmane.org>
On Fri, 25 Jun 2010 21:25:57 +0200
Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org> wrote:
>
> This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get around to track down why, but I figured you should now. Is there any way to get you a PPC development box? A simple G4 or G5 should be 200$ on ebay by now :).
>
I'm sorry, I thought this change was just trivial code transformation
and test for x86 would be OK: but not actually. Probably the reason is
around the timing of copy_to_user() and newly introduced clear_user()
for clean slot.
>
> Alex
>
next prev parent reply other threads:[~2010-06-26 0:38 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 6:01 [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Takuya Yoshikawa
2010-06-23 6:01 ` Takuya Yoshikawa
2010-06-23 6:01 ` Takuya Yoshikawa
2010-06-23 8:48 ` Avi Kivity
2010-06-23 8:48 ` Avi Kivity
2010-06-23 8:48 ` Avi Kivity
2010-06-23 8:56 ` Takuya Yoshikawa
2010-06-23 9:01 ` Takuya Yoshikawa
2010-06-23 8:56 ` Takuya Yoshikawa
2010-06-23 9:00 ` Avi Kivity
2010-06-23 9:00 ` Avi Kivity
2010-06-23 9:00 ` Avi Kivity
2010-06-24 0:58 ` Marcelo Tosatti
2010-06-24 0:58 ` Marcelo Tosatti
2010-06-24 0:58 ` Marcelo Tosatti
2010-06-24 8:10 ` Avi Kivity
2010-06-24 8:10 ` Avi Kivity
2010-06-24 8:10 ` Avi Kivity
2010-06-25 19:25 ` Alexander Graf
2010-06-25 19:25 ` Alexander Graf
2010-06-25 19:25 ` Alexander Graf
2010-06-26 0:38 ` Takuya Yoshikawa [this message]
2010-06-26 0:38 ` Takuya Yoshikawa
2010-06-26 0:38 ` Takuya Yoshikawa
2010-06-26 0:55 ` Takuya Yoshikawa
2010-06-26 0:55 ` Takuya Yoshikawa
2010-06-26 0:55 ` Takuya Yoshikawa
2010-06-26 9:38 ` Alexander Graf
2010-06-26 9:38 ` Alexander Graf
2010-06-26 9:38 ` Alexander Graf
2010-06-27 7:32 ` Avi Kivity
2010-06-27 7:32 ` Avi Kivity
2010-06-27 7:32 ` Avi Kivity
2010-06-28 8:14 ` Takuya Yoshikawa
2010-06-28 8:14 ` Takuya Yoshikawa
2010-06-28 8:14 ` Takuya Yoshikawa
2010-06-28 9:36 ` Avi Kivity
2010-06-28 9:36 ` Avi Kivity
2010-06-28 9:36 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-06-23 6:02 [PATCH v2 4/4] KVM: cleanup: make kvm_vm_ioctl_get_dirty_log() arch Takuya Yoshikawa
2010-06-23 6:02 ` [PATCH v2 4/4] KVM: cleanup: make kvm_vm_ioctl_get_dirty_log() arch independent Takuya Yoshikawa
2010-06-23 6:02 ` [PATCH v2 4/4] KVM: cleanup: make kvm_vm_ioctl_get_dirty_log() arch Takuya Yoshikawa
2010-06-23 5:59 [PATCH v2 2/4] KVM: ia64: cleanup kvm_ia64_sync_dirty_log() Takuya Yoshikawa
2010-06-23 6:00 ` Takuya Yoshikawa
2010-06-23 5:59 ` Takuya Yoshikawa
2010-06-23 5:59 [PATCH v2 1/4] KVM: ia64: fix dirty_log_lock spin_lock section not Takuya Yoshikawa
2010-06-23 5:59 ` [PATCH v2 1/4] KVM: ia64: fix dirty_log_lock spin_lock section not to include get_dirty_log() Takuya Yoshikawa
2010-06-23 5:59 ` [PATCH v2 1/4] KVM: ia64: fix dirty_log_lock spin_lock section not Takuya Yoshikawa
2010-06-23 5:58 [PATCH v2 0/4] KVM: kvm_vm_ioctl_get_dirty_log() fix and cleanup Takuya Yoshikawa
2010-06-23 5:58 ` Takuya Yoshikawa
2010-06-23 5:58 ` Takuya Yoshikawa
2010-06-23 8:50 ` Avi Kivity
2010-06-23 8:50 ` Avi Kivity
2010-06-23 8:50 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100626093823.ab4eb33c.takuya.yoshikawa@gmail.com \
--to=takuya.yoshikawa@gmail.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.