From: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Andy Whitcroft <apw-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Paul Goyette <paul-3orOWTcw9wBWk0Htik3J/w@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line
Date: Sun, 11 Jul 2010 14:15:47 -0700 [thread overview]
Message-ID: <20100711211547.GA24666@ericsson.com> (raw)
In-Reply-To: <1278877979.1501.76.camel-AkRN8/LKpobuYGix6ZUp1Q@public.gmane.org>
On Sun, Jul 11, 2010 at 03:52:59PM -0400, Joe Perches wrote:
> On Sun, 2010-07-11 at 21:34 +0200, Jean Delvare wrote:
> > On Sun, 11 Jul 2010 11:57:12 -0700, Joe Perches wrote:
> > > I don't remember that discussion. Link?
> > http://lkml.org/lkml/2009/12/5/65
> > You started the thread, so I would think you'd remember it.
>
> Though there are differences in opinion about what's important,
> I try to forget the trivial. Just ask my sweet wife...
>
Same issue hit me twice now, so it isn't as if nobody cares.
For my part, I don't care where to put the &&. But I would like to have a means
to get beyond the basic stuff before submitting my patches, to give reviewers
an opportunity to find the _real_ problems in my code.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Joe Perches <joe@perches.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Hans de Goede <hdegoede@redhat.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
Paul Goyette <paul@whooppee.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line
Date: Sun, 11 Jul 2010 14:15:47 -0700 [thread overview]
Message-ID: <20100711211547.GA24666@ericsson.com> (raw)
In-Reply-To: <1278877979.1501.76.camel@Joe-Laptop.home>
On Sun, Jul 11, 2010 at 03:52:59PM -0400, Joe Perches wrote:
> On Sun, 2010-07-11 at 21:34 +0200, Jean Delvare wrote:
> > On Sun, 11 Jul 2010 11:57:12 -0700, Joe Perches wrote:
> > > I don't remember that discussion. Link?
> > http://lkml.org/lkml/2009/12/5/65
> > You started the thread, so I would think you'd remember it.
>
> Though there are differences in opinion about what's important,
> I try to forget the trivial. Just ask my sweet wife...
>
Same issue hit me twice now, so it isn't as if nobody cares.
For my part, I don't care where to put the &&. But I would like to have a means
to get beyond the basic stuff before submitting my patches, to give reviewers
an opportunity to find the _real_ problems in my code.
Guenter
next prev parent reply other threads:[~2010-07-11 21:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 14:53 [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Guenter Roeck
2010-07-11 14:53 ` Guenter Roeck
[not found] ` <1278859984-22593-1-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-07-11 15:31 ` Joe Perches
2010-07-11 15:31 ` Joe Perches
[not found] ` <1278862266.1501.59.camel-AkRN8/LKpobuYGix6ZUp1Q@public.gmane.org>
2010-07-11 16:16 ` Guenter Roeck
2010-07-11 16:16 ` Guenter Roeck
2010-07-11 16:21 ` Jean Delvare
2010-07-11 16:21 ` Jean Delvare
[not found] ` <20100711182138.132815e4-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-07-11 18:57 ` [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line Joe Perches
2010-07-11 18:57 ` Joe Perches
[not found] ` <1278874632.1501.68.camel-AkRN8/LKpobuYGix6ZUp1Q@public.gmane.org>
2010-07-11 19:34 ` Jean Delvare
2010-07-11 19:34 ` Jean Delvare
[not found] ` <20100711213444.4243014c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-07-11 19:52 ` Joe Perches
2010-07-11 19:52 ` Joe Perches
[not found] ` <1278877979.1501.76.camel-AkRN8/LKpobuYGix6ZUp1Q@public.gmane.org>
2010-07-11 21:15 ` Guenter Roeck [this message]
2010-07-11 21:15 ` Guenter Roeck
2010-07-12 22:49 ` [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Andrew Morton
2010-07-12 22:49 ` Andrew Morton
[not found] ` <20100712154949.3230beec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-07-12 23:07 ` Guenter Roeck
2010-07-12 23:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100711211547.GA24666@ericsson.com \
--to=guenter.roeck-izefyvvap7pwk0htik3j/w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=apw-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=paul-3orOWTcw9wBWk0Htik3J/w@public.gmane.org \
--cc=rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.