From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Wang Sheng-Hui <crosslonelyover@gmail.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-mm@kvack.org, linux-ext4 <linux-ext4@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
a.gruenbacher@computer.org
Subject: Re: [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan
Date: Sun, 18 Jul 2010 06:01:06 +0000 [thread overview]
Message-ID: <20100718060106.GA579@infradead.org> (raw)
In-Reply-To: <4C427DC8.6020504@redhat.com>
On Sat, Jul 17, 2010 at 11:06:32PM -0500, Eric Sandeen wrote:
> + /* Count remaining entries */
> + spin_lock(&mb_cache_spinlock);
> + list_for_each(l, &mb_cache_list) {
> + struct mb_cache *cache > + list_entry(l, struct mb_cache, c_cache_list);
This should be using list_for_each_entry.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Wang Sheng-Hui <crosslonelyover@gmail.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-mm@kvack.org, linux-ext4 <linux-ext4@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
a.gruenbacher@computer.org
Subject: Re: [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0
Date: Sun, 18 Jul 2010 02:01:06 -0400 [thread overview]
Message-ID: <20100718060106.GA579@infradead.org> (raw)
In-Reply-To: <4C427DC8.6020504@redhat.com>
On Sat, Jul 17, 2010 at 11:06:32PM -0500, Eric Sandeen wrote:
> + /* Count remaining entries */
> + spin_lock(&mb_cache_spinlock);
> + list_for_each(l, &mb_cache_list) {
> + struct mb_cache *cache =
> + list_entry(l, struct mb_cache, c_cache_list);
This should be using list_for_each_entry.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-18 6:01 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 1:01 [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > Wang Sheng-Hui
2010-07-18 1:01 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Wang Sheng-Hui
2010-07-18 1:01 ` Wang Sheng-Hui
2010-07-18 4:06 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Eric Sandeen
2010-07-18 4:06 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Eric Sandeen
2010-07-18 4:06 ` Eric Sandeen
2010-07-18 6:01 ` Christoph Hellwig [this message]
2010-07-18 6:01 ` Christoph Hellwig
2010-07-18 6:36 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Wang Sheng-Hui
2010-07-18 6:36 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Wang Sheng-Hui
2010-07-18 6:36 ` Wang Sheng-Hui
2010-07-19 18:39 ` Andreas Gruenbacher
2010-07-19 18:39 ` Andreas Gruenbacher
2010-07-20 1:02 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > shenghui
2010-07-20 1:02 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 shenghui
2010-07-20 1:04 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > shenghui
2010-07-20 1:04 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 shenghui
2010-07-20 1:04 ` shenghui
2010-07-20 15:13 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Eric Sandeen
2010-07-20 15:13 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Eric Sandeen
2010-07-20 16:34 ` Andreas Gruenbacher
2010-07-20 16:34 ` Andreas Gruenbacher
2010-07-20 16:34 ` Andreas Gruenbacher
2010-07-19 18:40 ` Andreas Gruenbacher
2010-07-19 18:40 ` Andreas Gruenbacher
2010-07-21 10:53 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > Wang Sheng-Hui
2010-07-21 10:53 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Wang Sheng-Hui
2010-07-21 10:53 ` Wang Sheng-Hui
2010-07-21 10:53 ` Wang Sheng-Hui
2010-07-21 14:00 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Eric Sandeen
2010-07-21 14:00 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Eric Sandeen
2010-07-21 14:00 ` Eric Sandeen
2010-07-19 16:19 ` [PATCH 1/2] mbcache: Remove unused features Andreas Gruenbacher
2010-07-19 16:19 ` Andreas Gruenbacher
2010-07-19 16:19 ` Andreas Gruenbacher
2010-07-21 23:18 ` Andreas Dilger
2010-07-22 0:07 ` Andreas Gruenbacher
2010-07-21 17:44 ` [PATCH 2/2] mbcache: fix shrinker function return value Andreas Gruenbacher
2010-07-21 17:44 ` Andreas Gruenbacher
2010-07-21 17:44 ` Andreas Gruenbacher
2010-07-21 17:57 ` [PATCH 0/2] mbcache fixes Andreas Gruenbacher
2010-07-21 17:57 ` Andreas Gruenbacher
2010-07-21 17:57 ` Andreas Gruenbacher
2010-07-21 23:22 ` Al Viro
2010-07-21 23:22 ` Al Viro
2010-07-21 23:22 ` Al Viro
2010-07-22 0:54 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Wang Sheng-Hui
2010-07-22 0:54 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Wang Sheng-Hui
2010-07-22 0:54 ` Wang Sheng-Hui
2010-07-22 0:54 ` Wang Sheng-Hui
2010-07-22 1:06 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > shenghui
2010-07-22 1:06 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 shenghui
2010-07-22 1:06 ` shenghui
2010-07-22 1:06 ` shenghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100718060106.GA579@infradead.org \
--to=hch@infradead.org \
--cc=a.gruenbacher@computer.org \
--cc=crosslonelyover@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sandeen@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.