From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Peter Tyser <ptyser@xes-inc.com>,
Doug Thompson <dougthompson@xmission.com>,
linux-kernel@vger.kernel.org, Dave Jiang <djiang@mvista.com>
Subject: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix)
Date: Sun, 1 Aug 2010 14:54:19 +0400 [thread overview]
Message-ID: <20100801105419.GA352@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100721182108.5a22c822@schlenkerla.am.freescale.net>
On Wed, Jul 21, 2010 at 06:21:08PM -0500, Scott Wood wrote:
[...]
> > > > + { .compatible = "fsl,p4080-l2-cache-controller", },
> > >
> > > L2 on the p4080 is quite different from those other chips. It's part
> > > of the core, controlled by SPRs.
> >
> > erm, was that an ack or a nack?
>
> NACK, p4080 doesn't belong in this table, at least not its L2.
>
> L3 on p4080 is similar to L2 on these other chips, though, and it
> wouldn't take much to get this driver working on it -- but the match
> table entry should wait until the differences are accommodated.
Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
---
Scott, thanks for catching this!
Andrew, please merge this patch into
edac-mpc85xx-add-support-for-new-mpcxxx-pxxxx-edac-controllers.patch
Thanks!
drivers/edac/mpc85xx_edac.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index cfa86f7..b178cfa 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -652,7 +652,6 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = {
{ .compatible = "fsl,p1020-l2-cache-controller", },
{ .compatible = "fsl,p1021-l2-cache-controller", },
{ .compatible = "fsl,p2020-l2-cache-controller", },
- { .compatible = "fsl,p4080-l2-cache-controller", },
{},
};
MODULE_DEVICE_TABLE(of, mpc85xx_l2_err_of_match);
--
1.7.0.5
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Scott Wood <scottwood@freescale.com>
Cc: Peter Tyser <ptyser@xes-inc.com>,
linux-kernel@vger.kernel.org, Dave Jiang <djiang@mvista.com>,
linuxppc-dev@ozlabs.org,
Doug Thompson <dougthompson@xmission.com>
Subject: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix)
Date: Sun, 1 Aug 2010 14:54:19 +0400 [thread overview]
Message-ID: <20100801105419.GA352@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100721182108.5a22c822@schlenkerla.am.freescale.net>
On Wed, Jul 21, 2010 at 06:21:08PM -0500, Scott Wood wrote:
[...]
> > > > + { .compatible = "fsl,p4080-l2-cache-controller", },
> > >
> > > L2 on the p4080 is quite different from those other chips. It's part
> > > of the core, controlled by SPRs.
> >
> > erm, was that an ack or a nack?
>
> NACK, p4080 doesn't belong in this table, at least not its L2.
>
> L3 on p4080 is similar to L2 on these other chips, though, and it
> wouldn't take much to get this driver working on it -- but the match
> table entry should wait until the differences are accommodated.
Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
---
Scott, thanks for catching this!
Andrew, please merge this patch into
edac-mpc85xx-add-support-for-new-mpcxxx-pxxxx-edac-controllers.patch
Thanks!
drivers/edac/mpc85xx_edac.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index cfa86f7..b178cfa 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -652,7 +652,6 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = {
{ .compatible = "fsl,p1020-l2-cache-controller", },
{ .compatible = "fsl,p1021-l2-cache-controller", },
{ .compatible = "fsl,p2020-l2-cache-controller", },
- { .compatible = "fsl,p4080-l2-cache-controller", },
{},
};
MODULE_DEVICE_TABLE(of, mpc85xx_l2_err_of_match);
--
1.7.0.5
next prev parent reply other threads:[~2010-08-01 10:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:25 [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers Anton Vorontsov
2010-07-15 18:25 ` Anton Vorontsov
2010-07-16 20:12 ` Scott Wood
2010-07-16 20:12 ` Scott Wood
2010-07-21 22:39 ` Andrew Morton
2010-07-21 22:39 ` Andrew Morton
2010-07-21 23:21 ` Scott Wood
2010-07-21 23:21 ` Scott Wood
2010-08-01 10:54 ` Anton Vorontsov [this message]
2010-08-01 10:54 ` [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) Anton Vorontsov
2010-10-07 6:18 ` Kumar Gala
2010-10-07 6:18 ` Kumar Gala
2010-10-07 6:29 ` Anton Vorontsov
2010-10-07 6:29 ` Anton Vorontsov
2010-10-07 6:37 ` Kumar Gala
2010-10-07 6:37 ` Kumar Gala
2010-10-07 7:00 ` Kumar Gala
2010-10-07 7:00 ` Kumar Gala
2010-10-07 7:12 ` Anton Vorontsov
2010-10-07 7:12 ` Anton Vorontsov
2010-10-07 13:21 ` Kumar Gala
2010-10-07 13:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100801105419.GA352@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=djiang@mvista.com \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ptyser@xes-inc.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.