From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
Dave Jiang <djiang@mvista.com>, Peter Tyser <ptyser@xes-inc.com>,
Doug Thompson <dougthompson@xmission.com>,
Scott Wood <scottwood@freescale.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix)
Date: Thu, 7 Oct 2010 11:12:26 +0400 [thread overview]
Message-ID: <20101007071226.GA32189@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4A00FECC-3840-45E1-AB2A-6BDBD0FE09E0@kernel.crashing.org>
On Thu, Oct 07, 2010 at 02:00:50AM -0500, Kumar Gala wrote:
>
> On Oct 7, 2010, at 1:37 AM, Kumar Gala wrote:
>
> >> @ -1125,7 +1128,10 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = {
> >> { .compatible = "fsl,mpc8569-memory-controller", },
> >> { .compatible = "fsl,mpc8572-memory-controller", },
> >> { .compatible = "fsl,mpc8349-memory-controller", },
> >> + { .compatible = "fsl,p1020-memory-controller", },
> >> + { .compatible = "fsl,p1021-memory-controller", },
> >> { .compatible = "fsl,p2020-memory-controller", },
> >> + { .compatible = "fsl,p4080-memory-controller", },
> >
> > This line should be here ;)
>
> should NOT be here.
Hm. Are you sure? I thought that only L2 cache controller is
not applicable (and based on Scott's comment I removed
the l2 cache compatible entry for p4080). But I guess
memory-controller is somewhat similar to all other 85xx?
If it's not, I can surely prepare a patch that removes
p4080 entry.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Scott Wood <scottwood@freescale.com>,
Peter Tyser <ptyser@xes-inc.com>,
linux-kernel@vger.kernel.org, Dave Jiang <djiang@mvista.com>,
linuxppc-dev@ozlabs.org,
Doug Thompson <dougthompson@xmission.com>
Subject: Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix)
Date: Thu, 7 Oct 2010 11:12:26 +0400 [thread overview]
Message-ID: <20101007071226.GA32189@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4A00FECC-3840-45E1-AB2A-6BDBD0FE09E0@kernel.crashing.org>
On Thu, Oct 07, 2010 at 02:00:50AM -0500, Kumar Gala wrote:
>
> On Oct 7, 2010, at 1:37 AM, Kumar Gala wrote:
>
> >> @ -1125,7 +1128,10 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = {
> >> { .compatible = "fsl,mpc8569-memory-controller", },
> >> { .compatible = "fsl,mpc8572-memory-controller", },
> >> { .compatible = "fsl,mpc8349-memory-controller", },
> >> + { .compatible = "fsl,p1020-memory-controller", },
> >> + { .compatible = "fsl,p1021-memory-controller", },
> >> { .compatible = "fsl,p2020-memory-controller", },
> >> + { .compatible = "fsl,p4080-memory-controller", },
> >
> > This line should be here ;)
>
> should NOT be here.
Hm. Are you sure? I thought that only L2 cache controller is
not applicable (and based on Scott's comment I removed
the l2 cache compatible entry for p4080). But I guess
memory-controller is somewhat similar to all other 85xx?
If it's not, I can surely prepare a patch that removes
p4080 entry.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-10-07 7:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:25 [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers Anton Vorontsov
2010-07-15 18:25 ` Anton Vorontsov
2010-07-16 20:12 ` Scott Wood
2010-07-16 20:12 ` Scott Wood
2010-07-21 22:39 ` Andrew Morton
2010-07-21 22:39 ` Andrew Morton
2010-07-21 23:21 ` Scott Wood
2010-07-21 23:21 ` Scott Wood
2010-08-01 10:54 ` [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) Anton Vorontsov
2010-08-01 10:54 ` Anton Vorontsov
2010-10-07 6:18 ` Kumar Gala
2010-10-07 6:18 ` Kumar Gala
2010-10-07 6:29 ` Anton Vorontsov
2010-10-07 6:29 ` Anton Vorontsov
2010-10-07 6:37 ` Kumar Gala
2010-10-07 6:37 ` Kumar Gala
2010-10-07 7:00 ` Kumar Gala
2010-10-07 7:00 ` Kumar Gala
2010-10-07 7:12 ` Anton Vorontsov [this message]
2010-10-07 7:12 ` Anton Vorontsov
2010-10-07 13:21 ` Kumar Gala
2010-10-07 13:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007071226.GA32189@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=djiang@mvista.com \
--cc=dougthompson@xmission.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ptyser@xes-inc.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.